genode/repos/os/include/vfs/value_file_system.h
Norman Feske bdf47785b8 vfs: remove 'file_size' from read/write interfaces
The 'file_size' type denotes the size of files on disk in bytes. On
32-bit architectures it is larger than the size_t, which refers to
in-memory object sizes.

Whereas the use of 'file_size' is appropriate for ftruncate and seek, it
is not a suitable type for the parameters of read/write operations
because those operations refer to in-memory buffers.

This patch replaces the use of 'file_size' by size_t. However, since it
affects all sites where the read/write interface is uses, it takes the
opportunity to replace the C-style (pointer, size) arguments by
'Byte_range_ptr' and 'Const_byte_range_ptr'.

Issue #4706
2023-02-27 08:22:49 +01:00

230 lines
5.3 KiB
C++

/*
* \brief File system for providing a value as a file
* \author Josef Soentgen
* \author Sebastian Sumpf
* \date 2018-11-24
*/
/*
* Copyright (C) 2018-2019 Genode Labs GmbH
*
* This file is part of the Genode OS framework, which is distributed
* under the terms of the GNU Affero General Public License version 3.
*/
#ifndef _VALUE_FILE_SYSTEM_H_
#define _VALUE_FILE_SYSTEM_H_
/* Genode includes */
#include <util/xml_generator.h>
#include <vfs/single_file_system.h>
namespace Vfs {
template <typename, unsigned BUF_SIZE = 64>
class Value_file_system;
}
template <typename T, unsigned BUF_SIZE>
class Vfs::Value_file_system : public Vfs::Single_file_system
{
public:
typedef Genode::String<64> Name;
private:
typedef Genode::String<BUF_SIZE + 1> Buffer;
Name const _file_name;
Buffer _buffer { };
struct Vfs_handle : Single_vfs_handle
{
Value_file_system &_value_fs;
Buffer &_buffer{ _value_fs._buffer };
Vfs_handle(Value_file_system &value_fs,
Allocator &alloc)
:
Single_vfs_handle(value_fs, value_fs, alloc, 0),
_value_fs(value_fs)
{ }
Read_result read(Byte_range_ptr const &dst, size_t &out_count) override
{
out_count = 0;
if (seek() > _buffer.length())
return READ_ERR_INVALID;
char const * const src = _buffer.string() + seek();
size_t const len = min((size_t)(_buffer.length() - seek()), dst.num_bytes);
memcpy(dst.start, src, len);
out_count = len;
return READ_OK;
}
Write_result write(Const_byte_range_ptr const &src, size_t &out_count) override
{
out_count = 0;
if (seek() > BUF_SIZE)
return WRITE_ERR_INVALID;
size_t const len = min(size_t(BUF_SIZE- seek()), src.num_bytes);
_buffer = Buffer(Genode::Cstring(src.start, len));
out_count = len;
/* inform watchers */
_value_fs._watch_response();
return WRITE_OK;
}
bool read_ready() const override { return true; }
bool write_ready() const override { return true; }
private:
Vfs_handle(Vfs_handle const &);
Vfs_handle &operator = (Vfs_handle const &);
};
struct Watch_handle;
using Watch_handle_registry = Genode::Registry<Watch_handle>;
struct Watch_handle : Vfs_watch_handle
{
typename Watch_handle_registry::Element elem;
Watch_handle(Watch_handle_registry &registry,
Vfs::File_system &fs,
Allocator &alloc)
: Vfs_watch_handle(fs, alloc), elem(registry, *this) { }
};
Watch_handle_registry _watch_handle_registry { };
void _watch_response() {
_watch_handle_registry.for_each([&] (Watch_handle &h) {
h.watch_response();
});
}
typedef Genode::String<200> Config;
Config _config(Name const &name) const
{
char buf[Config::capacity()] { };
Genode::Xml_generator xml(buf, sizeof(buf), type_name(), [&] () {
xml.attribute("name", name); });
return Config(Genode::Cstring(buf));
}
public:
Value_file_system(Name const &name, Buffer const &initial_value)
:
Single_file_system(Node_type::TRANSACTIONAL_FILE, type(),
Node_rwx::rw(), Xml_node(_config(name).string())),
_file_name(name)
{
value(initial_value);
}
static char const *type_name() { return "value"; }
char const *type() override { return type_name(); }
void value(Buffer const &value)
{
_buffer = Buffer(value);
}
T value()
{
T val { 0 };
Genode::ascii_to(_buffer.string(), val);
return val;
}
Buffer buffer() const { return _buffer; }
bool matches(Xml_node node) const
{
return node.has_type(type_name()) &&
node.attribute_value("name", Name()) == _file_name;
}
/********************************
** File I/O service interface **
********************************/
Ftruncate_result ftruncate(Vfs::Vfs_handle *, file_size size) override
{
if (size >= BUF_SIZE)
return FTRUNCATE_ERR_NO_SPACE;
return FTRUNCATE_OK;
}
/*********************************
** Directory-service interface **
*********************************/
Open_result open(char const *path, unsigned,
Vfs::Vfs_handle **out_handle,
Allocator &alloc) override
{
if (!_single_file(path))
return OPEN_ERR_UNACCESSIBLE;
try {
*out_handle = new (alloc) Vfs_handle(*this, alloc);
return OPEN_OK;
}
catch (Genode::Out_of_ram) { Genode::error("out of ram"); return OPEN_ERR_OUT_OF_RAM; }
catch (Genode::Out_of_caps) { Genode::error("out of caps");return OPEN_ERR_OUT_OF_CAPS; }
}
Stat_result stat(char const *path, Stat &out) override
{
Stat_result result = Single_file_system::stat(path, out);
out.size = _buffer.length();
return result;
}
Watch_result watch(char const *path,
Vfs_watch_handle **handle,
Allocator &alloc) override
{
if (!_single_file(path))
return WATCH_ERR_UNACCESSIBLE;
try {
Watch_handle *wh = new (alloc)
Watch_handle(_watch_handle_registry, *this, alloc);
*handle = wh;
return WATCH_OK;
}
catch (Genode::Out_of_ram) { return WATCH_ERR_OUT_OF_RAM; }
catch (Genode::Out_of_caps) { return WATCH_ERR_OUT_OF_CAPS; }
}
void close(Vfs_watch_handle *handle) override
{
if (handle && (&handle->fs() == this))
destroy(handle->alloc(), handle);
}
};
#endif /* _VALUE_FILE_SYSTEM_H_ */