ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-23 15:32:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

terminal: fix sporadic (underline) pixel artifact

Browse Source 
The framebuffer refresh call missed to consider that content may not
vertically start at 0.
This commit is contained in:
Norman Feske 2018-06-01 11:57:12 +02:00 committed by Christian Helmuth
parent fd7357d9d5
commit f12ddb4ee7
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
repos/gems/src/server/terminal/text_screen_surface.h
View File

@ -257,11 +257,14 @@ class Terminal::Text_screen_surface
}
int const num_dirty_lines = last_dirty_line - first_dirty_line + 1;
if (num_dirty_lines > 0)
_framebuffer.refresh(Rect(Point(0, first_dirty_line*_geometry.char_height),
Area(_geometry.fb_size.w(),
num_dirty_lines*_geometry.char_height +
_geometry.unused_pixels().h())));
if (num_dirty_lines > 0) {
int const y = _geometry.start().y()
+ first_dirty_line*_geometry.char_height;
unsigned const h = num_dirty_lines*_geometry.char_height
+ _geometry.unused_pixels().h();
_framebuffer.refresh(Rect(Point(0, y),
Area(_geometry.fb_size.w(), h)));
}
}
void apply_character(Character c)