ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-21 00:23:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Follow practices suggested by "Effective C++"

Browse Source 
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:

* A class with virtual functions can no longer publicly inherit base
  classed without a vtable. The inherited object may either be moved
  to a member variable, or inherited privately. The latter would be
  used for classes that inherit 'List::Element' or 'Avl_node'. In order
  to enable the 'List' and 'Avl_tree' to access the meta data, the
  'List' must become a friend.

* Instead of adding a virtual destructor to abstract base classes,
  we inherit the new 'Interface' class, which contains a virtual
  destructor. This way, single-line abstract base classes can stay
  as compact as they are now. The 'Interface' utility resides in
  base/include/util/interface.h.

* With the new warnings enabled, all member variables must be explicitly
  initialized. Basic types may be initialized with '='. All other types
  are initialized with braces '{ ... }' or as class initializers. If
  basic types and non-basic types appear in a row, it is nice to only
  use the brace syntax (also for basic types) and align the braces.

* If a class contains pointers as members, it must now also provide a
  copy constructor and assignment operator. In the most cases, one
  would make them private, effectively disallowing the objects to be
  copied. Unfortunately, this warning cannot be fixed be inheriting
  our existing 'Noncopyable' class (the compiler fails to detect that
  the inheriting class cannot be copied and still gives the error).
  For now, we have to manually add declarations for both the copy
  constructor and assignment operator as private class members. Those
  declarations should be prepended with a comment like this:

        /*
         * Noncopyable
         */
        Thread(Thread const &);
        Thread &operator = (Thread const &);

  In the future, we should revisit these places and try to replace
  the pointers with references. In the presence of at least one
  reference member, the compiler would no longer implicitly generate
  a copy constructor. So we could remove the manual declaration.

Issue #465
This commit is contained in:
Norman Feske
2017-12-21 15:42:15 +01:00
committed by Christian Helmuth
parent 2a33d9aa76
commit eba9c15746
763 changed files with 4936 additions and 3288 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
repos/os/src/app/pointer/main.cc
View File

@ -73,8 +73,9 @@ class Pointer::Main : public Rom::Reader
bool _default_pointer_visible = false;
Nitpicker::Area _current_pointer_size;
Genode::Dataspace_capability _pointer_ds;
Nitpicker::Area _current_pointer_size { };
Genode::Dataspace_capability _pointer_ds { };
void _resize_nitpicker_buffer_if_needed(Nitpicker::Area pointer_size);
void _show_default_pointer();
@ -86,8 +87,8 @@ class Pointer::Main : public Rom::Reader
bool _xray = false;
Genode::Constructible<Genode::Attached_rom_dataspace> _hover_ds;
Genode::Constructible<Genode::Attached_rom_dataspace> _xray_ds;
Genode::Constructible<Genode::Attached_rom_dataspace> _hover_ds { };
Genode::Constructible<Genode::Attached_rom_dataspace> _xray_ds { };
Genode::Signal_handler<Main> _hover_signal_handler {
_env.ep(), *this, &Main::_handle_hover };
@ -100,7 +101,7 @@ class Pointer::Main : public Rom::Reader
Report::Root _report_root { _env, _sliced_heap, _rom_registry, _verbose };
Genode::Session_label _hovered_label;
Genode::Session_label _hovered_label { };
Genode::Attached_ram_dataspace _texture_pixel_ds { _env.ram(), _env.rm(),
Pointer::MAX_WIDTH *
@ -368,7 +369,8 @@ Pointer::Main::Main(Genode::Env &env) : _env(env)
}
}
_nitpicker.enqueue<Nitpicker::Session::Command::To_front>(_view);
typedef Nitpicker::Session::View_handle View_handle;
_nitpicker.enqueue<Nitpicker::Session::Command::To_front>(_view, View_handle());
_nitpicker.execute();
_update_pointer();

8
repos/os/src/app/pointer/rom_registry.h
View File

@ -30,7 +30,7 @@ struct Rom::Registry : Registry_for_reader, Registry_for_writer, Genode::Noncopy
Genode::Region_map &_rm;
Reader &_reader;
Module_list _modules;
Module_list _modules { };
struct Read_write_policy : Module::Read_policy, Module::Write_policy
{
@ -55,7 +55,7 @@ struct Rom::Registry : Registry_for_reader, Registry_for_writer, Genode::Noncopy
return true;
}
} _read_write_policy;
} _read_write_policy { };
Module &_lookup(Module::Name const name, bool create_if_not_found)
{
@ -130,12 +130,12 @@ struct Rom::Registry : Registry_for_reader, Registry_for_writer, Genode::Noncopy
_try_to_destroy(module);
}
Readable_module &lookup(Reader &reader, Module::Name const &rom_label) override
Readable_module &lookup(Reader &, Module::Name const &rom_label) override
{
return _lookup(rom_label, false);
}
void release(Reader &reader, Readable_module &module) override
void release(Reader &, Readable_module &module) override
{
_try_to_destroy(static_cast<Module&>(module));
}