ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-02-21 10:01:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libdrm/lima: propagate allocation failure

Browse Source 
Failed allocations were still denoted with a successful return value
to the caller. This situation was triggered by artificial testing and
has not been observed yet in practice. In case the 'LIMA_GEM_CREATE'
I/O control fails Mesa will dereference invalid pointers anyway.

Issue genodelabs/genode-allwinner#27.
This commit is contained in:
Josef Söntgen 2023-12-19 16:31:56 +01:00 committed by Christian Helmuth
parent 602f9b5670
commit d9e4d32374
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
repos/libports/src/lib/libdrm/ioctl_lima.cc
View File

@ -765,6 +765,7 @@ class Lima::Call
_main_ctx->gpu().upgrade_ram(donate);
});
} catch (Gpu::Vram::Allocation_failed) {
_va_alloc.free(va);
return;
}
@ -776,14 +777,12 @@ class Lima::Call
{
::uint64_t const size = arg.size;
try {
_alloc_buffer(size, [&](Vram const &b) {
arg.handle = b.id().value;
});
return 0;
} catch (...) {
return -1;
}
bool result = false;
_alloc_buffer(size, [&](Vram const &b) {
arg.handle = b.id().value;
result = true;
});
return result ? 0 : -1;
}
int _drm_lima_gem_submit(drm_lima_gem_submit &arg)