ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-02-21 02:01:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gpu/intel: comment for read execlist status

Browse Source 
Adds a comment to the exec list status loop.

issue #4820
This commit is contained in:
Sebastian Sumpf 2023-04-26 13:43:06 +02:00 committed by Christian Helmuth
parent bdbfa532cd
commit 8f0a191c2a
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
repos/os/src/drivers/gpu/intel/main.cc
View File

@ -917,6 +917,12 @@ struct Igd::Device
int const port = _mmio.read<Igd::Mmio::EXECLIST_STATUS_RSCUNIT::Execlist_write_pointer>();
/*
* Exec list might still be executing, check multiple times, in the normal
* case first iteration should succeed. If still running loop should end
* after 2 or three retries. Everything else needs to be inspected.
*/
bool empty = false;
for (unsigned i = 0; i < 100; i++) {
@ -927,7 +933,11 @@ struct Igd::Device
}
}
/* write list anyway, it will preempt something in the worst case */
/*
* In case exec list is still running write list anyway, it will preempt
* something in the worst case. Nonetheless if you see the warning below,
* something is not right and should be investigated.
*/
if (!empty)
warning("exec list is not empty");