Commit Graph

6964 Commits

Author SHA1 Message Date
szymonsztuka
8c35133f70 CORDA-2504 - improve error message of missing contract attachments (#4628) (#4633)
* CORDA-2504 Improved MissingContractAttachments error to ensure it contains contractClassName.

* CORDA-2504 Improved MissingContractAttachments error to ensure it contains contractClassName - additional API overloaded method.

* Docs

(cherry picked from commit 1b89ece09b)
2019-01-24 21:41:06 +00:00
Shams Asari
9a66a3b4ee CORDA-2228 - Exceptions emanating from ReceiveFinalityFlow are sent to the flow hospital (#4621) (#4626)
(cherry picked from commit 5bb5244e55)
2019-01-24 13:32:28 +00:00
szymonsztuka
3384470f6b CORDA-2490 Attachment in the directory fails to correctly upload (#4627) (#4629)
The column 'uploader' was marked as not updatable entity so any update wasn't propagated to the database when the attachment was uploaded again and the uploader field was changed to a trusted one. Also 'saveOrUpdate' removed, the entity is already managed, saveOrUpdate is for detached/new entity.

(cherry picked from commit 9f4c8bcea5)
2019-01-24 10:23:26 +00:00
josecoll
2bc1e73833 CORDA-2485 - Add minimum platform version check before attempting a hash -> signature constraints auto migration. (#4623) (#4625) 2019-01-23 16:21:08 +00:00
Anthony Keenan
25ad122a50 CORDA-2445 - print out the underlying error when an RPC call fails (#4605) (#4615)
make it red.
2019-01-23 09:47:29 +00:00
Anthony Keenan
18d00d9e42 CORDA-2482 - Fix issue with devModeOptions.allowCompatabilityZone not working (#4613) (#4616) 2019-01-23 09:44:52 +00:00
JamesHR3
34818634d1 CORDA-2435 - Print an error and exit if the vault contains V3 states (#4619)
* Exit and raise an error if there are V3 states in the vault

* Add a test to check that old vault states are correctly detected

* Fix test to correctly close database transaction

* Update the documentation to add a warning about V3 states

* Address review comments and revert unnecessary refactor

* Address further review comments

* Add configuration option to disable exiting on V3 states

* Fix merge damage to reference.conf

* Fix issue with mock network
2019-01-23 09:42:20 +00:00
josecoll
1945b2274a CORDA-2475 - Adjust attachments query logic to return correct results (#4612) (#4622)
* CORDA-2475 Adjust attachments query logic to return correct results sets for signed/unsigned jars.

* Updates following PR review feedback by RP.
2019-01-23 09:40:34 +00:00
Dimos Raptis
dbf78d02db CORDA-2349 - Enable methods synthesized by Kotlin in api scanning (#4595) (#4601) 2019-01-18 14:19:07 +00:00
Katelyn Baker
218a92c866 RELEASE - Inc build number for 2nd RC candidate of 4.0 2019-01-16 22:13:44 +00:00
JamesHR3
131fcc65de CORDA-2432 - Update documentation for filtering by state relevancy in vault queries (#4597)
* [CORDA-2432] Update documentation for filtering by state relevancy in vault queries

* Add missing file to fix
2019-01-16 22:10:56 +00:00
Shams Asari
3b1929371c CORDA-2434 - CordaRPCClient now only has c'tors rather a mix of c'tors and factory methods (#4569) (#4578)
(cherry picked from commit 24a7821dce)
2019-01-16 19:49:32 +00:00
Katelyn Baker
6bced399d7
CORDA-2441 - Fix Stdout progress renderer to swap out correct appender (#4582) (#4594)
* Fix stdout renderer to swap out correctly named appender.

Also fix two compiler warnings

* Add clearer exception when console appender cannot be found

* Change error displayed when appender not found to warning

* Remove type declaration on separate line
2019-01-16 19:48:42 +00:00
Shams Asari
9286278f59 CORDA-2442: Added wither methods to the vault query classes (#4585)
(cherry picked from commit 498db538d7)
2019-01-16 17:41:11 +00:00
Dimos Raptis
f5148e8b6c [CORDA-2431] - Small refactorings following-up on PR-4551 (#4564)
* Small refactorings following-up on PR-4551

* Adjust thread context class loader

* Address Shams' comments
2019-01-16 14:28:38 +00:00
Dimos Raptis
0dd245b5ae [CORDA-2431] - Reduce memory footprint of classpath scanning (#4576)
* Reduce memory footprint of classpath scanning

* Close scan result in the end
2019-01-16 14:28:38 +00:00
Shams Asari
c68e1c3edd RELEASE - Fixed release branch due to various issues with back porting (#4588)
* Add back V3 TransactionBuilder c'tor (#4587)

(cherry picked from commit 5bb38e455c)

* Regen isolated jar to fix failing test(s) (#4583)

https://github.com/corda/corda/pull/4541 removed TransactionBuilder c'tor (which was introduced post-V3) which the frozen isolated jar was using
(cherry picked from commit f592025273)

* Fixed AttachmentLoadingTests (#4565)

There were two issues:
* The original "sealing violation: can't seal package net.corda.nodeapi" issue was due to the isolated CorDapp containing some code in the net.corda.nodeapi namespace. This has been moved to the isolated namespace.
* The test was not correctly creating the second transaction with the dummy command

(cherry picked from commit 3b8347e150)

* Regen isolated.jar to make sure it's based on the branch
2019-01-16 14:27:22 +00:00
Michele Sollecito
31d799f636 CORDA-2403: Flagged API issues between 4.0 and 3.3. (#4541) 2019-01-15 16:56:42 +00:00
Christian Sailer
22388d812c Corda-2209 - Make the AMQP bridge individually ACK artemis messages (so that we don't have to wait for an ack flush or end up with ack'd messages queued up). (#4568) (#4574) 2019-01-14 15:38:41 +00:00
Shams Asari
8e535b2a8a CORDA-2418 - Fixed inability to use TestCordapp under gradle in Windows if referring to self cordapp (#4562) (#4570)
The gradle process that runs the tests keeps an exclusive hold on built jars in Windows, which means if a test wants to get hold of the CorDapp, and it's requested from the same module, it will fail. Now instead of deleting the "libs" dir  we just use the latest created jar.

(cherry picked from commit 1bbcb8722e)
2019-01-14 14:32:13 +00:00
Katelyn Baker
477a46c61c RELEASE: Set RC version number 2019-01-13 20:26:48 +00:00
Dimos Raptis
5b34020e59 [CORDA-2390] - Add whitelists and custom serializers from cordapps to serialization … (#4551)
* Add whitelists and custom serializers from cordapps to serialization context

* Remove changes in TransactionBuilder, add caching

* Add whitelists and custom serializers from cordapps to serialization context

* Remove changes in TransactionBuilder, add caching

* Address comments

* Increase node memory for SIMM integration test

* Cache only serialization context

* Increase integ test timeout

* Fix API breakage

* Increase max heap size for web server integ test

* Move classloading utils from separate module to core.internal

* Adjust heap size for more integ tests

* Increase time window for IRS demo transactions

* Fix determinator

* Add parameter in core-deterministic

* Stub out class-loading method for DJVM
2019-01-13 20:15:05 +00:00
JamesHR3
36cd9b9791
[CORDA-2402] Ensure out of order transactions result in correct vault state (#4559)
* Pass states to record through to transaction resolution

* Add a test case

* Add comment indicating why states are always added in tx resolution

* Update observer node documentation
2019-01-13 15:03:53 +00:00
szymonsztuka
7a4b6b3e44
CORDA-2405 Update versions of whitelisted attachments (#4549)
The version of contract attachments that are whitelisted should be read from NetworkParameters.whitelistedContractImplementations.
It use the lattes network map from db with the highest epoch.
2019-01-13 11:38:19 +00:00
Roger Willis
084b3a1a1d
CORDA-2426 Fixed bug in state pointer search. (#4561)
* Fixed bug in state pointer search and added tests.

* Blacklisted problematic package.

* Addressed Shams' comments.

* Addressed round two of comments.

* Fixed another bug whereby the DFS gets stuck in an infinite loop.
2019-01-13 08:58:52 +00:00
Michele Sollecito
5c5407fbed Avoid TransactionBuilder behaviour change for v3 or below. (#4555) 2019-01-12 17:56:50 +00:00
Shams Asari
caad18f6db
CORDA-2347: Added backwards compatibility to SwapIdentitiesFlow (#4548)
The API has been reverted to be completely ABI compatible with V3, and the small changes that were made to the wire format in https://github.com/corda/corda/pull/4260 have also been reverted.
2019-01-12 14:23:20 +00:00
josecoll
8785bc1b84
Update Corda gradle plugins to 4.0.38 (#4558)
* Update Corda gradle plugins.

* Update Corda gradle plugins.

* Update upgrade notes.

* Minor clarification.
2019-01-12 14:03:05 +00:00
Shams Asari
6f14a9f0b9
CORDA-2406: FinalityFlow can support mix of participants using the new and old APIs (#4532)
Otherwise it's impossible to finalise a transaction and the participants are a mix of those using the new API and those using the old.
2019-01-12 12:01:23 +00:00
JamesHR3
0832587096
[CORDA-1897] Improve exception handling on startup (#4452)
* Select a console logger based on logging level

* Ensure consistent formatting

* Ensure stack traces only printed when console logging enabled
2019-01-11 17:40:32 +00:00
Florian Friemel
558d2fd45c
[CORDA-2403] Fix API breakage: PermissionException and CordappImpl constructor (#4554)
* Undo renaming of c'tor parameter (API break).
* Re-introduce default param in CordappImpl c'tor.
* Make 'msg' a property of PermissionException to make it serializable.
2019-01-11 17:39:22 +00:00
Andrius Dagys
4004e9473d Exclude BFT smart tests from the build (#4557) 2019-01-11 16:03:54 +00:00
Shams Asari
837d2d7106
Updated docs on the need to load confidential-identities CorDapp separately (#4547)
Also, updated the trader and BoC demos to include confidential-identities jar.
2019-01-11 13:51:23 +00:00
josecoll
e32ead0548
CORDA-2413 Improve exception handling and recovery for untrusted contract attachments (#4543)
* Improve exception handling and recovery for untrusted contract attachments.

* Fix broken JUnit.

* Fixed incorrect Exception description.

* Additional clarification on flow processing.

* Reasoning and future deterministic JVM clarification.

* Note::

* UntrustedAttachmentException.
2019-01-11 13:23:51 +00:00
JamesHR3
5e32e718ae
[CORDA-2326] Ensure right step is rendered by AnsiProgressRenderer (#4514)
* Add test to reproduce problem

* Remap step indices when the step tree changes
2019-01-11 09:53:58 +00:00
szymonsztuka
7bbe4668d6
CORDA-2388 Deprecate CommandWithParties.signingParties (#4520)
* Deprecate `CommandWithParties.signingParties` as it should not be used in contract verification code as it is non-deterministic.
* Remove the remaining usage in contract verification code - replaced by signers collection.
2019-01-11 09:41:16 +00:00
JamesHR3
79601681da
[CORDA-2385] Ensure codesets are included in documentation (#4546)
* Add headers to documentation pages using codesets that are missing the relevant includes
2019-01-11 09:22:45 +00:00
josecoll
575a68b028
Re-enable signing of finance contracts jar. (#4545) 2019-01-10 14:56:26 +00:00
szymonsztuka
9b8fda0d6d
CORDA-2375 Ensure node has unique attachment contract classname/version from signed JARs (#4535)
Corda Node ensures a given contract class and version can be sourced from only one signed and trusted Attachment (JAR).
An attempt to import a signed JAR as a trusted uploader (or promote to be trusted) with a class and version already present in the other trusted Attachment will raise DuplicateContractClassException.

Minor fixes to Hibernate Attachment Query parser (original query to select attachment without signers would always return no attachments)
2019-01-10 14:13:00 +00:00
Shams Asari
e87a8ed496
Added CorDapp metdata to confidential-identities and cleaned-up dependencies (#4540) 2019-01-10 12:31:47 +00:00
Christian Sailer
b5fc095288
Use FlowTimeOut exception rather than SQL deadlock in unit tests to avoid hitting the exponential back-off. (#4527) 2019-01-10 09:59:21 +00:00
Tudor Malene
60388a7a45
Add additional transactionality check. (#4530)
* Add additional transactionality check.

* Fix logic
2019-01-09 21:13:06 +00:00
Stefano Franz
82010fbb3e fix issue with smoketest failing due to missing confidential-identities 2019-01-09 17:25:01 +00:00
James Carlyle
8acc2f6d36
Merge pull request #4465 from corda/james-update-cn-docs
Updated introduction to Corda Network, with some content removed.
2019-01-09 16:23:33 +00:00
Nick Rogers
d97fac0eb7
Merge pull request #4529 from corda/FinalityFlowMigrationDocUpdate
Finality flow migration doc update
2019-01-09 10:58:01 -05:00
Andrius Dagys
fa025dedeb
ENT-2822: Move experimental raft and bft-smart notaries back into node, fix reference state support (#4509)
Move Raft and BFT-Smart notaries back into node to preserve backwards compatibility.

* Allow overriding full node config when using internal mock network parameters.

* Make BFT-Smart notary start up in prod mode as well

* Move raft & bftsmart notaries to net.corda.notary.experimental package

* Make sure Raft notary handles reference state edge cases correctly.

* Make sure BFT-Smart notary handles reference state edge cases correctly.

* Include notary schemas in node internal schemas

* Undo Raft notary table schema changes to maintain compatibility.
2019-01-09 15:52:42 +00:00
josecoll
4530a5e982
CORDA-2395 Add cordapp code signing dev key to production blacklist. (#4519)
* Add cordapp code signing dev key to production blacklist.

* Remove code used to generate the actual PK hash (it is now attached to the JIRA story)

* Remove wiki page reference.

* Remove the non redundant cash transfer.
2019-01-09 15:41:24 +00:00
Michele Sollecito
dd6a007ff2
[CORDA-2408]: Formatting on Flow Overriding page wrong - code not rendering correctly (fixed). (#4533) 2019-01-09 14:14:08 +00:00
rogersanick
285c93e785 Fixed grammar and spelling 2019-01-08 16:37:14 -05:00
rogersanick
a78278927f Updating FinalityFlow documentation with example code for use with SignTransactionFlow in flow responder. 2019-01-08 16:29:59 -05:00