Addressed release comments.

This commit is contained in:
Clinton Alexander 2017-09-05 17:38:53 +01:00
parent ccf231440f
commit 3ccddf91ea
3 changed files with 8 additions and 7 deletions

View File

@ -10,8 +10,8 @@ Once you have submitted a PR you are responsible for keeping it up to date until
## PR Checklist ## PR Checklist
1. Ensure any new code is tested as described [here](https://docs.corda.net/testing.html) 1. Ensure any new code is tested as described [here](https://docs.corda.net/testing.html)
1. Ensure you have done any relevant automated testing and manual testing 2. Ensure you have done any relevant automated testing and manual testing
2. Add your changes to `docs/source/changelog.rst` 3. Add your changes to `docs/source/changelog.rst`
3. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html) 4. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html)
4. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now 5. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now
and add to this Pull Request that you have read, and agreed to, the agreement. and add to this Pull Request that you have read, and agreed to, the agreement.

View File

@ -7,3 +7,4 @@ Release process
release-notes release-notes
changelog changelog
codestyle codestyle
testing

View File

@ -16,8 +16,8 @@ There are several distinct test suites each with a different purpose;
**Other**: These include tests such as performance tests, stress tests, etc, and may be in an external repo. **Other**: These include tests such as performance tests, stress tests, etc, and may be in an external repo.
These tests are mostly written with JUnit and can be run via ``gradle`` with ``gradlew test integrationTest smokeTest`` These tests are mostly written with JUnit and can be run via ``gradle``. On windows run ``gradlew test integrationTest
or any combination of these three. smokeTest`` and on unix run ``./gradlw test integrationTest smokeTest`` or any combination of these three arguments.
Before creating a pull request please make sure these pass. Before creating a pull request please make sure these pass.