Avoid leaking memory on deep promise recursions

The following pattern
```ts
async function longRunning() {
   // do something
   await setTimeout(delay);
   await longRunning();
}
```

Is regularly used for long running operations on the supervisor (e.g.
polling target state). We have
recently discovered that this pattern can slowly leak memory as it
essentially creates an infinite promise chain. Using `void longRunning()` breaks
the chain and avoids the issue.

This commit fixes all those instances where the pattern was used.

Change-type: patch

src/api-binder/index.ts

@@ -454,7 +454,7 @@ async function provisionOrRetry(retryDelay: number): Promise<void> {
 			delay: retryDelay,
 		});
 		await setTimeout(retryDelay);
-		return provisionOrRetry(retryDelay);
+		void provisionOrRetry(retryDelay);
 	}
 }
 

src/api-binder/poll.ts

@@ -174,8 +174,8 @@ const poll = async (
 	const delayedLoop = async (delayBy: number) => {
 		// Wait until we want to poll again
 		await setTimeout(delayBy);
-		// Poll again
-		await poll(false, fetchErrors);
+		// Poll again (use void to break recursion)
+		void poll(false, fetchErrors);
 	};
 
 	// Check if we want to skip first request and just loop again

src/api-binder/report.ts

@@ -267,7 +267,8 @@ export async function startReporting() {
 			// Wait until we want to report again
 			await setTimeout(delayBy);
 			// Try to report again
-			await recursivelyReport(delayBy);
+			// the void is necessary to break the recursion and avoid leaks
+			void recursivelyReport(delayBy);
 		}
 	}
 

src/device-state/index.ts

@@ -759,7 +759,6 @@ export function triggerApplyTarget({
 				scheduledApply = null;
 			}
 		});
-	return null;
 }
 
 export async function applyIntermediateTarget(

src/lib/migration.ts

@@ -88,6 +88,6 @@ export async function loadBackupFromMigration(
 		log.error(`Error restoring migration backup, retrying: ${err}`);
 
 		await setTimeout(retryDelay);
-		return loadBackupFromMigration(targetState, retryDelay);
+		void loadBackupFromMigration(targetState, retryDelay);
 	}
 }

src/logging/monitor.ts

@@ -118,7 +118,7 @@ class LogMonitor {
 			}s`,
 		);
 		await setTimeout(wait);
-		return this.start();
+		void this.start();
 	}
 
 	public isAttached(containerId: string): boolean {