mrcharles
0fa0692c37
Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.
- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
(no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
script before commit.
Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.
💘 Generated with Crush
Assisted-by: Crush:glm-5.2
49 lines
1.3 KiB
Bash
49 lines
1.3 KiB
Bash
#!/usr/bin/bash
|
|
# shellcheck disable=SC2034 # sourced config file; variables are consumed by scripts that source this
|
|
# k8s/env.sh — shared config for all k8s scripts. Source this.
|
|
#
|
|
# All cluster communication goes over Tailscale IPs. No LAN IPs, ever.
|
|
|
|
# --- Nodes (Tailscale 100.x addresses) ---
|
|
CNODE1_NAME="pfv-k8s-cnode1"
|
|
CNODE1_IP="100.97.178.106"
|
|
|
|
CNODE2_NAME="pfv-k8s-cnode2"
|
|
CNODE2_IP="100.109.34.72"
|
|
|
|
CNODE3_NAME="pfv-k8s-cnode3"
|
|
CNODE3_IP="100.106.222.18"
|
|
|
|
ALL_CNODES=("$CNODE1_IP" "$CNODE2_IP" "$CNODE3_IP")
|
|
ALL_CNODE_NAMES=("$CNODE1_NAME" "$CNODE2_NAME" "$CNODE3_NAME")
|
|
|
|
# Bootstrap node (first etcd member)
|
|
BOOTSTRAP_IP="$CNODE1_IP"
|
|
BOOTSTRAP_NAME="$CNODE1_NAME"
|
|
|
|
# --- SSH ---
|
|
SSH_USER="localuser"
|
|
SSH_OPTS=(-o BatchMode=yes -o StrictHostKeyChecking=accept-new -o ConnectTimeout=15)
|
|
|
|
# --- k3s ---
|
|
K3S_VERSION="v1.36.2+k3s1"
|
|
K3S_API_PORT="6443"
|
|
|
|
# Shared TLS SANs (all cnodes + hostnames so certs are valid cluster-wide)
|
|
TLS_SANS=(
|
|
"$CNODE1_IP" "$CNODE2_IP" "$CNODE3_IP"
|
|
"$CNODE1_NAME" "$CNODE2_NAME" "$CNODE3_NAME"
|
|
)
|
|
|
|
# Helper: run a command on a node as root (via passwordless sudo)
|
|
cn() {
|
|
local ip="$1"; shift
|
|
ssh "${SSH_OPTS[@]}" "${SSH_USER}@${ip}" "sudo -n bash -c '$*'" 2>&1
|
|
}
|
|
|
|
# Helper: run a heredoc script on a node
|
|
cn_file() {
|
|
local ip="$1"
|
|
ssh "${SSH_OPTS[@]}" "${SSH_USER}@${ip}" "sudo -n bash -s"
|
|
}
|