mrcharles
0fa0692c37
Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.
- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
(no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
script before commit.
Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.
💘 Generated with Crush
Assisted-by: Crush:glm-5.2
44 lines
1.6 KiB
Bash
Executable File
44 lines
1.6 KiB
Bash
Executable File
#!/usr/bin/bash
|
|
#
|
|
# sync-zones.sh — rsync-based zone replication from primary to secondary
|
|
#
|
|
# Runs on the SECONDARY (netinfra-02). Syncs the zones/ directory from the
|
|
# primary (netinfra-01) every 60 seconds. When a zone file changes, Technitium
|
|
# detects the modification and reloads automatically.
|
|
#
|
|
# This is used instead of AXFR-based zone transfer because Technitium's zone
|
|
# transfer mechanism uses port 53 (standard DNS), but on the netinfra hosts
|
|
# port 53 is Pi-hole and Technitium is on port 5300. rsync-based replication
|
|
# avoids the port conflict entirely.
|
|
#
|
|
# Install as a systemd service/timer or run via cron:
|
|
# * * * * * /home/localuser/services/technitium/sync-zones.sh
|
|
#
|
|
set -uo pipefail
|
|
|
|
PRIMARY_HOST="${PRIMARY_HOST:-pfv-netinfra-01.knel.net}"
|
|
CONFIG_DIR="${CONFIG_DIR:-/home/localuser/services/technitium/config}"
|
|
ZONE_DIR="$CONFIG_DIR/zones"
|
|
LOCK_FILE="/tmp/technitium-zone-sync.lock"
|
|
LOG_FILE="${LOG_FILE:-/home/localuser/services/technitium/sync.log}"
|
|
|
|
log() { printf '[%s] %s\n' "$(date +%H:%M:%S)" "$*" >> "$LOG_FILE"; }
|
|
|
|
# Prevent overlapping runs
|
|
exec 9>"$LOCK_FILE" || exit 0
|
|
flock -n 9 || { log "another sync is running; skipping"; exit 0; }
|
|
|
|
mkdir -p "$ZONE_DIR"
|
|
|
|
# rsync zones from primary. Use --temp-dir to avoid partial writes being
|
|
# picked up by Technitium, and --delete to remove zones deleted on primary.
|
|
log "Syncing zones from $PRIMARY_HOST..."
|
|
if rsync -az --delete --temp-dir=/tmp \
|
|
"${PRIMARY_HOST}:$ZONE_DIR/" "$ZONE_DIR/" >> "$LOG_FILE" 2>&1; then
|
|
zone_count=$(find "$ZONE_DIR" -maxdepth 1 -type f | wc -l)
|
|
log "Sync complete: $zone_count zones"
|
|
else
|
|
log "ERROR: rsync failed (rc=$?)"
|
|
exit 1
|
|
fi
|