mrcharles
0fa0692c37
Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.
- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
(no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
script before commit.
Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.
💘 Generated with Crush
Assisted-by: Crush:glm-5.2
57 lines
1.9 KiB
Bash
57 lines
1.9 KiB
Bash
#!/usr/bin/env bash
|
|
# Probe conman state + expect availability on pfv-tsys4.
|
|
# Read-only. Decides whether we drive via conman+expect or expect-only.
|
|
set -u
|
|
|
|
# De-conflict: any ssh to pfv-tsys4 right now?
|
|
echo "===== LOCAL ssh activity ====="
|
|
# shellcheck disable=SC2009 # intentional: need full ps columns filtered by process args
|
|
ps -eo pid,etime,args | grep -E 'ssh.*pfv-tsys' | grep -v grep || echo "(none to pfv-tsys4)"
|
|
|
|
echo
|
|
echo "===== pfv-tsys4: conman + expect state ====="
|
|
ssh -o BatchMode=yes -o ConnectTimeout=5 root@pfv-tsys4 'bash -s' <<'REMOTE'
|
|
echo "--- conmand service ---"
|
|
systemctl is-active conmand 2>&1 || true
|
|
systemctl is-enabled conmand 2>&1 || true
|
|
systemctl status conmand --no-pager 2>&1 | head -15 || true
|
|
|
|
echo
|
|
echo "--- conman binary ---"
|
|
command -v conman && conman --version 2>&1 | head -2 || echo "conman: MISSING"
|
|
command -v conmand && echo "conmand present" || echo "conmand: MISSING"
|
|
|
|
echo
|
|
echo "--- /etc/conman.conf: ttyUSB2 entries ---"
|
|
grep -nE "ttyUSB2|core-sw|CONSOLE|LOG|SERIAL|BAUD" /etc/conman.conf 2>/dev/null | head -40 || echo "(no matches / no file)"
|
|
|
|
echo
|
|
echo "--- conman log dir ---"
|
|
ls -la /var/log/conman/ 2>&1 | head -20 || echo "(no /var/log/conman)"
|
|
ls -la /var/consoles/ 2>&1 | head -20 || echo "(no /var/consoles)"
|
|
|
|
echo
|
|
echo "--- expect availability ---"
|
|
command -v expect && expect -v 2>&1 || echo "expect: NOT installed"
|
|
echo "apt-cache policy expect:"
|
|
apt-cache policy expect 2>/dev/null | head -10 || echo "(apt-cache failed)"
|
|
|
|
echo
|
|
echo "--- other useful drivers ---"
|
|
for t in tclsh socat cu tip; do
|
|
command -v "$t" 2>/dev/null && echo " $t: present" || true
|
|
done
|
|
|
|
echo
|
|
echo "--- apt network reachability (quick) ---"
|
|
timeout 5 bash -c 'echo > /dev/tcp/deb.debian.org/80' 2>&1 && echo "apt network: OK" || echo "apt network: UNREACHABLE"
|
|
|
|
echo
|
|
echo "--- disk space for log ---"
|
|
df -h /root 2>&1 | tail -2
|
|
|
|
echo
|
|
echo "--- screen sessions (still 3?) ---"
|
|
screen -ls 2>&1 || true
|
|
REMOTE
|