mrcharles
0fa0692c37
Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.
- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
(no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
script before commit.
Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.
💘 Generated with Crush
Assisted-by: Crush:glm-5.2
104 lines
4.0 KiB
Bash
104 lines
4.0 KiB
Bash
#!/usr/bin/bash
|
|
# shellcheck disable=SC2010,SC2012 # diagnostic script; ls|grep/ls -la on sysfs & log dirs is intentional for human-readable output
|
|
#
|
|
# console/discover.sh — READ-ONLY discovery of console setup on pfv-tsys4
|
|
#
|
|
# Usage: PROX_HOST=pfv-tsys4 bash tests/remote.sh prox-file console/discover.sh
|
|
#
|
|
# This script is strictly read-only. No writes to the system.
|
|
#
|
|
set -uo pipefail
|
|
|
|
echo "============================================"
|
|
echo " Console Setup Discovery"
|
|
echo " Host: $(hostname)"
|
|
echo " Date: $(date)"
|
|
echo " READ-ONLY"
|
|
echo "============================================"
|
|
|
|
echo ""
|
|
echo "=== 1. USB devices ==="
|
|
lsusb 2>/dev/null || echo "(lsusb not available)"
|
|
|
|
echo ""
|
|
echo "=== 2. All ttyUSB* devices (with major/minor) ==="
|
|
ls -la /dev/ttyUSB* 2>/dev/null || echo "(no /dev/ttyUSB* devices)"
|
|
|
|
echo ""
|
|
echo "=== 3. USB-serial driver bindings ==="
|
|
echo "-- pl2303 --"
|
|
ls -la /sys/bus/usb-serial/drivers/pl2303/ 2>/dev/null | grep -v '^total\|^d\|module\|new_id\|uevent' || echo "(none)"
|
|
echo "-- cp210x --"
|
|
ls -la /sys/bus/usb-serial/drivers/cp210x/ 2>/dev/null | grep -v '^total\|^d\|module\|new_id\|uevent' || echo "(none)"
|
|
echo "-- ftdi_sio --"
|
|
ls -la /sys/bus/usb-serial/drivers/ftdi_sio/ 2>/dev/null | grep -v '^total\|^d\|module\|new_id\|uevent' || echo "(none)"
|
|
echo "-- ch341 --"
|
|
ls -la /sys/bus/usb-serial/drivers/ch341/ 2>/dev/null | grep -v '^total\|^d\|module\|new_id\|uevent' || echo "(none)"
|
|
|
|
echo ""
|
|
echo "=== 4. USB serial adapter details (vendor/model/serial per port) ==="
|
|
for tty in /dev/ttyUSB*; do
|
|
[ -e "$tty" ] || continue
|
|
echo "--- $tty ---"
|
|
udevadm info -q all -n "$tty" 2>/dev/null | grep -E 'ID_VENDOR_ID|ID_MODEL_ID|ID_SERIAL|ID_USB_DRIVER|ID_PATH=' | sed 's/^/ /'
|
|
done
|
|
|
|
echo ""
|
|
echo "=== 5. Existing /root/conmap ==="
|
|
if [ -f /root/conmap ]; then
|
|
cat /root/conmap
|
|
else
|
|
echo "(no /root/conmap)"
|
|
fi
|
|
ls -la /root/conmap* 2>/dev/null
|
|
|
|
echo ""
|
|
echo "=== 6. Screen sessions (running) ==="
|
|
screen -ls 2>&1 || echo "(screen not running or not installed)"
|
|
|
|
echo ""
|
|
echo "=== 7. Existing screen wrappers/scripts in /root ==="
|
|
ls -la /root/ 2>/dev/null | grep -iE 'screen|con|console|tty|usb' || echo "(no obvious console scripts in /root)"
|
|
|
|
echo ""
|
|
echo "=== 8. ser2net ==="
|
|
which ser2net 2>/dev/null || echo "(ser2net not installed)"
|
|
dpkg -l ser2net 2>/dev/null | tail -2 || echo "(ser2net not in dpkg)"
|
|
cat /etc/ser2net/ser2net.yaml 2>/dev/null || cat /etc/ser2net.conf 2>/dev/null || cat /etc/ser2net/ser2net.conf 2>/dev/null || echo "(no ser2net config)"
|
|
systemctl is-active ser2net 2>/dev/null || echo "(ser2net service not found)"
|
|
|
|
echo ""
|
|
echo "=== 9. conman ==="
|
|
which conman 2>/dev/null || echo "(conman not installed)"
|
|
which conmand 2>/dev/null || echo "(conmand not installed)"
|
|
dpkg -l conman 2>/dev/null | tail -2 || echo "(conman not in dpkg)"
|
|
echo "--- /etc/conman.conf (console lines only) ---"
|
|
grep -nE 'CONSOLE|SERVER|LOG|SERIAL|DEV|BAUD|^[^#].*name=' /etc/conman.conf 2>/dev/null | head -60 || echo "(no conman.conf or no console entries)"
|
|
echo "--- conmand service ---"
|
|
systemctl is-active conmand 2>/dev/null || echo "(conmand not running)"
|
|
systemctl is-enabled conmand 2>/dev/null || echo "(conmand not enabled)"
|
|
|
|
echo ""
|
|
echo "=== 10. Existing console logs ==="
|
|
ls -la /var/log/conman/ 2>/dev/null | head -20 || echo "(no /var/log/conman)"
|
|
ls -la /var/consoles/ 2>/dev/null | head -20 || echo "(no /var/consoles)"
|
|
|
|
echo ""
|
|
echo "=== 11. udev rules for ttyUSB ==="
|
|
grep -r ttyUSB /etc/udev/rules.d/ 2>/dev/null || echo "(no udev rules for ttyUSB)"
|
|
grep -r 'console' /etc/udev/rules.d/ 2>/dev/null | head -10 || true
|
|
|
|
echo ""
|
|
echo "=== 12. expect availability ==="
|
|
command -v expect && expect -v 2>&1 || echo "expect: NOT installed"
|
|
command -v socat && socat -V 2>&1 | head -1 || echo "socat: NOT installed"
|
|
|
|
echo ""
|
|
echo "=== 13. Ports in use (2001-2099, 7000-7999, 7820-7899) ==="
|
|
ss -tlnp 2>/dev/null | grep -E ':200[0-9]|:700[0-9]|:782[0-9]|:789[0-9]' || echo "(no relevant ports listening)"
|
|
|
|
echo ""
|
|
echo "============================================"
|
|
echo " Discovery complete (read-only)."
|
|
echo "============================================"
|