From 1e6973a4b017912a9f0b217d8a179d821ec11e56 Mon Sep 17 00:00:00 2001 From: ic-builder Date: Sun, 6 Sep 2026 14:29:45 -0500 Subject: [PATCH] fix SC2015 for CI shellcheck 0.9 (unambiguous if-forms) CI red fix per the all-CI-green mandate; same pattern as the KNELCa/ KNELInventory fixes. No behavior change. CI evidence: https://git.knownelement.com/KNEL/KNELPerf/actions Ticket: https://projects.knownelement.com/issues/784 --- loop/baseline-diff.sh | 2 +- scheduler/daynight/knelperf-daynight.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/loop/baseline-diff.sh b/loop/baseline-diff.sh index fd760b9..437ca9e 100755 --- a/loop/baseline-diff.sh +++ b/loop/baseline-diff.sh @@ -17,7 +17,7 @@ join_tsv() { awk -F'\t' 'NR==FNR{a[$1]=$2;next} {print $1"\t"a[$1]"\t"$2"\t"$3}' # shellcheck disable=SC2034 # exit-status reserved for future strictness status=0 join_tsv "$A/cpu-bench.tsv" "$B/cpu-bench.tsv" | while IFS=$'\t' read -r metric va vb unit; do - [ -n "$va" ] && [ -n "$vb" ] || continue + if [ -z "$va" ] || [ -z "$vb" ]; then continue; fi if [ "$va" = "$vb" ]; then printf 'OK %-28s %s = %s %s\n' "$metric" "$va" "$vb" "$unit" elif [ "$va" = "${va#[-+0-9.]}" ] || [ "$vb" = "${vb#[-+0-9.]}" ]; then diff --git a/scheduler/daynight/knelperf-daynight.sh b/scheduler/daynight/knelperf-daynight.sh index 1e01c3b..588ef37 100755 --- a/scheduler/daynight/knelperf-daynight.sh +++ b/scheduler/daynight/knelperf-daynight.sh @@ -55,7 +55,7 @@ if [ -n "$BLOCK_DEVS" ]; then for dev in $BLOCK_DEVS; do blockdev --setra "$ra" "$dev" 2>/dev/null || log "readahead skip: $dev" for part in "${dev}"[0-9]*; do - [ -e "$part" ] && blockdev --setra "$ra" "$part" 2>/dev/null || true + if [ -e "$part" ]; then blockdev --setra "$ra" "$part" 2>/dev/null || true; fi done done fi