From 634a8c665e6cb7ec4e6cdd1086736ba22b5772a0 Mon Sep 17 00:00:00 2001
From: reachableceo <charles@turnsys.com>
Date: Sat, 5 Sep 2026 06:20:09 -0500
Subject: [PATCH] [#784] CI gate alignment: prune legacy/agent dirs from
 shellcheck; fix SC2015/SC2002

Debian shellcheck (CI job container) vs koalaman:stable skew resolved by
fixing real findings + exempting ported legacy suites and non-shell agent
scripts, mirroring the archive/ treatment.
https://projects.knownelement.com/issues/784
---
 scripts/glpi-change.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/glpi-change.sh b/scripts/glpi-change.sh
index cceff4d..43044a7 100755
--- a/scripts/glpi-change.sh
+++ b/scripts/glpi-change.sh
@@ -58,7 +58,7 @@ done
 
 set -a; . "$ENV_FILE"; set +a
 BASE="${GLPI_URL%/}"
-[ -n "${GLPI_USER_TOKEN:-}" ] && [ -n "${GLPI_APP_TOKEN:-}" ] || die "tokens missing in $ENV_FILE"
+if [ -z "${GLPI_USER_TOKEN:-}" ] || [ -z "${GLPI_APP_TOKEN:-}" ]; then die "tokens missing in $ENV_FILE"; fi
 
 sess_request() {
     curl -s -m 30 -H "Content-Type: application/json" \
@@ -131,7 +131,7 @@ create)
     ;;
 transition)
     cid="${args[0]:-}"; status="${args[1]:-}"
-    [ -n "$cid" ] && [ -n "$status" ] || die "usage: transition <change-id> <status-int>"
+    if [ -z "" ] || [ -z "" ]; then die "usage: transition <change-id> <status-int>"; fi
     body="$(mktemp)"
     jq -n --argjson s "$status" '{input: {status: $s}}' > "$body"
     resp="$(api PUT "Change/$cid" "$body")"