Adversarial review verdict FAIL -> addressed: runtime-low + shutdown
chain re-poll /5 min (edge-crossing could miss a page mid-outage);
suppression stamp set after notify; plan body names all 7 hosts
explicitly; test fixes (pipefail SIGPIPE, comment-only assertion).
Reviewer P1 'tripp_lite slug' refuted with live entity registry
evidence (entity_id derives from name; sensor exists, 8f48730 aligned).
On-box ha core check passed with the changed files.
Review thread: #3
This commit is contained in:
+16
-3
@@ -63,17 +63,30 @@ t "trend sensors fed from smoothed sources" \
|
||||
t "runtime-low covers Tripp Lite" \
|
||||
"sed -n '/id: pfv_plant_ups_runtime_low/,/^ mode:/p' automations.yaml | grep -q 'sensor.pfv_tripp_lite_runtime_minutes'"
|
||||
t "runtime-low status check maps per-UPS" \
|
||||
"sed -n '/id: pfv_plant_ups_runtime_low/,/^ mode:/p' automations.yaml | grep -q 'status_map'"
|
||||
"sed -n '/id: pfv_plant_ups_runtime_low/,/^ mode:/p' automations.yaml | grep -q \"sensor.pfv_tripp_lite_runtime_minutes', 'sensor.tsys1_triplite_status'\""
|
||||
|
||||
echo "=== UPS shutdown chain (#790 — dry-run is the shipped mode) ==="
|
||||
t "shutdown chain package present, dry-run default ON" \
|
||||
"grep -q 'id: pfv_ups_shutdown_plan' packages/ups_shutdown.yaml && grep -A4 'pfv_ups_shutdown_dry_run:' packages/ups_shutdown.yaml | grep -q 'initial: true'"
|
||||
t "armed switch default OFF" \
|
||||
"grep -A4 'pfv_ups_shutdown_armed:' packages/ups_shutdown.yaml | grep -q 'initial: false'"
|
||||
t "plan covers all seven hypervisors" \
|
||||
"for h in tsys1 tsys3 tsys4 tsys5 tsys6 tsys7 tsys9; do grep -q \$h packages/ups_shutdown.yaml || exit 1; done"
|
||||
# Host coverage must hold in the PLAN BODY, not the header comment —
|
||||
# scope the grep to the plan template variable.
|
||||
PLAN_OK=1
|
||||
for h in tsys1 tsys3 tsys4 tsys5 tsys6 tsys7 tsys9; do
|
||||
# full-read grep (not -q): the script runs with pipefail — -q's early
|
||||
# exit SIGPIPEs sed and flips the pipeline status to 141
|
||||
sed -n '/plan: >-/,/mode_note:/p' packages/ups_shutdown.yaml | grep "$h" >/dev/null || PLAN_OK=0
|
||||
done
|
||||
t "plan covers all seven hypervisors (plan body)" "[ \$PLAN_OK -eq 1 ]"
|
||||
t "pfv-bms VM 100 ordered last of the VMs (#455)" \
|
||||
"grep -q 'pfv-bms VM 100 LAST' packages/ups_shutdown.yaml"
|
||||
|
||||
echo "=== level-based re-checks (review finding: edge-only triggers miss pages) ==="
|
||||
t "runtime-low re-polls every 5 min" \
|
||||
"sed -n '/id: pfv_plant_ups_runtime_low/,/^ mode:/p' automations.yaml | grep -q 'minutes: /5'"
|
||||
t "shutdown chain re-polls every 5 min" \
|
||||
"grep -A30 'id: pfv_ups_shutdown_plan' packages/ups_shutdown.yaml | grep -q 'minutes: /5'"
|
||||
|
||||
echo "=== SDLC SUITE: $FAIL failures ==="
|
||||
exit "$FAIL"
|
||||
|
||||
Reference in New Issue
Block a user