ExternalVendorCode/whisper.cpp
1
0
Fork 0
mirror of https://github.com/ggerganov/whisper.cpp.git synced 2024-12-19 20:57:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vulkan: fix group_norm (llama/10496)

Browse Source 
Fix bad calculation of the end of the range. Add a backend test that
covers the bad case (taken from stable diffusion).

Fixes https://github.com/leejet/stable-diffusion.cpp/issues/439.
This commit is contained in:
Jeff Bolz 2024-11-26 09:45:05 -06:00 committed by Georgi Gerganov
parent 48f421de23
commit 5e1fcc1780
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ggml/src/ggml-vulkan/ggml-vulkan.cpp
View File

@ -7157,7 +7157,7 @@ static void ggml_vk_check_results_0(ggml_tensor * tensor) {
const int32_t max_period = tensor->op_params[1]; const int32_t max_period = tensor->op_params[1];
tensor_clone = ggml_timestep_embedding(ggml_ctx, src0_clone, dim, max_period); tensor_clone = ggml_timestep_embedding(ggml_ctx, src0_clone, dim, max_period);
} else if (tensor->op == GGML_OP_POOL_2D) { } else if (tensor->op == GGML_OP_POOL_2D) {
enum ggml_op_pool op = static_cast<ggml_op_pool>(dst->op_params[0]); enum ggml_op_pool op = static_cast<ggml_op_pool>(tensor->op_params[0]);
const int32_t k0 = tensor->op_params[1]; const int32_t k0 = tensor->op_params[1];
const int32_t k1 = tensor->op_params[2]; const int32_t k1 = tensor->op_params[2];
const int32_t s0 = tensor->op_params[3]; const int32_t s0 = tensor->op_params[3];

2
ggml/src/ggml-vulkan/vulkan-shaders/group_norm.comp
View File

@ -19,7 +19,7 @@ void main() {
const uint tid = gl_LocalInvocationID.x; const uint tid = gl_LocalInvocationID.x;
const uint start = gl_WorkGroupID.x * group_size + tid; const uint start = gl_WorkGroupID.x * group_size + tid;
const uint end = start + group_size; const uint end = (gl_WorkGroupID.x + 1) * group_size;
tmp[tid] = 0.0f; tmp[tid] = 0.0f;