From ee5edba1468486da9dae1dbb4ebd6ba8c208459d Mon Sep 17 00:00:00 2001 From: Hong Chen Date: Tue, 14 Jan 2025 11:36:44 -0600 Subject: [PATCH] 1821 action required GitHub actions v4 update for actions@checkout (#1824) * Updated to Github actions v4 as Github actions v3 will be closing down by 1/30/25. * Updated to use actions/checkout action at the v4 branch as well to be consistent with artifacts. It is recommended to use a sepcific version or tag instead of master to ensure stability and predictability. * Made the artifact name unique within the workflow run. --- .github/workflows/alt_linux_distros.yml | 2 +- .github/workflows/code_coverage.yml | 2 +- .github/workflows/python_tests_linux.yml | 2 +- .github/workflows/python_tests_macos.yml | 2 +- .github/workflows/report_alt_linux_distros.yml | 2 +- .github/workflows/report_linux.yml | 2 +- .github/workflows/report_macos.yml | 2 +- .github/workflows/test_32_oracle.yml | 2 +- .github/workflows/test_linux.yml | 2 +- .github/workflows/test_linux_py2.yml | 4 ++-- .github/workflows/test_macos.yml | 2 +- .github/workflows/trickops.yml | 6 +++--- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/alt_linux_distros.yml b/.github/workflows/alt_linux_distros.yml index 5583b235..69223250 100644 --- a/.github/workflows/alt_linux_distros.yml +++ b/.github/workflows/alt_linux_distros.yml @@ -141,7 +141,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` diff --git a/.github/workflows/code_coverage.yml b/.github/workflows/code_coverage.yml index 32abf3e3..9db3e406 100644 --- a/.github/workflows/code_coverage.yml +++ b/.github/workflows/code_coverage.yml @@ -32,7 +32,7 @@ jobs: dnf install -y gtest-devel gmock-devel - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Configure Trick run: | diff --git a/.github/workflows/python_tests_linux.yml b/.github/workflows/python_tests_linux.yml index 63b47575..803f9079 100644 --- a/.github/workflows/python_tests_linux.yml +++ b/.github/workflows/python_tests_linux.yml @@ -140,7 +140,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Info after checkout run: | pwd diff --git a/.github/workflows/python_tests_macos.yml b/.github/workflows/python_tests_macos.yml index b0027d27..10e7b8dc 100644 --- a/.github/workflows/python_tests_macos.yml +++ b/.github/workflows/python_tests_macos.yml @@ -19,7 +19,7 @@ jobs: runs-on: macos-latest steps: - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Install python run: | brew install python diff --git a/.github/workflows/report_alt_linux_distros.yml b/.github/workflows/report_alt_linux_distros.yml index 7ca302cc..57b78225 100644 --- a/.github/workflows/report_alt_linux_distros.yml +++ b/.github/workflows/report_alt_linux_distros.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_linux.yml b/.github/workflows/report_linux.yml index 907dc2b4..bd94b4f6 100644 --- a/.github/workflows/report_linux.yml +++ b/.github/workflows/report_linux.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # artifact name name: Results_Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} # Name of the check run which will be created diff --git a/.github/workflows/report_macos.yml b/.github/workflows/report_macos.yml index 03b706c1..1d1e4fbd 100644 --- a/.github/workflows/report_macos.yml +++ b/.github/workflows/report_macos.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: dorny/test-reporter@v1 + - uses: dorny/test-reporter@v4 with: artifact: Trick_macos # artifact name name: Results_Trick_macos # Name of the check run which will be created diff --git a/.github/workflows/test_32_oracle.yml b/.github/workflows/test_32_oracle.yml index c0850e09..b9d23d16 100644 --- a/.github/workflows/test_32_oracle.yml +++ b/.github/workflows/test_32_oracle.yml @@ -56,7 +56,7 @@ jobs: make make install - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build Trick run: | export CFLAGS="-m32" diff --git a/.github/workflows/test_linux.yml b/.github/workflows/test_linux.yml index eb07ed2e..1c58ce6e 100644 --- a/.github/workflows/test_linux.yml +++ b/.github/workflows/test_linux.yml @@ -129,7 +129,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` diff --git a/.github/workflows/test_linux_py2.yml b/.github/workflows/test_linux_py2.yml index ce2ef9bb..6796a0db 100644 --- a/.github/workflows/test_linux_py2.yml +++ b/.github/workflows/test_linux_py2.yml @@ -129,7 +129,7 @@ jobs: - name: Install GTest run: ${{matrix.install_gtest}} - name: Checkout repository - uses: actions/checkout@master + uses: actions/checkout@v4 - name: Configure Trick run: | export MAKEFLAGS=-j`nproc` @@ -145,7 +145,7 @@ jobs: python3 -m venv .venv && . .venv/bin/activate && pip3 install -r requirements.txt cd ../../../; make test - name: Upload Tests - uses: actions/upload-artifact@v3.0.0 + uses: actions/upload-artifact@v4 if: success() || failure() # run this step even if previous step failed with: name: Trick_${{matrix.cfg.os}}${{matrix.cfg.tag}}_py${{matrix.python}} diff --git a/.github/workflows/test_macos.yml b/.github/workflows/test_macos.yml index 1a365f79..5d4fe860 100644 --- a/.github/workflows/test_macos.yml +++ b/.github/workflows/test_macos.yml @@ -16,7 +16,7 @@ jobs: runs-on: macos-13 steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Install gtest run: | brew install googletest diff --git a/.github/workflows/trickops.yml b/.github/workflows/trickops.yml index ff6878c2..71c65363 100644 --- a/.github/workflows/trickops.yml +++ b/.github/workflows/trickops.yml @@ -31,10 +31,10 @@ jobs: source ../.venv/bin/activate export PATH="/tmp/koviz-master/bin:${PATH}" ./run_tests.py - - uses: actions/upload-artifact@v3.0.0 + - uses: actions/upload-artifact@v4 if: ${{ always() }} with: - name: doctests + name: doctests_${{ github.run_id }}_${{ github.job }} path: | share/trick/trickops/tests/*_doctest_log.txt /tmp/log.* @@ -66,7 +66,7 @@ jobs: - uses: actions/upload-artifact@v4 if: ${{ always() }} with: - name: doctests + name: doctests_${{ github.run_id }}_${{ github.job }} path: | share/trick/trickops/tests/*_doctest_log.txt /tmp/log.*