Integrate MonteCarloGenerate capability from EG CML and associated TrickOps enhancements (#1415)
* Provide MonteCarloGenerate capability
Intermediate commit, this squash represents all of Isaac Reaves' work
during his Fall 2022 Pathways internship tour
[skip ci]
* TrickOps: Add phase, [min-max] range, and overhaul YAML verification
* Add new "phase:" mechanism to TrickOps Runs and Builds to support
project-specific constraints on build and run ordering
- phase defaults to zero if not specified and must be between -1000
and 1000 if given.
- jobs can now optionally be requested by their phase or phase range
- See trickops/README.md for details
* Add [min-max] notation capability to run: entries and compare: entries
- [min-max] ranges provide definition of a set of runs using a common
numbering scheme in the YAML file, greatly reducing YAML file size
for monte-carlo and other zero-padded run numbering use cases
- See trickops/README.md for details
* YAML parsing changes
- Overhaul the logic which verifies YAML files for the expected
TrickOps format. This is now done in TrickWorkflowYamlVerifier and
provides much more robust error checking than previous approach
- .yaml_requirements.yml now provides the required types, ranges, and
default values as applicable to expected entries in YAML files
- valgrind: is now an sub-option to run: entries, not its own section
Users should now list their runs normallly and define their flags in
in that run's valgrind: subsection
- parallel_safety is now a per-sim parameter and not global. Users
should move their global config to the sim layer
- self.config_errors is now a list of errors. Users should now
check for empty list when using instead of True/False
* Robustify the get_koviz_report_jobs unit test to work whether koviz
exists on PATH or not
* Adjust trickops.py to use the new phase and range features
- Make it more configurable on the command-line via argparse
- Move SIM_mc_generation tests into test_sims.yml
[skip ci]
* Code review and cleanup from PR #1389
Documentation:
* Adjust documentation to fit suggested symlinked approach. Also
cleaned up duplicate images and old documentation.
* Moved the verification section out of markdown and into a PDF since it
heavily leverages formatting not available in markdown.
* Clarify a couple points on the Darwin Trick install guide
* Update wiki to clarify that data recording strings is not supported
MCG Code:
* Replace MonteCarloVariableRandomNormal::is_near_equal with new
Trick::dbl_is_near from trick team
MCG Testing:
* Reduce the set of SIM_mc_generation comparisons. After discussion
the trick team, we are choosing to remove all comparisons to
verif_data/ which contain random-generated numbers since
these tests cannot pass across all supported trick platforms.
* Fix the wrong rule on exlcuding -Werror for Darwin builds
of SIM_mc_generation
* Remove data recording of strings in SIM_mc_generation
Trickops:
* Replace build_command with build_args per discussion w/ Trick team
Since we only support arguments to trick-CP, replace the build_command
yaml entry with build_args
* Disable var server connection by default in SingleRun if TrickWorkflow.quiet
is True
* Guard against multiple Job starts
* Remove SimulationJob inheritance layer since old monte-carlo wasn't
and never will be supported by TrickOps
* Ignore IOError raise from variable_server that looks like "The remote
endpoint has closed the connection". This appears to occur when
SingleRun jobs attempt to connect to the var server for a sim that
terminates very early
[skip ci]
* Adjust phasing of old/new MCG initialize functions
* Clarify failure message in generate_dispersions if new/old MC are both
used.
* Adjust the phasing order of MCG intialize method to be before
legacy MC initialized. Without this, monte-carlo dry run completes with
success before the check in generate_dispersions() can run
* Add -Wno-stringop-truncation to S_override.mk for SIM_mc_generation
since gcc 8+ warns about SWIG generated content in top.cpp
* Introduce MonteCarloGenerationHelper python class
This new class provides an easy-to-use interface for MCG sim-module
users:
1. Run generation
2. Getting an sbatch array job suitable for SLURM
3. Getting a list of SingleRun() instances for generated runs, to be
executed locally if desired
---------
Co-authored-by: Dan Jordan <daniel.d.jordan@nasa.gov>
2023-03-06 09:25:50 -06:00
|
|
|
/*******************************TRICK HEADER******************************
|
|
|
|
PURPOSE: ( Base class for the MonteCarloVariable type)
|
|
|
|
|
|
|
|
PROGRAMMERS:
|
|
|
|
(((Gary Turner) (OSR) (October 2019) (Antares) (Initial)))
|
|
|
|
(((Isaac Reaves) (NASA) (November 2022) (Integration into Trick Core)))
|
|
|
|
**********************************************************************/
|
|
|
|
|
|
|
|
#include "trick/mc_variable.hh"
|
|
|
|
#include "trick/message_proto.h"
|
|
|
|
#include "trick/message_type.h"
|
|
|
|
#include "trick/exec_proto.h"
|
|
|
|
#include <sstream> // ostringstream
|
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
Constructor
|
|
|
|
*****************************************************************************/
|
|
|
|
MonteCarloVariable::MonteCarloVariable(
|
|
|
|
const std::string & var_name)
|
|
|
|
:
|
|
|
|
units(),
|
|
|
|
include_in_summary(true),
|
|
|
|
variable_name(var_name),
|
|
|
|
assignment(),
|
|
|
|
command(),
|
|
|
|
type(Undefined)
|
|
|
|
{}
|
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
insert_units
|
|
|
|
Purpose:(Provides a unit-conversion insertion into an established command)
|
|
|
|
*****************************************************************************/
|
|
|
|
void
|
|
|
|
MonteCarloVariable::insert_units()
|
|
|
|
{
|
|
|
|
// If no units specified, nothing to do here.
|
|
|
|
if (units.empty()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Unreachable code in current implementation. insert_units is only ever
|
|
|
|
// called immediately after generate_command, which cannot possibly generate
|
|
|
|
// an empty string.
|
|
|
|
if (command.empty()) {
|
|
|
|
std::string message =
|
|
|
|
std::string("File: ") + __FILE__ + ", Line: " +
|
|
|
|
std::to_string(__LINE__) + ", Sequencing error\nVariable " +
|
|
|
|
variable_name.c_str() + " has units specified (" + units.c_str() +
|
|
|
|
") but no command generated.\nThe command must be generated before " +
|
|
|
|
"applying units.Will attempt to generate the command to "
|
|
|
|
"avoid terminal fault but this\nmay not be what was intended.\n";
|
|
|
|
message_publish(MSG_ERROR, message.c_str());
|
|
|
|
}
|
|
|
|
// parse the command
|
|
|
|
size_t pos_equ = command.find("=");
|
|
|
|
if (pos_equ == std::string::npos) {
|
|
|
|
// Unreachable code in current implementation. insert_units is only ever
|
|
|
|
// called immediately after generate_command, and even if all else fails,
|
|
|
|
// generate_command produces a command with an = symbol in it, So an =
|
|
|
|
// will always be found.
|
|
|
|
std::string message =
|
|
|
|
std::string("File: ") + __FILE__ + ", Line: " +
|
|
|
|
std::to_string(__LINE__) + " Invalid command\nFor variable " +
|
|
|
|
variable_name.c_str() + ", the command is poorly formed.\nCannot " +
|
|
|
|
"apply units to this command.\n";
|
|
|
|
message_publish(MSG_ERROR, message.c_str());
|
|
|
|
exec_terminate_with_return(1, __FILE__, __LINE__, message.c_str());
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: Pick a unit-conversion mechanism
|
|
|
|
// Right now, the only one available is Trick:
|
|
|
|
trick_units( pos_equ+1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
trick_units
|
|
|
|
Purpose:(inserts the Trick unit conversion mechanism into an established
|
|
|
|
command string.)
|
|
|
|
*****************************************************************************/
|
|
|
|
void
|
|
|
|
MonteCarloVariable::trick_units(
|
|
|
|
size_t insertion_pt)
|
|
|
|
{
|
|
|
|
command.insert(insertion_pt, " trick.attach_units(\"" + units + "\",");
|
|
|
|
command.append(")");
|
|
|
|
}
|
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
generate_assignment_internal
|
|
|
|
Purpose:()
|
|
|
|
*****************************************************************************/
|
|
|
|
void
|
|
|
|
MonteCarloVariable::assign_double(
|
|
|
|
double value)
|
|
|
|
{
|
|
|
|
std::ostringstream ostring;
|
|
|
|
ostring.precision(16);
|
|
|
|
ostring << value;
|
|
|
|
assignment = ostring.str();
|
|
|
|
generate_command();
|
|
|
|
insert_units();
|
|
|
|
}
|
|
|
|
/****************************************************************************/
|
|
|
|
void
|
|
|
|
MonteCarloVariable::assign_int(
|
|
|
|
int value)
|
|
|
|
{
|
|
|
|
assignment = std::to_string(value);
|
|
|
|
generate_command();
|
|
|
|
insert_units();
|
|
|
|
}
|
|
|
|
/****************************************************************************/
|
|
|
|
void
|
|
|
|
MonteCarloVariable::generate_command()
|
|
|
|
{
|
|
|
|
command = "\n" + variable_name + " = " + assignment;
|
|
|
|
}
|
2023-12-01 10:09:17 -06:00
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
get_type_str
|
|
|
|
Purpose:(Return the type of this variable as string. Meant to be overridden
|
|
|
|
by derived classes)
|
|
|
|
*****************************************************************************/
|
|
|
|
std::string MonteCarloVariable::get_type_str() const
|
|
|
|
{
|
|
|
|
switch (get_type()) {
|
|
|
|
// Unreachable case in current implementation.
|
|
|
|
// All current variable classes have been given a "type"
|
|
|
|
default:
|
|
|
|
return(std::string("Undefined_type"));
|
|
|
|
break;
|
|
|
|
case MonteCarloVariable::Calculated:
|
|
|
|
return(std::string("Calculated"));
|
|
|
|
break;
|
|
|
|
case MonteCarloVariable::Constant:
|
|
|
|
return(std::string("Constant"));
|
|
|
|
break;
|
|
|
|
case MonteCarloVariable::Execute:
|
|
|
|
return(std::string("Execute"));
|
|
|
|
break;
|
|
|
|
case MonteCarloVariable::Prescribed:
|
|
|
|
return(std::string("Prescribed"));
|
|
|
|
break;
|
|
|
|
case MonteCarloVariable::Random:
|
|
|
|
return(std::string("Random"));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*****************************************************************************
|
|
|
|
summarize_variable
|
|
|
|
Purpose:(Provide a string summarizing the attributes of this MonteCarloVariable)
|
|
|
|
*****************************************************************************/
|
|
|
|
std::string MonteCarloVariable::summarize_variable() const
|
|
|
|
{
|
|
|
|
std::ostringstream ss;
|
|
|
|
ss << variable_name << std::string(": type=") << get_type_str();
|
|
|
|
return (ss.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
|