mirror of
https://github.com/tahoe-lafs/tahoe-lafs.git
synced 2024-12-22 22:32:23 +00:00
abae0345ad
a typo in the 'flags2mode' code would wind up passing the O_APPEND flag into the os open() call, which would cause the file to be opened in 'strict append' mode, i.e. all writes extend the file, regardless of calls to seek. this causes a problem for tahoefuse in that the seek() calls made to filehandles open through fuse would be ignored when write()s occurred. this was evidenced by corruption seen when using rsync. it turns out that rsync actually makes overlapping writes in some cases, i.e. even when writing a new fresh file out, it still doesn't write a simple contiguous span of data, but will make writes overlapping data already written. this is probably related to the way it manages data blocks internally for rolling checksums etc. at any rate, this bug would thus cause rsync in those cases to write a chunk of duplicate data into the file - leading to tahoe securely and reliably storing the wrong data. fixing this, so that non-append file opens do not pass O_APPEND seems to eliminate this problem. |
||
|---|---|---|
| .. | ||
| 10.4/fuseparts | ||
| 10.5/fuseparts | ||
| fuseparts | ||
| allmydata_tahoe.py | ||
| allmydata.icns | ||
| depends.py | ||
| fuse.py | ||
| Makefile | ||
| setup.py | ||
| tahoefuse.py | ||