Sajith Sasidharan
378b20c51a
Reject trailing empty path piece in URIs
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
d3d0d02855
Reject URIs that contain empty segments
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
83b5807ca1
Add newsfragment
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
5892eae580
Render self in DirectoryNodeHandler.getChild()
...
We need self.render_POST() etc. to be invoked when we have a request
such as "POST /uri/URI:DIR:..."; throwing an error here is probably
not the right thing to do.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
7444d6b7a9
Correct arguments to super()
...
This was incidentally found when looking at some test failures:
super(type, object) is the right invocation, and not the other way
around.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
88accc23c3
Update newsfragment
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
c043d1bead
Add newsfragment
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
4dd6c86950
Use twisted web directives in web.operations.ReloadMixin
2020-07-09 16:05:28 -04:00
Sajith Sasidharan
2e160c1526
Test for failure caused by invalid path
...
A hyphen is expected when rendering /status page child nodes:
"/status/up" is wrong; "/status/up-0" is right.
2020-07-09 14:37:37 -04:00
Sajith Sasidharan
54248f334e
Use WebError, not RuntimeError, to indicate error
...
Several problems with using RuntimeError to signal error here:
- It dumps a rather unhelpful webpage at the user.
- The exception backtrace on Tahoe console is not quite necessary here.
- It really is not a runtime error: it is just an expected failure.
- But mainly, testing for RuntimeError is harder.
2020-07-09 14:35:14 -04:00
Sajith Sasidharan
f9e864c51c
Use simpler syntax to update map
2020-06-24 08:15:18 -04:00
Sajith Sasidharan
d3f43d31d9
Remove unused import
2020-05-23 06:17:06 -04:00
Sajith Sasidharan
93d015e468
Document status.Status
2020-05-22 22:24:09 -04:00
Sajith Sasidharan
bd799d9d72
Add newsfragment
2020-05-22 22:18:58 -04:00
Sajith Sasidharan
a6e32135e8
Update status page child route handler and table renderers
...
Drop nevow-isms and use twisted.web's way of doing things.
2020-05-22 22:15:45 -04:00
Sajith Sasidharan
3357f4c5ce
Make Status a MultiFormatResource
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
81dc63b511
Use twisted template tags in status page template
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
9520ad71eb
Rearrange imports
2020-05-22 21:24:21 -04:00
Sajith Sasidharan
538503c0f8
Merge pull request #717 from sajith/3289.status-publish-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.PublishStatusPage
Fixes: ticket:3289
2020-05-14 10:09:57 -04:00
Sajith Sasidharan
78c214b7ff
Merge pull request #716 from sajith/3290.status-retrieve-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.RetrieveStatusPage
Fixes: ticket:3290
2020-05-13 19:39:23 -04:00
Sajith Sasidharan
79a44eac33
Correct docstring to ":param <type> <name>" format
2020-05-13 19:29:41 -04:00
Sajith Sasidharan
9d5d338993
Correct docstring to ":param <type> <name>" format
2020-05-13 19:04:10 -04:00
Sajith Sasidharan
d87dfaf5a0
Merge pull request #714 from sajith/3291.status-mapupdate-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.MapupdatePage
Fixes: ticket:3291
2020-05-13 18:22:16 -04:00
Sajith Sasidharan
ebe80221d5
Add missing "param:" to init method docstring
2020-05-13 17:45:08 -04:00
Sajith Sasidharan
2e0e210c14
Make PublishStatusPage comment a docstring
2020-05-13 17:43:55 -04:00
Sajith Sasidharan
5aa0dd4085
Rename a variable for readability
...
Noticed in code review: `l` can be confused with `1` for many
typefaces.
2020-05-13 17:12:08 -04:00
Sajith Sasidharan
812f03934a
Add missing "param:" to docstring
2020-05-13 17:09:53 -04:00
Sajith Sasidharan
4af2e4b4df
Drop an unbalanced quote
2020-05-13 17:08:26 -04:00
Sajith Sasidharan
62760c0997
Make RetrieveStatusPage comment a docstring
2020-05-13 17:07:09 -04:00
Sajith Sasidharan
8e17d203cf
Add missing "param:" to docstring
2020-05-13 16:59:52 -04:00
Sajith Sasidharan
c18488872c
Make comment on MapupdateStatusPage a docstring
2020-05-13 16:54:39 -04:00
Sajith Sasidharan
166be8b4dd
Merge pull request #719 from sajith/3309.github-actions-run-pyinstaller-executable
...
Run PyInstaller-generated binary in GitHub Actions
Fixes: ticket:3309
2020-05-13 16:09:04 -04:00
meejah
466369dd69
Merge pull request #669 from meejah/make-pypy-work
...
Make pypy work
2020-05-13 12:44:23 -06:00
Sajith Sasidharan
4b1ff9546c
Do not install setuptools in pyinstaller step
...
This is unnecessary, and likely was the result of copy-pasting.
2020-05-13 12:06:11 -04:00
Sajith Sasidharan
f3d37e52db
Upload PyInstaller package as a GitHub Actions artifact
2020-05-12 18:37:50 -04:00
Sajith Sasidharan
86184e9aa9
Do not install codecov in GitHub Actions packaging tests
2020-05-12 18:28:42 -04:00
Sajith Sasidharan
b1d7e99671
Try running PyInstaller-generated binary in GitHub Actions
2020-05-12 18:15:17 -04:00
meejah
a5ea767352
Merge pull request #718 from sajith/3308.remove-web-common-rendermixin
...
Remove web.common.RenderMixin
2020-05-12 11:36:35 -06:00
Sajith Sasidharan
316c02c192
Merge pull request #709 from sajith/3304.remove-trollius-from-nixos-ci
...
Remove trollius from NixOS CI
Fixes: ticket:3304
2020-05-12 07:46:42 -04:00
Sajith Sasidharan
3fad9a127c
Remove web.common.RenderMixin
...
Fixes: ticket:3308
2020-05-12 07:40:22 -04:00
Sajith Sasidharan
0ae045ea16
Add comments to PublishStatusPage
2020-05-11 12:47:48 -04:00
Sajith Sasidharan
a4bc31a137
Add newsfragment
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
9e200fc014
Render publish problems only when there are problems
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
0fba615afb
Remove RateAndTimeMixin from PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
fdf6449ba8
Use MultiFormatResource to implement PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
89c4210090
Use twisted tags in publish status template page
2020-05-11 11:43:01 -04:00
Sajith Sasidharan
65cd0e8ecd
Reformat publish status template page
2020-05-11 10:38:15 -04:00
Sajith Sasidharan
a39f6d36f4
Add newsfragment
2020-05-07 16:40:55 -04:00
Sajith Sasidharan
3aaa87d2ba
Add notes to RetrieveStatusPage
2020-05-07 13:15:05 -04:00
Sajith Sasidharan
07f14a19f8
Drop RateAndTimeMixin from RetrieveStatusElement
2020-05-07 11:37:21 -04:00