Jean-Paul Calderone
8d4d000132
Fix pre-release matching regex character class
...
Previously matched any single character from `abc|r` (with duplicate
specification of `c`). Now matches any single character from `abc` or
the two character sequence `rc`.
I guess this was the intent, anyway.
2018-04-26 15:20:27 -04:00
Jean-Paul Calderone
6b16afaa2e
Avoid using the list comprehension loop variable
...
It works fine but it relies on leaky scopes.
2018-04-26 15:16:00 -04:00
Jean-Paul Calderone
9f8c90393f
Remove dead synopsis definition
2018-04-26 15:10:02 -04:00
Jean-Paul Calderone
7609fd1861
Remove impossible third codepath
2018-04-26 15:09:01 -04:00
Jean-Paul Calderone
64243527eb
Remove the strange option to not use flog
2018-04-26 15:08:14 -04:00
Jean-Paul Calderone
6d9f0c59b7
Remove pointless conditional
2018-04-26 14:59:47 -04:00
Jean-Paul Calderone
da9d0ded94
Remove pointless conditional
2018-04-26 14:59:18 -04:00
Jean-Paul Calderone
a7218cb16f
Some nice documnetation and proper exception types
2018-04-23 18:46:12 -04:00
Jean-Paul Calderone
169ccbfbca
directory creation fixes
2018-04-23 18:46:07 -04:00
Jean-Paul Calderone
035dc6dc76
reduce fragility of tests .. maybe?
...
only trivially, at best, of course.
2018-04-23 11:41:36 -04:00
Jean-Paul Calderone
e1c469e3b6
make sure we pass the client node
2018-04-23 11:41:29 -04:00
Jean-Paul Calderone
cfa33332a5
Add missing information/import
2018-04-23 11:09:24 -04:00
Jean-Paul Calderone
8d104dab1c
Move the complicated MagicFolder constructor
...
All that complexity can be part of MagicFolder itself.
2018-04-23 10:59:33 -04:00
Jean-Paul Calderone
ac6269dd2d
Only read magic-folder config from config reader
...
Also, fix the umask feature which was completely broken previously due
to failure to parse the umask string into an integer.
2018-04-23 10:41:48 -04:00
Jean-Paul Calderone
0bdabacce3
document the node_directory parameter
2018-04-23 10:41:48 -04:00
Jean-Paul Calderone
8eb83bbfb9
avoid about-to-be-deprecated getClientIP if we can
...
Use the replacement, getClientAddress. But have a fallback to
getClientIP to keep supporting older versions of Twisted.
2018-04-20 16:03:19 -04:00
Jean-Paul Calderone
edf3c7aac7
reformat to fit within 80 cols
2018-04-20 15:59:35 -04:00
Jean-Paul Calderone
06a1ada624
Remove double-encoding of magic-folder params
2018-04-20 14:43:34 -04:00
Jean-Paul Calderone
234db487cd
Add a unit test for X-Frame-Options being set
2018-04-13 12:56:50 -04:00
Jean-Paul Calderone
7bc207cdcb
Shift this out of the way
2018-04-13 12:52:12 -04:00
Jean-Paul Calderone
36c7756890
Reference X-Frame-Options documentation
2018-04-13 12:48:03 -04:00
Daira Hopwood
718fa4493c
Add "X-Frame-Options: DENY" header to all pages. refs #1455
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-04-13 12:43:18 -04:00
Jean-Paul Calderone
dc4d30f7c2
Switch to TAHOE_LAFS prefix
2018-04-03 14:07:12 -04:00
Jean-Paul Calderone
6bca749592
this is still needed
2018-04-03 13:59:35 -04:00
Jean-Paul Calderone
f6f617c33c
Teach it about a CI profile
...
This profile does not have time-based warnings.
2018-04-03 13:15:54 -04:00
Jean-Paul Calderone
da2e4a80cd
Get rid of these individual suppressions
2018-04-03 13:15:54 -04:00
Chris Wood
c850638537
Fix PyInstaller builds
...
This commit contains a few small changes to fix PyInstaller frozen
builds (which were recently broken in a few ways by changes introduced
with `tahoe invite`, `tahoe daemonize`, and the addition of "setuptools
>= 28.8.0" to setup_requires) and removes a couple of hacks that are no
longer necessary to create working frozen tahoe executables with
PyInstaller.
2018-03-29 14:11:15 -04:00
Brian Warner
ce473bd5f4
cli.test_alias: move skip-unless utility to common_util.py
...
next to the other skip-unless function
2018-03-28 15:30:24 -07:00
Brian Warner
0616aa7de7
test_absolute_storage_dir: don't use uSNOWMAN on non-unicode platforms
...
Exercising the unicode possibilities are nice, but not critical to this test,
so let's just avoid the non-ascii characters when the filesystem encoding
can't handle them
2018-03-28 15:17:23 -07:00
Brian Warner
0964bc0d05
test_alias: skip unicode tests on non-unicode platform
...
This was flunking the OS-X buildbot, which runs in an environment without
$LANG being set, and thus encodingutil deduces (correctly but unhelpfully)
that we're limited to ASCII. Other tests detect this situation and raise
SkipTest, so let's do that here too.
2018-03-27 15:56:10 -07:00
Jean-Paul Calderone
6ec5005ccd
Merge pull request #474 from exarkun/1587.basic-progress-report
...
Basic progress reporting for `tahoe backup`
Fixes ticket:1587
2018-03-27 07:47:01 -04:00
Jean-Paul Calderone
fa567958c3
2 blank between top-level; 1 blank between methods
...
Just like PEP8 says
2018-03-26 20:15:45 -04:00
Jean-Paul Calderone
bafe043b73
Explicit new-style class
2018-03-26 20:12:47 -04:00
Jean-Paul Calderone
b78c6cc5ed
Implement the progress reporting
2018-03-26 11:34:31 -04:00
Jean-Paul Calderone
6690aa7337
restore, with tests, checked counters
2018-03-26 10:27:19 -04:00
Jean-Paul Calderone
c55d2823ae
first pass refactoring
...
now collect backup work up-front instead of mixed with processing
2018-03-26 10:02:42 -04:00
Brian Warner
38da8f471c
test_web: appease pyflakes
2018-03-21 00:22:31 -07:00
Brian Warner
e6ddd03338
test_web: remove noisy print statement
2018-03-21 00:13:52 -07:00
meejah
544f87a318
need setuptools for PEP440 identifiers
...
(needs fixup, probably, just depending on latest setuptools)
2018-03-20 17:45:08 -07:00
Jean-Paul Calderone
3bb4c979c8
Revert "Merge PR470"
...
This reverts commit 7960a1b2a43fa74d860f
2018-03-20 18:10:44 -04:00
meejah
4eac3caa77
need setuptools for PEP440 identifiers
...
(needs fixup, probably, just depending on latest setuptools)
2018-03-20 14:15:33 -07:00
meejah
643e2f9107
fix windows, maybe
2018-03-20 11:40:50 -06:00
meejah
fcfcbaa6a2
fix behavior of fake fileops test-helper
2018-03-20 11:40:49 -06:00
meejah
2fd2a9b2c7
nicer assert
2018-03-20 11:40:49 -06:00
meejah
9df84e71fe
use better error-testing idiom and don't tweak internal method
2018-03-20 11:40:49 -06:00
meejah
57cc877c57
add some context to logging
2018-03-20 11:40:49 -06:00
meejah
ee0f548aa7
describe test
2018-03-20 11:40:49 -06:00
meejah
a06fe375ec
describe test
2018-03-20 11:40:49 -06:00
meejah
c7cbb4a6b3
better var names
2018-03-20 11:40:49 -06:00
meejah
30811d8818
typo
2018-03-20 11:40:49 -06:00
meejah
9032539860
flake8; naming
2018-03-20 11:40:49 -06:00
meejah
797932244d
log failure properly, add test
2018-03-20 11:40:49 -06:00
meejah
39080852cc
ensure 'in progress' items return status
2018-03-20 11:40:49 -06:00
meejah
1f495ec41f
cover uploads and downloads in tests
2018-03-20 11:40:49 -06:00
meejah
dbc9f7e06c
remove code that sets item size (from review)
2018-03-20 11:40:49 -06:00
meejah
75e97e6c6d
use QueuedItem directly instead of FakeStatusItem
2018-03-20 11:40:49 -06:00
meejah
1b16e1f792
Some documentation for QueueMixin
2018-03-20 11:40:49 -06:00
meejah
472d6ba78b
cover some of get_status
2018-03-20 11:40:49 -06:00
meejah
bfabfeba64
add 'size' to tests, print unicode
2018-03-20 11:40:49 -06:00
meejah
0ebb587666
report download sizes in magic-folder status
2018-03-20 11:40:49 -06:00
meejah
0431be14fa
log inotify callback errors
2018-03-20 11:40:49 -06:00
meejah
42766da553
add a 'size' to pending uploads
2018-03-20 11:40:49 -06:00
meejah
8ac63cf5bd
only keep history for items that are processed
2018-03-20 11:40:49 -06:00
meejah
bcdd15394b
ensure there are no gaps in magic-folder status
2018-03-20 11:40:49 -06:00
Jean-Paul Calderone
371965f7d4
Specify the new optFlag correctly
2018-03-19 15:12:59 -04:00
Jean-Paul Calderone
1f92879788
improve test coverage
2018-03-19 14:21:28 -04:00
Ruben Pollan
136de7d7f7
Add storage_dir config field
...
On the [storage] section of the tahoe.cfg now there is a field
'storage_dir' where the path to the storage folder can be configured.
2018-03-19 11:20:04 -04:00
meejah
a1cb401f06
Merge pull request #452 from meejah/list-aliases-json.1
...
Add --json option to 'tahoe list aliases'
2018-03-13 17:05:20 -06:00
tpltnt
a41d827f79
_None() as new style class
2018-03-02 17:17:30 +01:00
tpltnt
1967cd7357
removed unnecessary after return
2018-03-02 16:45:11 +01:00
tpltnt
1a14d5218b
added some docstrings
2018-03-02 16:45:11 +01:00
tpltnt
3f99eceb36
minor whitespace fixes
2018-03-02 16:45:11 +01:00
tpltnt
0461cc0148
only one module import per line
2018-03-02 16:45:11 +01:00
tpltnt
f7bbc9dffe
made mkstemp() call compatible with mktemp()
2018-03-02 16:45:11 +01:00
tpltnt
710ba84a02
switched to secure mkstemp()
2018-02-27 18:35:08 +01:00
meejah
0b25cad71e
documentation fixups from daira's review
2018-02-06 15:28:02 -07:00
meejah
1171bf13af
ticket #2882 : preserve user mtime
2018-02-06 15:27:56 -07:00
meejah
68783d8b8a
directories get +x, files do not
2018-01-09 01:26:37 -07:00
meejah
3466088717
add --json option for 'tahoe list-aliases'
...
some new tests to cover previously-uncovered code that changed
2018-01-05 18:07:52 -07:00
meejah
187eb562f2
Merge pull request #447 from tpltnt/ticket-1307
...
Ticket 1307
2018-01-04 17:50:21 -07:00
tpltnt
95acd57fdd
removed exact version info from header
2018-01-04 22:29:57 +01:00
tpltnt
48b442f8c1
mentioned ctx
2018-01-04 22:29:57 +01:00
tpltnt
6d4f4f4a65
adjusted doc string
2018-01-04 22:29:57 +01:00
tpltnt
68b1271190
added docstring
2018-01-04 22:29:57 +01:00
tpltnt
005bcf5012
added code as described in ticket 1307
2018-01-04 22:29:57 +01:00
tpltnt
c5e8d83b73
removed old test/trial helper module
2018-01-04 22:09:52 +01:00
tpltnt
c7cf7c3956
make twisted >= 16.4.0 a requirement
2018-01-04 22:09:52 +01:00
meejah
c351a1d327
Merge pull request #453 from meejah/magic-folder-test-time
...
use '5 years ago' instead of absolute timestamp
2018-01-03 15:41:32 -07:00
meejah
5f00842532
use exarkun's suggestion from review
2018-01-03 14:07:38 -07:00
Brian Warner
5e62118e14
hush somewhat-real problems found by static analysis
...
These would have caused problems if a certain unlikely code path was taken:
mostly error-handling pathways.
2017-12-31 00:23:43 +01:00
Brian Warner
da4e7dcfbe
hush a bunch of not-really-problems caught by the lgtm.com static analyzer
...
This is all minor stuff: unreachable debug code (that should be commented-out
instead of in an 'if False:' block), unnecessary 'pass' and 'global'
statements, redundantly-initialized variables. No behavior changes. Nothing
here was actually broken, it just looked suspicious to the static analysis at
https://lgtm.com/projects/g/tahoe-lafs/tahoe-lafs/alerts/?mode=list .
2017-12-31 00:19:41 +01:00
meejah
e5d6272b62
use '5 years ago' instead of absolute timestamp
2017-12-20 13:17:54 -07:00
meejah
6c0c90829f
cheezy test for more coverage
2017-12-05 12:02:16 -07:00
meejah
87ad3cb8e9
fix 2880
...
- remember upload URI so we don't re-download
- account for empty files in "should_download"
- fix 'conflicted' asserts in tests
2017-12-05 12:02:16 -07:00
meejah
672475cb2b
Multiple magic-folders
...
This moves all magic-folder configs to a single YAML
file. We load legacy config fine and don't mess with
legacy config unless you use a magic-folder command that
changes the config.
Increase test coverage
2017-12-05 10:34:48 -07:00
meejah
1b6f477549
Pull "config" handling out of Node and hide node-derivitives
...
This includes:
- refactor to create_client and _Client
- refactor to _IntroducerNode and create_introducer
2017-11-20 12:57:20 -07:00
meejah
50f8397c99
Merge branch 'invalid-pidfile' into delete-invalid-pidfile--lpirl
...
Conflicts:
src/allmydata/scripts/startstop_node.py
src/allmydata/test/cli/test_cli.py
2017-11-08 14:49:29 -07:00
Brian Warner
a1711088ed
test_i2p_provider: exercise escaping of apiEndpoint attribute
2017-11-03 00:24:46 -07:00
Brian Warner
1f1afe65ec
tor_provider.get_listener(): return a real endpoint, instead of a descriptor
...
get_listener() is allowed to return either, and the Tor provider is currently
simple enough to not really need more than a basic descriptor, but have it
return a full Endpoint for use as an example of what I2P can do later.
2017-11-03 00:24:46 -07:00
Brian Warner
d713e0e57d
address review feedback: docstrings, better test class name
2017-11-03 00:24:46 -07:00
