Jean-Paul Calderone
f789339a79
Have MutableShare file only write a new lease if there is room for it
...
This is analagous to the earlier ShareFile change.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
dd1ab2afe8
Add a helper to compute the size of a lease in a mutable share
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
e0ed04c103
use SyncTestCase to get expectThat
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
4defc641a2
Have ShareFile only write a new lease if there is room for it
...
StorageServer passes available space down so it can make the decision.
ShareFile has to do it because `add_or_renew_lease` only *sometimes* adds a
lease and only ShareFile knows when that is.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
1264c3be1e
Use _add_or_renew_leases helper consistently in StorageServer
...
This will make it easier to add a new argument to the underlying
`add_or_renew_lease` call.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
b3aa1e224f
Add a helper to LeaseInfo for computing size
...
This lets some code LBYL and avoid writing if the lease won't fit in the
immutable share in the space available.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
c774256937
Add a test for `remote_add_lease` with respect to reserved space
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
82e4704415
Merge remote-tracking branch 'remediate/master' into LFS-01-008
2021-10-22 15:27:15 -04:00
Jean-Paul Calderone
ce30f9dd06
clean up copyediting errors
2021-10-22 15:04:45 -04:00
Jean-Paul Calderone
bb31215134
Merge remote-tracking branch 'remediate/master' into LFS-01-007
2021-10-22 12:35:57 -04:00
Jean-Paul Calderone
d8c466e9a7
try to explain lease_count_format more clearly
2021-10-22 12:35:11 -04:00
Jean-Paul Calderone
a22787e879
Merge pull request #30 from tahoe-lafs/LFS-01-001
...
Fix item LFS-01-001 from the Cure53 audit
Fixes: ticket:3819
2021-10-22 12:20:38 -04:00
Jean-Paul Calderone
6c0ca0b885
try making windows let us use longer paths
2021-10-22 11:42:13 -04:00
Jean-Paul Calderone
3cd9a02c81
Reject negative lengths in MutableShareFile._read_share_data and readv
2021-10-18 20:22:52 -04:00
Jean-Paul Calderone
5e58b62979
Add a test for negative offset or length to MutableShareFile.readv
2021-10-18 20:22:52 -04:00
Jean-Paul Calderone
df64bbb1e4
fail to encode the lease count *before* changing anything
...
This preserves the failure behavior - `struct.error` is raised - but leaves
the actual share file contents untouched if the new lease count cannot be
encoded.
There are still two separate write operations so it is conceivable that some
other problem could cause `write_lease_record` to happen but
`write_encoded_num_leases` not to happen. As far as I can tell we have
severely limited options for addressing that problem in general as long as
share files are backed by a POSIX filesystem.
However, by removing the failure mode that depends on user input, it may be
that this is all that is needed to close the *security* hole.
2021-10-18 20:17:41 -04:00
Jean-Paul Calderone
f60bbbd3e2
make it possible to test this behavior of add_lease
2021-10-18 20:17:41 -04:00
Jean-Paul Calderone
1c347c5931
replace sensitive introducer fURL with path where it can be found
2021-10-18 08:05:40 -04:00
Itamar Turner-Trauring
e099bc6736
Tests for IStorageServer.advise_corrupt_share.
2021-10-14 12:52:56 -04:00
Itamar Turner-Trauring
22aab98fcf
When callRemoteOnly as removed, these probably should've been changed to return
...
a Deferred.
2021-10-14 12:52:40 -04:00
Jean-Paul Calderone
efc9dc831b
Revert "a stab at using setup.cfg and setuptools_scm"
...
This reverts commit 68e8e0a7d5b88568bd01c1a14957f972830d1f54.
2021-10-14 11:01:37 -04:00
Jean-Paul Calderone
68e8e0a7d5
a stab at using setup.cfg and setuptools_scm
2021-10-14 10:58:41 -04:00
Itamar Turner-Trauring
807363adc9
Reduce duplication.
2021-10-06 16:41:50 -04:00
Itamar Turner-Trauring
3cf09ef888
Merge remote-tracking branch 'origin/master' into 3798-bucket-write-abort-tests
2021-10-06 16:07:39 -04:00
Itamar Turner-Trauring
0a605530d8
Merge pull request #1134 from tahoe-lafs/3793-persistent-bucketwriter
...
Don't tie BucketWriter lifetime to Foolscap connection lifetime
Fixes ticket:3793
2021-10-06 16:07:17 -04:00
Itamar Turner-Trauring
f3ebc71410
Merge pull request #1133 from tahoe-lafs/3805-istorageserver-tests-slot-readv
...
IStorageServer tests: slot_readv
Fixes ticket:3805
2021-10-06 15:41:29 -04:00
Itamar Turner-Trauring
bf176144c5
Handle double-disconnect, should it happen by mistake.
2021-10-06 15:18:00 -04:00
Itamar Turner-Trauring
82cbce6b7e
Better explanation.
2021-10-06 15:12:22 -04:00
Itamar Turner-Trauring
17a670dfb5
Test for aborting bucket upload.
2021-10-04 10:37:37 -04:00
Itamar Turner-Trauring
b09b7fd01b
Merge branch '3793-persistent-bucketwriter' into 3798-bucket-write-abort-tests
2021-10-04 10:30:41 -04:00
Itamar Turner-Trauring
23fd11be43
Expand explanation.
2021-09-29 14:13:18 -04:00
Itamar Turner-Trauring
016d6b4530
Fix spurious type checking error.
2021-09-29 14:10:14 -04:00
Itamar Turner-Trauring
f8604e2394
Fix flakes.
2021-09-29 14:00:11 -04:00
Itamar Turner-Trauring
58d7e2f627
Simplify implementation.
2021-09-29 13:58:53 -04:00
Itamar Turner-Trauring
8fb6afee1b
Refactor BucketWriters such that disconnection can be limited Foolscap.
2021-09-29 13:42:17 -04:00
Itamar Turner-Trauring
a4153b7125
Implementation plan.
2021-09-29 11:56:04 -04:00
Itamar Turner-Trauring
51e8b5e197
Disconnection test works now.
2021-09-29 11:17:33 -04:00
Itamar Turner-Trauring
45c564f3c8
Merge pull request #1131 from tahoe-lafs/3797-istorageserver-tests-part-3
...
IStorageServer tests, part 3: slot_testv_and_writev_and_readv
Fixes ticket:3797
2021-09-29 10:28:42 -04:00
meejah
0a072a98c8
Merge pull request #1125 from hacklschorsch/3786.openmetrics
...
3786 Add OpenMetrics (Prometheus) statistics endpoint
2021-09-28 13:21:46 -06:00
Itamar Turner-Trauring
e64c397fc5
WIP disconnection test.
2021-09-28 13:51:31 -04:00
Itamar Turner-Trauring
a02d5f4c9c
Just stick to current behavior.
2021-09-28 13:02:01 -04:00
Itamar Turner-Trauring
9970559019
Tests for slot_readv.
2021-09-28 10:46:21 -04:00
Itamar Turner-Trauring
fadfbcad99
Merge pull request #1130 from tahoe-lafs/3801-no-overlapping-writes-immutable-upload
...
Disallow conflicting overlapping writes when doing an immutable upload.
Fixes ticket:3801
2021-09-28 10:37:56 -04:00
Itamar Turner-Trauring
c668e342c2
More STARAW tests.
2021-09-28 09:54:13 -04:00
Itamar Turner-Trauring
914ca56775
TODOs.
2021-09-27 17:05:03 -04:00
Itamar Turner-Trauring
9f80435b41
Update to new interface.
2021-09-27 17:04:22 -04:00
Itamar Turner-Trauring
da363d54de
Merge remote-tracking branch 'origin/master' into 3797-istorageserver-tests-part-3
2021-09-27 17:03:05 -04:00
Itamar Turner-Trauring
eb5b6c557e
Merge pull request #1127 from tahoe-lafs/3799-simplify-IStorageServer
...
Rip out unnecessary operator logic, and simplify IStorageServer
Fixes ticket:3799
2021-09-27 16:57:16 -04:00
Itamar Turner-Trauring
de1a7d7fce
A more explicit test for successful overlapping.
2021-09-27 16:56:24 -04:00
Itamar Turner-Trauring
da937cef9e
Correct docstring.
2021-09-27 15:04:04 -04:00
