Jean-Paul Calderone
f0734284e0
whitespace
2019-01-30 19:24:20 -05:00
Jean-Paul Calderone
2531c19efd
Merge pull request #537 from tahoe-lafs/2959.travis-trusty-tor
...
Move integration tests from TravisCI to CircleCI
Fixes: ticket:2959
2019-01-24 20:47:24 -05:00
Jean-Paul Calderone
7e9e447d5b
Disable Twisted's Docker check wrt inotify support
...
It breaks our container-based CI, which is perfectly happy to give us inotify
functionality, as is Docker in general as long as you don't use overlayfs.
2019-01-24 14:00:50 -05:00
Jean-Paul Calderone
dcb4a218b1
This nearby code is also dead.
2019-01-24 09:55:40 -05:00
Jean-Paul Calderone
252f9eb23a
This code has pyflakes warnings *and* is dead.
2019-01-24 09:53:49 -05:00
Jean-Paul Calderone
e36c850da4
== instead of is for string comparison
2019-01-24 09:53:02 -05:00
Jean-Paul Calderone
5ed375b145
Add more complexity to the package sanity checking
...
Support comma-separated lists of extras
2019-01-23 14:58:44 -05:00
Jean-Paul Calderone
4166551afd
Bump dependency to Twisted 16.6 and add conch extra
...
This automatically brings in the bcrypt dependency coming along with a
forthcoming Twisted release.
2019-01-23 14:02:15 -05:00
meejah
768eceacf2
unused var
2018-09-11 11:38:56 -06:00
meejah
1ad2174df9
windows yaml.safe_load returns None on unreadable files..
2018-09-11 11:14:41 -06:00
meejah
7d34f8f1a1
test case when safe_load fails
2018-09-10 21:58:28 -06:00
meejah
419dea7b3a
different import style for multi-imports from allmydata.node
2018-09-10 21:58:28 -06:00
meejah
3d35723a59
windows yamlutil.safe_load returns None when files are unreadable
2018-09-10 21:58:28 -06:00
meejah
72f17a3834
better cleanup
2018-09-10 21:58:28 -06:00
meejah
8a6a477ef7
don't depend on .called and .result (use Deferred callbacks properly)
2018-09-10 21:58:28 -06:00
meejah
054ed30757
better docstrings
2018-09-10 21:58:28 -06:00
meejah
87e0ce801a
proper assert
2018-09-10 21:58:28 -06:00
meejah
3cc64649c0
add a pointer to relevant ticket
2018-09-10 21:58:28 -06:00
meejah
d0141b2f95
better docstring from exarkun
2018-09-10 21:58:28 -06:00
meejah
edb581b434
better docstring from exarkun
2018-09-10 21:58:28 -06:00
meejah
507c2db649
better utest docstring, cleanup
2018-09-10 21:58:28 -06:00
meejah
376a1dcbd5
turn XXX into a ticket
2018-09-10 21:58:28 -06:00
meejah
8b5e988755
use docstring to mark method as async
2018-09-10 21:58:28 -06:00
meejah
2b5d3be3c8
convert XXX comment to ticket
2018-09-10 21:58:28 -06:00
meejah
7de94f623c
clarify Introducer imports
2018-09-10 21:58:28 -06:00
meejah
9a8ef9512e
clarify comments
2018-09-10 21:58:28 -06:00
meejah
f488b79c71
self._portnumfile -> config.portnum_fname
2018-09-10 21:58:28 -06:00
meejah
692128ad1d
better defaults handling
2018-09-10 21:58:28 -06:00
meejah
2e2bdf1ea1
test for EnvironmentError that's not ENOENT
2018-09-10 21:58:28 -06:00
meejah
ab812ca75f
fix utests for Deferred/Failure-returning methods
2018-09-10 21:58:28 -06:00
meejah
f6b62ca192
import
2018-09-10 21:58:28 -06:00
meejah
a344bb24dc
immutable default
2018-09-10 21:58:27 -06:00
meejah
dee8b72206
dead code
2018-09-10 21:58:27 -06:00
meejah
9aae4bd459
only handle ENOENT
2018-09-10 21:58:27 -06:00
meejah
a5287add80
clarify comments
2018-09-10 21:58:27 -06:00
meejah
efce7b1f6a
use Failure for all errors from async methods
2018-09-10 21:58:27 -06:00
meejah
676a9efc23
docstring
2018-09-10 21:58:27 -06:00
meejah
714b0887dc
more docstrings
2018-09-10 21:58:27 -06:00
meejah
2d55b61dd2
fixups after rebase
2018-09-10 21:58:27 -06:00
meejah
c22d7c632e
docstring improvements
2018-09-10 21:58:27 -06:00
meejah
3974af6660
redundant imports
2018-09-10 21:58:27 -06:00
meejah
7632504373
create_client is async
2018-09-10 21:58:27 -06:00
meejah
14a66a54f0
flake8
2018-09-10 21:58:27 -06:00
meejah
0cfbdeb634
dead code
2018-09-10 21:58:27 -06:00
meejah
767f4ddd5d
reorder args to match other method
2018-09-10 21:58:27 -06:00
meejah
045af64c2b
dead code
2018-09-10 21:58:27 -06:00
meejah
06de4c88c4
codecleanup (incorrect merge?)
2018-09-10 21:58:27 -06:00
meejah
edc50f655b
get rid of is_tub_listening
2018-09-10 21:58:27 -06:00
meejah
a82aa4ba2c
code cleanup, docs
2018-09-10 21:58:27 -06:00
meejah
955d7abfa3
move validation code to parser-helper
2018-09-10 21:58:27 -06:00
meejah
2517535d2b
test for 'listen on port 0'
2018-09-10 21:58:27 -06:00
meejah
9e34d15b90
simplify _tub_portlocation helper
2018-09-10 21:58:27 -06:00
meejah
053b494054
comment
2018-09-10 21:58:27 -06:00
meejah
e74d2a7d01
get rid of redundant 'introducer_clients' var
2018-09-10 21:58:27 -06:00
meejah
c84e50baf0
post-rebase fixup: _client_factory and docs
2018-09-10 21:58:27 -06:00
meejah
c7b47f44d2
flake8
2018-09-10 21:58:27 -06:00
meejah
17fa32633c
post-rebase fixups; needs review
2018-09-10 21:58:27 -06:00
meejah
23d304814f
not required for tests
2018-09-10 21:58:27 -06:00
meejah
283be23e3a
basedir fixup, more tests
2018-09-10 21:58:27 -06:00
meejah
a628411988
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
c2d1cf4400
correct service-parent in tests
2018-09-10 21:58:27 -06:00
meejah
136495e405
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
2d044e1324
remove unused method
2018-09-10 21:58:27 -06:00
meejah
bb332fecf7
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
548d9cbbcc
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
5d6a76ffee
proper daemonize error-handling
2018-09-10 21:58:27 -06:00
meejah
08e0c3b7e2
get rid of 'add_service' (just an alias to setServiceParent anyway)
2018-09-10 21:58:27 -06:00
meejah
ea99915af6
basedir/config fixup
2018-09-10 21:58:27 -06:00
meejah
7685fb34cd
pull 'basedir' entirely into _Config
...
Put all config-related methods into _Config; change
code to ask config for paths instead of using basedir;
add some better docstrings
2018-09-10 21:58:27 -06:00
meejah
f80e61fef6
put setServiceParent calls in create_*
2018-09-10 21:58:27 -06:00
meejah
26007f363b
pull 'StorageFarmBroker' out of __init__
...
This means also pulling out introducer-clients and some
related utility methods
2018-09-10 21:58:27 -06:00
meejah
42c39d435a
imports
2018-09-10 21:58:27 -06:00
meejah
465bfb8053
cleanup
2018-09-10 21:58:27 -06:00
meejah
48f0df627e
cleanup
2018-09-10 21:58:27 -06:00
meejah
739aaa3ef9
put create() methods in i2p_, tor_provider
...
Also Provider -> _Provider, improve docs and update tests
2018-09-10 21:58:27 -06:00
meejah
903d4afaa4
handle None for providers
2018-09-10 21:58:27 -06:00
meejah
793827f8a6
put providers back in service tree
2018-09-10 21:58:27 -06:00
meejah
e7a8d39fbc
split client, introducer READMEs
2018-09-10 21:58:27 -06:00
meejah
c2946cc2e3
remove unused code
2018-09-10 21:58:27 -06:00
meejah
f0c3db0e5a
pyflakes
2018-09-10 21:58:27 -06:00
meejah
0ff21ea7d5
all tests pass. wooo
2018-09-10 21:58:27 -06:00
meejah
c7515b5d8b
more working test
2018-09-10 21:58:27 -06:00
meejah
92ca04d629
fix more tests
2018-09-10 21:58:27 -06:00
meejah
0e51bb183e
fix more things
2018-09-10 21:58:27 -06:00
meejah
279bd814fc
remember info for init_client_storage_broker temporarily
2018-09-10 21:58:27 -06:00
meejah
3c4e065e63
more tests work
2018-09-10 21:58:27 -06:00
meejah
d1307cf05c
fix one more
2018-09-10 21:58:27 -06:00
meejah
43d857a0bd
more refactor + fix some node tests
2018-09-10 21:58:27 -06:00
meejah
71484b4a12
upgrade create_introducer
2018-09-10 21:58:27 -06:00
meejah
4f2d45626c
no more reveal_ip
2018-09-10 21:58:27 -06:00
meejah
d8b432700e
more tests work
2018-09-10 21:58:27 -06:00
meejah
3d5f8becb5
more tests work
2018-09-10 21:58:27 -06:00
meejah
d1a83e9be0
more tests work
2018-09-10 21:58:27 -06:00
meejah
329ef1256a
refactor create_client to be async (works to run, some unit-test fails still)
2018-09-10 21:58:27 -06:00
meejah
41cfd8fb16
change imports; introducer client.read_config
2018-09-10 21:58:27 -06:00
meejah
eab56276e5
introduce create_node_dir
2018-09-10 21:58:27 -06:00
meejah
0f22b9bad0
fixups after rebase
2018-08-25 02:23:58 -06:00
meejah
65ebde6f9d
fix incorrect rebase resolutions
2018-08-25 02:12:02 -06:00
meejah
91517bbad0
unused import
2018-08-25 02:12:02 -06:00
meejah
cce4a92900
fix path-creation cases after merge
2018-08-25 02:12:02 -06:00
meejah
dab291c72f
docstring
2018-08-25 02:12:02 -06:00
meejah
74b560c3c2
failUnless -> assert
2018-08-25 02:10:44 -06:00
meejah
7db48e3677
skip using decorator
2018-08-25 02:10:44 -06:00
meejah
89872b832c
docstring, naming improvements
2018-08-25 02:10:44 -06:00
meejah
38dac24b2b
use skipIf decorator, not inline logic
2018-08-25 02:10:44 -06:00
meejah
d478cf3831
add some docstrings, fix comments
2018-08-25 02:10:44 -06:00
meejah
536ccf8b6d
better 'file not found' handling
2018-08-25 02:10:44 -06:00
meejah
c0772cdd5f
improve docstring
2018-08-25 02:10:44 -06:00
meejah
37d4b59a39
modern syntax
2018-08-25 02:10:44 -06:00
meejah
1b30e9edfc
consistently use 'config' not 'self.config' in __init__
2018-08-25 02:10:44 -06:00
meejah
a432fc35da
docstring improvements
2018-08-25 02:10:44 -06:00
meejah
629185d98f
skip some tests on windows (permissions)
2018-08-25 02:10:44 -06:00
meejah
5000787c18
flake8
2018-08-25 02:10:44 -06:00
meejah
27ea11d164
dead code
2018-08-25 02:10:44 -06:00
meejah
abd7b638b8
basic stfpd setup test
2018-08-25 02:10:44 -06:00
meejah
dd2209a96c
tests to cover config changes
2018-08-25 02:10:44 -06:00
meejah
6c388b9d58
test for authtoken API
2018-08-25 02:10:44 -06:00
meejah
ab947704f0
replace PortLocations tests
...
The old tests were hard to read due to all the "if"
statements; these might be slightly more verbose but
also more explicit
2018-08-25 02:10:44 -06:00
meejah
4d7f8ec9dd
keep clientdir for now, improve how we access it
2018-08-25 02:10:44 -06:00
meejah
2937c729e3
change imports; introducer client.read_config
2018-08-25 02:10:44 -06:00
meejah
4c7f60f42a
test fixups from review
2018-08-25 02:10:44 -06:00
meejah
107ddcd1ba
get rid of get_clientdir
2018-08-25 02:10:44 -06:00
meejah
d544284f92
introduce create_node_dir
2018-08-25 02:10:44 -06:00
meejah
c93ee4f867
document a test-method
2018-08-25 02:10:44 -06:00
meejah
f7f3c54f93
dead code
2018-08-25 02:10:44 -06:00
meejah
86a9ce5793
create _NoNetworkClient using same code as _Client
2018-08-25 02:10:44 -06:00
meejah
22e2d0a417
re-expand path because user input
2018-08-25 02:10:44 -06:00
meejah
f68a0ab74c
remove debug
2018-08-25 02:10:44 -06:00
meejah
79756c088e
split client, introducer READMEs
2018-08-25 02:10:44 -06:00
meejah
990f23d5c7
_Config does this for us
2018-08-25 02:10:44 -06:00
meejah
38063037c1
add documentation
2018-08-25 02:10:44 -06:00
meejah
f37ab3b12d
get_app_version -> global function
2018-08-25 02:10:44 -06:00
meejah
35810a5692
pull 'basedir' entirely into _Config
...
Put all config-related methods into _Config; change
code to ask config for paths instead of using basedir;
add some better docstrings
2018-08-25 02:10:44 -06:00
Jean-Paul Calderone
292448a423
Merge pull request #518 from LeastAuthority/test_upload_and_download_random_key
...
Avoid EADDRINUSE from allmydata.test.test_system.SystemTest
Fixes ticket:2933
2018-08-22 09:31:48 -04:00
Jean-Paul Calderone
74420fb764
Try to preserve the working directory
2018-08-17 15:53:59 -06:00
meejah
1af71e6ba3
confirm .stop() called
2018-08-17 15:53:59 -06:00
meejah
03712c9cca
add docstrings
2018-08-17 15:53:59 -06:00
meejah
0607b7331f
fix tests by overriding/patching reactor.stop in tests
2018-08-17 15:53:59 -06:00
meejah
423208f391
add a 'tahoe run' unit-test for config errors
2018-08-17 15:53:59 -06:00
meejah
e9879abc93
add unit-tests
2018-08-17 15:53:59 -06:00
meejah
bd63a4354b
fixup for errors
2018-08-17 15:53:59 -06:00
meejah
4aec12a92f
whitespace on long lines
2018-08-17 15:53:59 -06:00
meejah
8e0e96da01
improve user experience on config errors
2018-08-17 15:53:59 -06:00
meejah
3723945296
Actually validate configs when loading them
...
An indenting problem meant the validators weren't being
called, which revealed some follow-on errors.
2018-08-17 15:53:59 -06:00
Jean-Paul Calderone
f9d527f418
Avoid the chance of providing a real endpoint parser
...
This endpoint is test-grade.
2018-08-08 12:01:20 -04:00
Jean-Paul Calderone
0ca6b8ed52
An adopted-port-endpoint-based fix for the collision
2018-08-07 15:26:35 -04:00
Jean-Paul Calderone
9ec8ec814a
Some comment improvements
2018-08-07 15:26:19 -04:00
Jean-Paul Calderone
b1520c8d71
Some improved logging while waiting for connections
2018-08-07 15:22:19 -04:00
Jean-Paul Calderone
d8dfcc9de5
There are no such subclasses.
2018-08-07 14:05:16 -04:00
Jean-Paul Calderone
f576575f11
system test setup broken into manageable pieces
...
`set_up_nodes` and `_set_up_nodes_2` now a little easier to understand
2018-08-07 14:04:20 -04:00