Jean-Paul Calderone
3c68f5897a
Merge pull request #555 from tahoe-lafs/2976.help-output-groups
...
Remove the attempt at grouping the subcommands.
Fixes: ticket:2976
2019-03-29 13:02:38 -04:00
heartsucker
129ef22185
updated instances of octal literals to use the format 0o123 for python3 compatibility
2019-03-29 11:08:44 +01:00
Jean-Paul Calderone
7511b5956b
Merge pull request #590 from tahoe-lafs/3016.address-already-in-use
...
Fix more "Address already in use" errors
Fixes: ticket:3016
2019-03-28 19:01:44 -04:00
Jean-Paul Calderone
a4a73a20a2
Fix incorrect assertion
2019-03-28 16:18:43 -04:00
Jean-Paul Calderone
53b40ef0e0
don't double start; don't try to handle double start.
2019-03-28 16:10:36 -04:00
Jean-Paul Calderone
a7d18780f2
try really hard to bind that random ephemeral port number
2019-03-28 16:06:25 -04:00
meejah
6970c2cc6d
Merge pull request #579 from tahoe-lafs/3001-python3-syntax-check
...
python3 syntax check
2019-03-28 19:14:59 +00:00
Jean-Paul Calderone
f5e287d3e9
Use the port assigner in test_introducer
2019-03-28 15:14:48 -04:00
Jean-Paul Calderone
4265cc8afd
And for the NoNetworkGrid clients' web port config
2019-03-28 15:02:53 -04:00
Jean-Paul Calderone
2898b2477b
Use the port assigner for the web port config as well
2019-03-28 15:02:14 -04:00
Jean-Paul Calderone
7c97503687
Move and somewhat refactor assign_foolscap_port
.
...
These changes make it easier to re-use and remove the notion that it is
foolscap-specific.
2019-03-28 14:54:45 -04:00
heartsucker
be910fe269
updated syntax in directory.py to make whole allmydata.web python3 compatible
2019-03-28 12:32:13 +01:00
heartsucker
dbfcf8ae00
replaced StringIO imports with six.moves
2019-03-28 12:31:37 +01:00
meejah
664bd2dec8
Merge pull request #582 from tahoe-lafs/3010-remaining-print-functions
...
replaced all remaining instances of the print statement with the print function
2019-03-28 02:54:49 +00:00
meejah
d73626b7da
Merge pull request #580 from tahoe-lafs/3008-test-print-function
...
updated test code to use print function over print statement
2019-03-26 00:19:33 +00:00
meejah
d89647581b
Merge pull request #581 from tahoe-lafs/3009-print-functions-tahoe-scripts
...
replaced print statement with print fuction for all tahoe_* scripts
2019-03-26 00:07:08 +00:00
Jean-Paul Calderone
a26b9ca8af
workaround https://github.com/crossbario/autobahn-python/issues/1151
2019-03-25 12:01:36 -04:00
Jean-Paul Calderone
848950a0c0
Merge remote-tracking branch 'origin/master' into ticket3006-websocket-streaming-logs
2019-03-25 08:42:30 -04:00
Jean-Paul Calderone
c2b8024856
remove this print
...
not sure where it came from
2019-03-24 11:33:41 -04:00
Jean-Paul Calderone
336e69c270
Hotfix for nevow#106
2019-03-24 11:26:58 -04:00
heartsucker
64f4dfa8ca
replaced all remaining instances of the print statement with the print function
2019-03-24 14:14:00 +01:00
heartsucker
fc417826f1
replaced print statement with print fuction for all tahoe_* scripts
2019-03-24 14:10:02 +01:00
Jean-Paul Calderone
78e458328e
actually this returns the logs resource itself :/
2019-03-22 16:54:33 -04:00
Jean-Paul Calderone
5ac7efc6f3
Make sure it succeeds with _OK_
2019-03-22 16:43:08 -04:00
Jean-Paul Calderone
febfa50a83
make sure we get bytes here
2019-03-22 16:42:50 -04:00
Jean-Paul Calderone
794314668a
this is not unicode, it came from a file, I guess
2019-03-22 15:50:58 -04:00
Jean-Paul Calderone
9de97dbdd5
Use guard and add some tests (integration failing)
2019-03-22 13:47:32 -04:00
heartsucker
df9243a3f4
updated test code to use print function over print statement
2019-03-22 17:32:36 +01:00
Jean-Paul Calderone
f7f9cf6abc
Merge pull request #576 from tahoe-lafs/3005.upstream-inline_callbacks
...
Use upstream inline_callbacks implementation.
Fixes: ticket:3005
2019-03-21 16:24:21 -04:00
Jean-Paul Calderone
58deb54cfc
import cleanups
2019-03-21 15:01:25 -04:00
Jean-Paul Calderone
d00c4212a8
futurize
2019-03-21 15:01:14 -04:00
Jean-Paul Calderone
5f4f8d9dbb
Create the /private hierarchy
2019-03-21 15:00:57 -04:00
Jean-Paul Calderone
2877c9b3c1
unused import
2019-03-21 15:00:19 -04:00
Jean-Paul Calderone
616fec0767
oops that should be gone too
2019-03-21 15:00:08 -04:00
Jean-Paul Calderone
e02962c3a3
Remove one more webport thingy
2019-03-21 14:39:52 -04:00
Jean-Paul Calderone
edf01d7817
don't compute the url, it doesn't seem to be necessary
2019-03-21 13:58:46 -04:00
meejah
956a39a6c1
clarify
2019-03-21 02:01:33 -06:00
meejah
dbea69c2d2
refactor
2019-03-21 01:52:45 -06:00
meejah
816ceb12cb
make more things work
2019-03-21 01:37:47 -06:00
meejah
b734c893df
prototype token-authenticated WebSocket stream
2019-03-20 18:14:47 -06:00
Jean-Paul Calderone
1f254fbdcc
log the unicode instead of the localized byte string
2019-03-20 16:17:55 -04:00
Jean-Paul Calderone
5bdb37b786
Remove tests for removed code
2019-03-20 12:53:24 -04:00
Jean-Paul Calderone
e2d242d299
remove our implementation of inline_callbacks
...
re-publish Eliot's
2019-03-20 12:53:24 -04:00
Jean-Paul Calderone
e5e08e8410
Update pin to 1.7.x
2019-03-20 12:53:24 -04:00
Jean-Paul Calderone
a14d9f6116
Merge pull request #574 from tahoe-lafs/3004.eliotloggedruntest-addcleanup
...
Fix Eliot logging integration
Fixes: ticket:3004
2019-03-19 14:23:13 -04:00
Jean-Paul Calderone
32d56c4dcc
Merge remote-tracking branch 'origin/master' into 3004.eliotloggedruntest-addcleanup
2019-03-19 12:29:18 -04:00
Jean-Paul Calderone
ae2be27e3a
Merge remote-tracking branch 'origin/master' into 2995.remove-unnecessary-key-copying
2019-03-19 12:09:35 -04:00
Jean-Paul Calderone
4860d16401
Update the comment to reflect the updated implementation
2019-03-18 19:22:38 -04:00
Jean-Paul Calderone
20ba53f586
reflow for changed indentation level
2019-03-18 19:21:05 -04:00
Jean-Paul Calderone
55690bf639
Do it without a new flag
...
This is safer against other conditions where _deque ends up with items when we
start a scan - for example, if we chunk up deque processing.
2019-03-18 15:38:18 -04:00
Jean-Paul Calderone
6a4d461d38
only break it once because we don't do a full iteration after, now
2019-03-18 15:28:43 -04:00
Jean-Paul Calderone
d3fde4a4c5
and put the iterate into an action
2019-03-18 15:28:35 -04:00
Jean-Paul Calderone
0ac96e9113
put the _process_deque into an action too
2019-03-18 15:28:16 -04:00
Jean-Paul Calderone
20150541a7
put the _perform_scan into an eliot action
2019-03-18 15:27:38 -04:00
Jean-Paul Calderone
e1de96486c
Don't re-run _perform_scan in this abstraction violating test
...
Just do what comes after _perform_scan
2019-03-18 15:11:25 -04:00
Jean-Paul Calderone
d1a62b1c99
Attempt to avoid the startup double-scan and related problems
2019-03-18 14:24:34 -04:00
Jean-Paul Calderone
c01c85522d
Use the method
...
There is a method. Why not use it?
2019-03-18 14:18:09 -04:00
Jean-Paul Calderone
50867bec8b
Accept positional and keyword arguments and pass them on.
2019-03-15 15:13:20 -04:00
Jean-Paul Calderone
fda3d38c85
Avoid the extra dict lookup in the loop
...
Get the info at iteration time
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
dd7cb99ef4
Avoid another .keys() call
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
c83749311f
Avoid some function dispatch overhead
...
Also, we might avoid some dict lookup overhead by being optimistic about
finding the entry. At worst, we do two lookups - which is just what we did
before.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
05eab3ce19
document these things since I had to figure them out
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
d504ad118f
Avoid the extra lookup inside this loop
...
Get the key and value at the same time during iteration.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
0e1bc2e786
As for the previous commit.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
62cb883ca2
Just iterate over the dictionary.
...
It is not shared with anyone. It is not mutated inside the loop. We can use
the no-copy dict iterator.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
e0c240a559
Use a MessageType so we can have a serializer
...
This allows us to avoid the .keys() call if logging is not actually enabled,
the common case.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
365ff1a02c
explain why we need to touch() twice
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
5141105441
Fix typo
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
2cb710ac1e
Just touch the path once
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
b14583f0e9
Remove this broken ignore_count thing
...
The only purpose it serves to make the tests invalid and useless.
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
dfd0c6e54c
fix "downloader" type in message type
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
3978c45b04
spit out the events as raw as we can
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
fef79cd4a3
re-use the _add_watch helper
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
fcb08b5a3a
Move these Eliot events somewhere reusable
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
9ed019f8de
Give the tests a little more time. Windows may need it.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
64826aee37
Clean up stdout a bit
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
3176b6f18a
Create the watchdog Observer sooner
...
This lets us watch before start which Windows seems to really want.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
263755fb26
Watch before we start.
...
Linux and macOS are happy to watch after starting. Our Windows support
library can't deal with such a case, though.
Linux is happy with the other order. I'm about to find out if macOS is.
There are likely further Windows issues to deal with.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
2205bf0fdd
unused
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
241b6cedfe
Remove the skipped tests
...
They're skipped because we don't need that functionality. If we need it in
the future, we'll implement it with tests.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
984d27ab62
simplify
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
67ccd21481
python syntax
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
35fc563a6f
Attempt to work-around watchdog bug
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
e0b7919ad8
macOS is picky
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
4cccf5a316
it sure would be useful to be able to inspect these
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
c5c7f954e9
fix it!
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
515475022a
add a test for deleting a file and its containing directory
...
at about the same time
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
0822a71163
If it's some _other_ error then propagate it!
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
c2e19cc098
fix a raft of directory handling issues
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
4b0b269b56
Perform the asserts earlier
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
ed755cf590
it didn't start if the path is invalid
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
f2cfad0cb9
There _is_ no traceback. It's an else.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
db7af2661a
Close a window for a race condition in notification processing
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
81ca822edf
Cut the cost of this logging when logging is disabled
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
3ab7138598
some imports we need
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
7440ff6b93
log collective scanning
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
831836d5f6
don't try to propagate for non-directories
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
edfd9d3f92
rejected
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
cf2105364f
Try to fix another race in this test
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
600f263a3b
marginally improve reporting of uploader count failures
2019-03-14 11:24:35 -04:00