Sajith Sasidharan
5aa0dd4085
Rename a variable for readability
...
Noticed in code review: `l` can be confused with `1` for many
typefaces.
2020-05-13 17:12:08 -04:00
Sajith Sasidharan
812f03934a
Add missing "param:" to docstring
2020-05-13 17:09:53 -04:00
Sajith Sasidharan
4af2e4b4df
Drop an unbalanced quote
2020-05-13 17:08:26 -04:00
Sajith Sasidharan
62760c0997
Make RetrieveStatusPage comment a docstring
2020-05-13 17:07:09 -04:00
Sajith Sasidharan
8e17d203cf
Add missing "param:" to docstring
2020-05-13 16:59:52 -04:00
Sajith Sasidharan
c18488872c
Make comment on MapupdateStatusPage a docstring
2020-05-13 16:54:39 -04:00
meejah
466369dd69
Merge pull request #669 from meejah/make-pypy-work
...
Make pypy work
2020-05-13 12:44:23 -06:00
Sajith Sasidharan
3fad9a127c
Remove web.common.RenderMixin
...
Fixes: ticket:3308
2020-05-12 07:40:22 -04:00
Sajith Sasidharan
0ae045ea16
Add comments to PublishStatusPage
2020-05-11 12:47:48 -04:00
Sajith Sasidharan
9e200fc014
Render publish problems only when there are problems
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
0fba615afb
Remove RateAndTimeMixin from PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
fdf6449ba8
Use MultiFormatResource to implement PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
89c4210090
Use twisted tags in publish status template page
2020-05-11 11:43:01 -04:00
Sajith Sasidharan
65cd0e8ecd
Reformat publish status template page
2020-05-11 10:38:15 -04:00
Sajith Sasidharan
3aaa87d2ba
Add notes to RetrieveStatusPage
2020-05-07 13:15:05 -04:00
Sajith Sasidharan
07f14a19f8
Drop RateAndTimeMixin from RetrieveStatusElement
2020-05-07 11:37:21 -04:00
Sajith Sasidharan
a544e8a55f
Stringify tag parameters
2020-05-07 10:55:08 -04:00
Sajith Sasidharan
de41302743
Update RetrieveStatusPage to use twisted renderers
2020-05-07 09:34:42 -04:00
Sajith Sasidharan
5fa7c4c446
Update markup in retrieve status template page
2020-05-07 09:32:01 -04:00
Sajith Sasidharan
d2375e4fe2
Reformat retrieve status page template
2020-05-06 22:42:32 -04:00
meejah
2418e90bf0
CacheDirectoryManager is unused
2020-05-06 15:22:22 -06:00
meejah
1549e7eb18
simplify (for line in f.readlines() -> for line in f)
2020-05-06 15:16:34 -06:00
Sajith Sasidharan
13bbda1529
Render privkey only when there's a privkey
2020-05-06 13:21:26 -04:00
Sajith Sasidharan
008812d6c8
Render abbreviated time in map update results
2020-05-06 13:11:53 -04:00
Sajith Sasidharan
0c6889274d
Render problems only when there's a problem list
2020-05-06 13:10:31 -04:00
Sajith Sasidharan
bbbca6c000
Drop a newline
...
Party for consistency, partly in order to trigger a CircleCI run.
2020-05-06 10:41:58 -04:00
Sajith Sasidharan
8a71567137
Avoid use of RateAndTimeMixin in MapupdateStatusPage
2020-05-06 09:29:57 -04:00
Sajith Sasidharan
86871363ea
Add notes to MapupdateStatusPage
2020-05-06 09:06:56 -04:00
Sajith Sasidharan
1602c66250
Render map update status using twisted.web.template
...
Fixes: ticket:3291
2020-05-06 09:06:56 -04:00
meejah
6eade15b4e
put WeakKeyDictionary use back
2020-05-05 14:49:16 -06:00
Sajith Sasidharan
3b0ace1710
Merge pull request #708 from sajith/3293.status-helper-nevow-to-twisted-web
...
Render helper status page using twisted.web.template
Fixes: ticket:3293
2020-05-05 16:00:24 -04:00
meejah
d4f29e7d6c
restore old code, run the GC
2020-05-05 13:57:17 -06:00
meejah
b54dc1e5d5
whitespace (1 line per import)
2020-05-05 13:56:59 -06:00
Sajith Sasidharan
5e4f2d88f1
Merge pull request #710 from sajith/3305.root-from-nevow-to-twisted-web
...
Move root.Root from nevow to twisted.web.template
Fixes: ticket:3305
2020-05-05 15:56:21 -04:00
Sajith Sasidharan
ab298dab9c
Make ErrorBoom a new style class
...
ErrorBoom won't pass PythonTwoRegressions.test_new_style_classes()
check otherwise.
2020-05-05 12:56:19 -04:00
Sajith Sasidharan
edd4cab42b
Replace nevow with twisted.web in test.web.test_grid
2020-05-05 11:51:28 -04:00
Sajith Sasidharan
ccffd78ac4
Add a comma, for consistency's sake
2020-05-05 09:27:09 -04:00
Sajith Sasidharan
f5dacf9547
Drop a comma introduced by mistake
2020-05-05 09:27:09 -04:00
Sajith Sasidharan
96c8c5e953
Link to storage server the way it used to be
2020-05-05 07:43:39 -04:00
meejah
1e039d8364
certs big enough to make pypy happy
2020-05-04 21:59:15 -06:00
meejah
00373fc211
special-case pypy
2020-05-04 21:59:15 -06:00
meejah
13350d60c2
assertFailure instead of bespoke code
2020-05-04 21:59:15 -06:00
meejah
bddd2cc996
disable system tests on PyPy
2020-05-04 21:59:15 -06:00
meejah
29563b8f2d
assert proper errors
2020-05-04 21:59:15 -06:00
meejah
f8117320cb
tests which rely on memory-reclamation need gc.collect() on pypy
2020-05-04 21:59:15 -06:00
meejah
8965c77d63
look for correct error-string
2020-05-04 21:59:15 -06:00
meejah
4c3d0ea6cc
use 'with open' for more file-opens
2020-05-04 21:59:15 -06:00
meejah
9bcc465f76
unused import
2020-05-04 21:59:15 -06:00
meejah
4928d62d66
use set instead of WeakKeyDictionary
2020-05-04 21:59:15 -06:00
meejah
5175a6c6a0
asserts for systemexit
2020-05-04 21:59:15 -06:00
meejah
5071ddf124
add more 'with' statements
2020-05-04 21:59:15 -06:00
meejah
a348d3d507
relying on memory/gc bad
2020-05-04 21:59:15 -06:00
meejah
ca5e1ebe52
look at correct mock-call object
2020-05-04 21:59:15 -06:00
meejah
4b0c730adf
use 'with open' correctly
2020-05-04 21:59:15 -06:00
Sajith Sasidharan
7d063995f5
Update copyright years
2020-05-04 15:35:21 -04:00
Sajith Sasidharan
4ebd6250e3
Document root.Root
2020-05-04 14:20:05 -04:00
Sajith Sasidharan
96449bb99b
Ensure lists before conversion to dict
2020-05-04 14:05:33 -04:00
Sajith Sasidharan
88b369a0c2
Remove unused variables
2020-05-04 11:48:52 -04:00
Sajith Sasidharan
bf0f8a736a
Remove unused imports
2020-05-04 11:48:41 -04:00
Sajith Sasidharan
58a06cb57d
Update test that exercises empty nick and version
2020-05-04 09:45:36 -04:00
Sajith Sasidharan
df9b160a3c
Mark describe server method as static
2020-05-01 17:42:46 -04:00
Sajith Sasidharan
80a26e26b1
Refactor methods that describe server/connection
2020-05-01 17:41:51 -04:00
Sajith Sasidharan
7b4d81fe28
Rename root.Root variables
2020-05-01 17:38:24 -04:00
Sajith Sasidharan
ade7f613b8
Remove unused renderer
2020-05-01 17:07:08 -04:00
Sajith Sasidharan
df188c75df
Wrap footer elements in tags
2020-05-01 16:50:30 -04:00
Sajith Sasidharan
029c99a241
Render introducers table using SlotsSequenceElement
2020-05-01 16:45:34 -04:00
Sajith Sasidharan
1ddf07d59d
Render services table using SlotsSequenceElement
2020-05-01 16:45:04 -04:00
Sajith Sasidharan
0d8eda5e76
Rearrange imports
2020-05-01 16:07:30 -04:00
Sajith Sasidharan
053e614221
Import resource_filename from setuptools
...
Drop the nevow one
2020-05-01 16:07:21 -04:00
Sajith Sasidharan
e9796eb308
Match against root path first
2020-04-30 18:49:05 -04:00
Sajith Sasidharan
cfe4b2925e
Remove an unused method and imports
2020-04-30 18:48:06 -04:00
Sajith Sasidharan
cce6f83054
Remove unused renderers
2020-04-30 18:47:13 -04:00
Sajith Sasidharan
88b7784f39
Use BeautifulSoup in test.test_system.SystemTest.test_filesystem
2020-04-30 15:09:10 -04:00
Sajith Sasidharan
6aebab28a9
Use BeautifulSoup to check rendered document
2020-04-30 10:17:48 -04:00
Sajith Sasidharan
80ba700247
Correct usage of fillSlots
2020-04-29 12:18:39 -04:00
Sajith Sasidharan
e5733b6c90
Remove unused test code
2020-04-28 19:09:00 -04:00
Sajith Sasidharan
98322effe6
Update test to exercise services renderer
2020-04-28 19:07:57 -04:00
Sajith Sasidharan
a885f14c43
Pass now_fn to RootElement
2020-04-28 11:47:18 -04:00
Sajith Sasidharan
8ce1512501
Render import path
2020-04-28 07:57:15 -04:00
Sajith Sasidharan
32e0c779b6
Add version renderer
2020-04-28 07:56:27 -04:00
Sajith Sasidharan
d064f6b2b7
Add "rendered at" renderer
2020-04-28 07:55:10 -04:00
Sajith Sasidharan
ed6970b168
Correct fill slots usage in connection status
2020-04-28 07:52:57 -04:00
Sajith Sasidharan
5d84a25f21
Add introducers row renderer
2020-04-28 07:50:03 -04:00
Sajith Sasidharan
5155befedc
Rewrite total introducers
2020-04-28 07:48:28 -04:00
Sajith Sasidharan
44f16e77cf
Add introducers renderer
2020-04-28 07:47:36 -04:00
Sajith Sasidharan
7ba4b945a4
Use introducers renderer method in root template
2020-04-28 07:43:41 -04:00
Sajith Sasidharan
8d4949f96b
Render total introducers correctly
2020-04-28 07:42:57 -04:00
Sajith Sasidharan
a646c7decd
Fix typo
2020-04-28 07:42:07 -04:00
Sajith Sasidharan
89980a039c
Render total introducers
2020-04-28 07:41:29 -04:00
Sajith Sasidharan
2f53b2a67d
Add connected introducers renderer
2020-04-28 07:17:22 -04:00
Sajith Sasidharan
164218cf57
Update service table renderer
2020-04-28 07:14:35 -04:00
Sajith Sasidharan
907e8ccf6b
Use services renderer method in root template
2020-04-28 07:13:41 -04:00
Sajith Sasidharan
75d41843d7
Use transparent nodes
2020-04-28 04:59:46 -04:00
Sajith Sasidharan
3c4056a947
Replace nevow.static.File with twisted.web.static.File
2020-04-28 04:47:48 -04:00
Sajith Sasidharan
dcea7ea476
Render connected/known storage server status
2020-04-27 17:22:27 -04:00
Sajith Sasidharan
1713076a9d
Render services
2020-04-27 17:19:19 -04:00
Sajith Sasidharan
39d616a971
Render helper furl prefix
2020-04-27 17:11:36 -04:00
Sajith Sasidharan
8b4c7296d7
Move helper state to a separate function
2020-04-27 17:07:09 -04:00
Sajith Sasidharan
332bd75fcc
Render helper description
2020-04-27 17:03:52 -04:00
Sajith Sasidharan
622d156278
Render "connected to helpers" status
2020-04-27 17:01:37 -04:00
Sajith Sasidharan
a4f86181f9
Render introducer description
2020-04-27 16:55:10 -04:00
Sajith Sasidharan
c86d4341c8
Render "connected to introducers" status
2020-04-27 16:52:54 -04:00
Sajith Sasidharan
65b6daf990
Rewrite incident button using twisted tags
2020-04-27 16:44:06 -04:00
Sajith Sasidharan
110528f569
Handle path "/" when rendering root path
2020-04-27 16:44:06 -04:00
Sajith Sasidharan
f34cdb81ad
Create RootElement
2020-04-27 16:44:06 -04:00
Sajith Sasidharan
1c17bb0674
Rewrite welcome page for twisted.web.template
2020-04-27 16:24:50 -04:00
Sajith Sasidharan
e2c6d288bf
Merge pull request #699 from sajith/3294.incident-reporter-to-nevow
...
Remove nevow from allmydata.web.root.IncidentReporter
2020-04-27 10:12:27 -04:00
Sajith Sasidharan
f02501eadf
Update comment on HelperStatus
2020-04-24 10:08:45 -04:00
meejah
c385e958a8
Merge branch 'master' into ticket3252-port-web-directory.remaining.1
2020-04-23 12:24:00 -06:00
Sajith Sasidharan
18d5d3fc49
Wrap rendered nodes in tags
2020-04-22 18:23:43 -04:00
Sajith Sasidharan
65315c4ed0
Render a message when helper isn't running
2020-04-22 17:16:33 -04:00
Sajith Sasidharan
6661b52c33
Reformat helper.xhtml
2020-04-22 17:06:59 -04:00
Sajith Sasidharan
aafe89805d
Document helper stats data format
2020-04-22 17:06:39 -04:00
Sajith Sasidharan
4bc7535d02
Derive HelperStatus from MultiFormatResource
2020-04-22 16:54:11 -04:00
Sajith Sasidharan
d844a8f89f
Use twisted transparent tag to render data
...
This way the test suite will be happy, and we won't have extraneous
`<div>` tags in the rendered page.
2020-04-21 11:53:48 -04:00
Sajith Sasidharan
a0eb00b2cc
Wrap renderer return values in tags
2020-04-21 11:53:48 -04:00
Sajith Sasidharan
1e3ba25cc3
Add some documentation to Statistics page
2020-04-21 11:53:48 -04:00
Sajith Sasidharan
652b3f5bc0
Use twisted.web.template to render Statistics page
2020-04-21 11:53:48 -04:00
Sajith Sasidharan
b3feaae644
Use an inner JSONRequest class with renderJSON
...
Once nevow is removed from web/common.py, we can simplify
renderJSON(), like so:
def renderJSON():
req = Request()
req.args = {"t": ["json"]}
req.fields = {}
return resource.render(req)
But for now we have to live with an inner class that implements the
nevow.inevow.IRequest interface.
2020-04-21 10:29:28 -04:00
Sajith Sasidharan
201c08dbe5
Declare JSON request interface using @implementer
...
"zope.interface.implements(IRequest)" is deprectated in favor of
"@zope.interface.implementer(IRequest)" decorator.
2020-04-20 16:54:51 -04:00
meejah
8df1ed1ba6
link to tickets
2020-04-18 02:49:14 -06:00
meejah
f8a78c996a
URL -> DecodedURL
2020-04-18 02:27:32 -06:00
meejah
73d0151e1b
typo
2020-04-18 01:52:31 -06:00
meejah
349aefeacc
fail() takes a message, not Exception
2020-04-18 01:52:18 -06:00
meejah
018e161f19
don't allow trailing slashes
...
This makes /uri/xxx URIs invalid if they have a trailing slash.
It seems that the former Nevow implementation would allow this, and
some tests (and, notable, "tahoe backup") did rely on using URIs
of this style.
2020-04-18 01:52:18 -06:00
meejah
882c63dab9
methods shouldn't be named like classes
2020-04-18 01:52:18 -06:00
meejah
0acf0d2a7e
no addslash here
2020-04-18 01:52:18 -06:00
meejah
bc2f5f8e88
functions shouldn't be named like classes
2020-04-18 01:52:18 -06:00
meejah
8f35f78194
temporary fix for hypothesis test
2020-04-18 01:52:18 -06:00
meejah
c246b3e049
self.assertEqual not assert
2020-04-18 01:52:18 -06:00
meejah
701915783c
make unpack/pack test use Hypothesis
2020-04-18 01:52:18 -06:00
meejah
6ea6abdb1f
no .format yet
2020-04-18 01:52:18 -06:00
meejah
fc4aec7b77
remove comment
2020-04-18 01:52:18 -06:00
meejah
2e9463bd08
compute 'is this a terminal request' differently
2020-04-18 01:52:18 -06:00
meejah
b0c138f7c0
remove empty segments instead of making multiple URI's valid
2020-04-18 01:52:18 -06:00
meejah
8c47b8e2a1
don't need object
2020-04-18 01:52:18 -06:00
meejah
088fcff442
better formatting
2020-04-18 01:52:18 -06:00
meejah
c6f4f0b7d5
betterize comment
2020-04-18 01:52:18 -06:00
meejah
8db16ff8e3
old-style class
2020-04-18 01:52:18 -06:00
meejah
b64f90bcd4
simplify
2020-04-18 01:52:18 -06:00
meejah
95e5029c34
more comment
2020-04-18 01:52:18 -06:00
meejah
d425baed89
remove irrelevant comment
2020-04-18 01:52:18 -06:00
meejah
3c332fec2a
empty-string, not None
2020-04-18 01:52:18 -06:00
meejah
733b7932ce
clarify further; remove unused user of RenderMixin
2020-04-18 01:52:18 -06:00
meejah
ace99a1724
add clarifying comment
2020-04-18 01:52:18 -06:00
meejah
f9e3fdfaee
use % instead of format
2020-04-18 01:52:18 -06:00
meejah
3d3feec059
encode for fail() / Exception
2020-04-18 01:52:18 -06:00
meejah
d533becc07
native strings only
2020-04-18 01:52:18 -06:00
meejah
ef5e18b6c7
unused
2020-04-18 01:52:18 -06:00
meejah
fdb3399edb
just delete test_welcome
2020-04-18 01:52:18 -06:00