Sajith Sasidharan
6dec821271
Merge pull request #720 from sajith/3288.status-download-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.DownloadStatusPage
Fixes: ticket:3288
2020-07-18 07:22:37 -04:00
Sajith Sasidharan
879a8012a0
Remove unused import
2020-07-18 06:48:36 -04:00
Sajith Sasidharan
c198c006e3
Avoid over-long lines
2020-07-17 21:02:24 -04:00
Sajith Sasidharan
fe07ab39da
Use docstrings
2020-07-17 16:22:23 -04:00
Sajith Sasidharan
c14197e1bc
Make FakeDownloadStatus an instance of DownloadStatus
...
The real DownloadStatus is easy enough to instantiate. Might as well
use that, cutting some crufty code here.
2020-07-17 16:13:07 -04:00
Sajith Sasidharan
293efd7c9f
Use actual status counter number when testing
2020-07-17 13:50:06 -04:00
Sajith Sasidharan
8fd0cf7eb6
Add a test for checking status page links
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
828ec53e24
Update status page test case
...
Link to upload status 0 should contain `/status/` prefix, or it will
navigate to `/up-0` instead of `/status/up-0`, resulting in a 404 not
found message. Same with other statuses too.
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
5c886b1b2d
Format link to status page child node correctly
...
Some Nevow-ism accidentally escaped earlier: link to `/status/up-0`
and so on were actually rendered as `/up-0` and so on.
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
2d19c383ca
Rename a variable for clarity
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
02d8bd061a
Test for trailing slashes after /status/
...
Both `/status` and `/status/` are treated alike; any additional
trailing slashes will be rejected.
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
372cc00a25
Reject non-existent child nodes of /status
...
Requests on both `/status` and `/status/` will be served with the same
status page, but `/status//`, `/status///` and so on will be processed
further down, resulting in a 40x response.
2020-07-17 09:46:21 -04:00
Sajith Sasidharan
fe165cc99d
Do the right thing, not the simple thing
...
Seems that NixOS CI is saying that the simple thing is not the right
thing: "GET /status/down-0" etc all resulted in 404 responses on
NixOS. So we perhaps should use the actual counter value.
2020-07-16 19:07:51 -04:00
Sajith Sasidharan
06c8bbfb19
Use clearer names for tests
2020-07-16 17:25:25 -04:00
Sajith Sasidharan
66dd2d3658
Use docstrings
2020-07-16 17:19:50 -04:00
Sajith Sasidharan
8db60e3486
Do the simple thing when testing status subpaths
2020-07-16 17:16:18 -04:00
Sajith Sasidharan
95642ae02c
Use a helper to check status subpath results
2020-07-16 17:13:36 -04:00
Sajith Sasidharan
e48d930621
Clarify intention of a test case
2020-07-16 16:56:41 -04:00
Sajith Sasidharan
6a2ce9efc6
Use docstrings
2020-07-16 16:55:12 -04:00
Itamar Turner-Trauring
a4620bf176
Automated port of the test module.
2020-07-16 15:58:39 -04:00
Itamar Turner-Trauring
4c047b90e5
Manual steps of port to Python 3.
2020-07-16 15:46:23 -04:00
Itamar Turner-Trauring
e90d1f38d2
Make TimezoneMixin importable on Python 3.
2020-07-16 15:44:41 -04:00
Itamar Turner-Trauring
554be90b7e
Unnecessary code, and was triggering flake8.
2020-07-16 15:27:36 -04:00
Itamar Turner-Trauring
72272cbf0b
Move out tests for time_format.
2020-07-16 15:15:26 -04:00
Itamar Turner-Trauring
545848f164
Move abbreviate tests into their own module.
2020-07-16 14:57:09 -04:00
Itamar Turner-Trauring
4da8e2ddee
Merge branch '3342-base32-and-base62-to-python-3' into 3344.netstring-and-hashutil-to-python-3
2020-07-16 14:42:09 -04:00
Itamar Turner-Trauring
8d143af43e
Another assertion.
2020-07-16 14:40:30 -04:00
Itamar Turner-Trauring
2f693c47f9
Don't leak variable on Python 2.
2020-07-16 14:37:26 -04:00
Itamar Turner-Trauring
efbae9b3e3
Hard code some known values, generated on the master branch preceding these
...
changes.
2020-07-16 14:33:53 -04:00
Itamar Turner-Trauring
7abc54c429
Merge remote-tracking branch 'origin/master' into 3342-base32-and-base62-to-python-3
2020-07-16 14:21:42 -04:00
Jean-Paul Calderone
0ce6e562cb
Merge pull request #742 from chadwhitacre/3325.add-py36-to-ci
...
Add py36 to CI
Fixes: ticket:3325
2020-07-15 20:11:39 -04:00
Jean-Paul Calderone
c493396148
Merge pull request #740 from tahoe-lafs/3340-unused-code-in-util
...
Delete some dead code.
Fixes: ticket:3340
2020-07-15 20:08:41 -04:00
Itamar Turner-Trauring
6af32fdfa7
Make sure the public API exposes native bytes, not Future bytes.
2020-07-15 15:59:46 -04:00
Itamar Turner-Trauring
ed6e1cb7ef
Fix formatting.
2020-07-15 15:51:09 -04:00
Itamar Turner-Trauring
ed8b10c12f
Finish porting to Python 3.
2020-07-15 15:00:29 -04:00
Itamar Turner-Trauring
4800992de6
Type check assertions.
2020-07-15 14:58:58 -04:00
Itamar Turner-Trauring
fa5b5fa436
Manual part of port to Python 3.
2020-07-15 14:55:56 -04:00
Itamar Turner-Trauring
bb7d31c5e4
Futurize part of port to Python 3.
2020-07-15 11:19:57 -04:00
Itamar Turner-Trauring
60a1a24423
Manual portion of port to Python 3.
2020-07-15 11:13:59 -04:00
Itamar Turner-Trauring
e3e29598e4
A couple of missing explicit byte strings.
2020-07-15 11:13:52 -04:00
Itamar Turner-Trauring
cfb11f7f4c
More explicit testing of types.
2020-07-15 11:08:06 -04:00
Itamar Turner-Trauring
093125ca43
Port to Python 3.
2020-07-15 11:05:23 -04:00
Itamar Turner-Trauring
d316ad3ebd
A more explicit test.
2020-07-15 11:02:49 -04:00
Itamar Turner-Trauring
2b89674052
Everything must be bytes.
2020-07-15 11:01:45 -04:00
Itamar Turner-Trauring
9ed91eabb3
Split out hashutil tests into their own module.
2020-07-15 10:58:05 -04:00
Itamar Turner-Trauring
3688291df2
Handy way to run Python 3 tests, until the ratchet is going.
2020-07-14 13:53:26 -04:00
Itamar Turner-Trauring
5fd01523cf
This module is not a thing.
2020-07-14 13:53:13 -04:00
Itamar Turner-Trauring
21a9ffef7a
Not strings.
2020-07-14 13:46:12 -04:00
Itamar Turner-Trauring
a81e859b82
Fix flake error.
2020-07-14 13:44:56 -04:00
Itamar Turner-Trauring
27d8eb47fc
Test improvements.
2020-07-14 13:44:00 -04:00
