Ross Patterson
a8ef046b50
build(news): Fix missing ChangeLog entry
2020-09-24 11:44:38 -07:00
Ross Patterson
430881be15
test(py3): Capture how to run all tests under py3
...
Useful to review common errors under Python 3 as opposed to module-by-module.
2020-09-24 11:37:58 -07:00
Ross Patterson
92de966c91
test(runner): Use checked out source for local tests
...
TL;DR: Capture how to use real source file paths for local development.
It can be useful to run the tests against the currently checked out Python source files.
Changes are reflected immediately. Source file paths in Tracebacks (and other things
that print the file path for Python modules) are to the actual checked out source and
can be copied and pasted or used by tools that expect real paths.
OTOH, testing against a real Python package install into a virtualenv done from a real
source distribution can expose rare but very confusing issues.
So doing both is valuable. Most typically, the former is useful for local development
and the latter is most appropriate in CI.
2020-09-24 11:37:49 -07:00
Ross Patterson
1593ff5c52
test(coverage): Include human-readable coverage report
...
While the XML coverage report is useful for consumption by other tools, such as
currently by codecov.io in CI, it's not very useful for humans reviewing the immediate
impact of changes on coverage during local development or while monitoring CI output. I
don't think running the text report takes much more time so I don't see a downside
here.
2020-09-24 11:37:37 -07:00
Ross Patterson
0c533733f0
test(runner): Match contributor guidelines from wiki
...
The [Patches Trac Wiki page](https://tahoe-lafs.org/trac/tahoe-lafs/wiki/Patches ) says
that users should run the `codechecks` tox environment, so this change runs it be
default as the full tox test suite eliminating the extra step.
2020-09-24 11:36:58 -07:00
Jean-Paul Calderone
1c5f4e2bf0
Compatible with the interface I used in test_web.py
2020-09-24 11:08:18 -04:00
Jean-Paul Calderone
16ab1690de
rewrite _test_introweb part of SystemTest as its own test suite
2020-09-24 11:08:18 -04:00
Jean-Paul Calderone
e981fea007
make FakeCanary more realistic
2020-09-24 11:08:18 -04:00
Itamar Turner-Trauring
4784d2c3a8
News fragment.
2020-09-24 11:06:47 -04:00
Itamar Turner-Trauring
26f28f341f
Finish port to Python 3.
2020-09-24 11:03:42 -04:00
Itamar Turner-Trauring
8167a9fda6
All tests pass on Python 3.
2020-09-24 11:01:35 -04:00
Itamar Turner-Trauring
5cd00d6f2e
And even more tests passing in Python 3.
2020-09-24 10:55:47 -04:00
Itamar Turner-Trauring
37bc022edc
Even more tests passing on Python 3.
2020-09-24 10:46:10 -04:00
Jean-Paul Calderone
f1bcf4eb07
remove unused imports
2020-09-24 10:42:57 -04:00
Itamar Turner-Trauring
d9036e83b2
More tests passing on Python 3.
2020-09-24 10:39:06 -04:00
Itamar Turner-Trauring
e7fe2f0a3f
It imports on Python 3.
2020-09-24 10:32:41 -04:00
Jean-Paul Calderone
67adb9303b
news fragment
2020-09-24 10:23:34 -04:00
Jean-Paul Calderone
e7101b1711
Turn exceptions into error pages like Nevow does
2020-09-24 10:23:05 -04:00
Jean-Paul Calderone
34bade4091
Use the newly introduced helper instead of our own internal thing
2020-09-24 10:22:07 -04:00
Jean-Paul Calderone
ed049da34f
Add a helper that can render a Page or a Resource
2020-09-24 10:21:18 -04:00
Chad Whitacre
06cd64c891
De-lint
2020-09-23 21:41:23 -04:00
Chad Whitacre
3ae927eab9
Respond to review
...
- Preserve int division
- Dial back the __future__ imports
2020-09-23 21:18:24 -04:00
Itamar Turner-Trauring
5a2728fa05
Finish port to Python 3.
2020-09-23 15:56:09 -04:00
Itamar Turner-Trauring
5790ae8ece
Tests pass on Python 3.
2020-09-23 15:53:13 -04:00
Itamar Turner-Trauring
d8c5e8b44f
News file.
2020-09-23 15:39:19 -04:00
Itamar Turner-Trauring
5fbbb5be0f
News file.
2020-09-23 15:21:47 -04:00
Ross Patterson
827cba21a3
Merge branch '3421.makefile-housekeeping'
2020-09-23 11:24:51 -07:00
Ross Patterson
2645675649
build(make): Exclude changelog entry from NEWS
...
This includes only developer-oriented changes.
2020-09-23 10:31:42 -07:00
Sajith Sasidharan
c2e9d6057f
Merge pull request #819 from sajith/3425.return-errorpage-from-root
...
Return ErrorPage from web.root
Fixes ticket:3425
2020-09-23 10:18:44 -04:00
Chad Whitacre
42eaf08a52
Remove duplicate import
2020-09-23 08:32:34 -04:00
Sajith Sasidharan
a413eb8626
Use BeautifulSoup in RenderSlashUri tests
2020-09-23 08:32:19 -04:00
Chad Whitacre
d21046fe9f
A couple more cleanups
...
- attempt the same future imports in both common and common_util
- put an import in a better place
2020-09-23 08:31:08 -04:00
Chad Whitacre
9fccf37053
Make new code more idiomatic
2020-09-23 08:24:39 -04:00
Chad Whitacre
de48dff981
Dial back future imports in common_util.py
...
Don't set the plow too deep.
2020-09-23 08:19:07 -04:00
Sajith Sasidharan
704b36d7e1
Remove test for web.common.getxmlfile()
2020-09-22 21:15:58 -04:00
Sajith Sasidharan
e6a5dda7e1
Rearrange imports
2020-09-22 21:14:00 -04:00
Sajith Sasidharan
22a1721b62
Remove unused web.common.getxmlfile()
2020-09-22 21:05:17 -04:00
Sajith Sasidharan
9aee312d8c
Merge pull request #822 from sajith/3429.return-errorpage-from-check-results
...
Return ErrorPage from web.check_results
Fixes ticket:3429
2020-09-22 20:40:00 -04:00
Sajith Sasidharan
4e4c5f9b7f
Merge pull request #820 from sajith/3424.return-errorpage-from-operations
...
Return ErrorPage from web.operations
Fixes ticket:3424
2020-09-22 20:38:34 -04:00
Sajith Sasidharan
da78bc05d0
Merge pull request #818 from sajith/3423.return-errorpage-from-filenode
...
Return ErrorPage from filenode
Fixes ticket:3423
2020-09-22 20:37:55 -04:00
Sajith Sasidharan
0f118bdd67
Return error page from unlinked
2020-09-22 12:23:40 -04:00
Chad Whitacre
0b6b4b69e9
Port test_immutable to Python 3
2020-09-22 08:36:39 -04:00
Sajith Sasidharan
6d9e1a7a47
Merge pull request #821 from sajith/3426.return-errorpage-from-status
...
3426 Return ErrorPage from web.status
Fixes ticket:3426
2020-09-22 08:32:16 -04:00
Sajith Sasidharan
136a70217c
Remove unused import
2020-09-21 20:44:49 -04:00
Sajith Sasidharan
fd5436b867
Expect ErrorPage in RenderSlashUri tests
2020-09-21 18:34:53 -04:00
Sajith Sasidharan
18e56e41fc
Return error page when an exception is raised from web.check_results
2020-09-21 18:18:29 -04:00
Sajith Sasidharan
20101f8146
Return ErrorPage when an exception is raised in web.status
2020-09-21 16:51:27 -04:00
Sajith Sasidharan
c16cf00c6b
Return an error page when an exception is raised from web.root
2020-09-21 16:37:36 -04:00
Sajith Sasidharan
e8f7643a8f
Return ErrorPage when web.operations raises an exception
2020-09-21 16:26:51 -04:00
Sajith Sasidharan
c34dc78875
Merge 'origin/master' into 3423.return-errorpage-from-filenode
2020-09-21 16:22:57 -04:00
