Commit Graph

4097 Commits

Author SHA1 Message Date
Jason R. Coombs
c673726139 Alongside unicode_to_argv, declare the argv type to avoid errors on Windows now that args are actually unicode. 2021-03-06 15:37:29 -05:00
Jason R. Coombs
0838133006 Merge branch 'master' into 3603.scripts 2021-03-06 10:43:01 -05:00
Itamar Turner-Trauring
d6fc3c078e Port to Python 3. 2021-03-05 10:26:38 -05:00
Itamar Turner-Trauring
a29c03d34b Port to Python 3. 2021-03-04 11:02:36 -05:00
Itamar Turner-Trauring
cf418b753a All tests pass on Python 3. 2021-03-04 10:55:08 -05:00
Itamar Turner-Trauring
2c3353f2fa More tests passing on Python 3. 2021-03-03 14:42:55 -05:00
Itamar Turner-Trauring
5ec52f9885 More passing tests on Python 3. 2021-03-03 14:14:55 -05:00
Itamar Turner-Trauring
58149afeb9 Merge branch '3618.bb-tests-python-3' into 3625.client-python-3 2021-03-03 10:51:15 -05:00
Itamar Turner-Trauring
996a564c05 Private key should be bytes. 2021-03-03 10:50:44 -05:00
Itamar Turner-Trauring
6fc44f7a31 get_name() should always return bytes, apparently. 2021-03-01 10:53:25 -05:00
Itamar Turner-Trauring
9d13e82db7 Fix flake. 2021-02-24 14:44:29 -05:00
Itamar Turner-Trauring
70c0607789 Enable BytesWarning across all tests ported to Python 3, fixing problems that caught. 2021-02-24 14:36:15 -05:00
Jason R. Coombs
4cb8c420d3 Manually reviewed test_runner (no legacy map, filter, or keys found). Added docstring to tag module as fully ported. 2021-02-15 12:49:20 -05:00
Jason R. Coombs
746e1b2664 Fix test failures on Python 2 by wrapping cli calls in unicode_to_argv. 2021-02-15 12:47:26 -05:00
Jason R. Coombs
d59d64d6bd Fully port test_runner. Introduces three new errors on Python 2. 2021-02-15 12:38:37 -05:00
Itamar Turner-Trauring
5b4428b968 Merge remote-tracking branch 'origin/master' into 3611.web-python-3-part-2 2021-02-15 11:38:30 -05:00
Itamar Turner-Trauring
06cd015647 Merge remote-tracking branch 'origin/master' into 3606.test_system-web-python3 2021-02-15 11:14:41 -05:00
Itamar Turner-Trauring
e41ff1a17d
Merge pull request #979 from tahoe-lafs/3607.web-python-3-part-1
Port allmydata.web.common to Python 3

Fixes ticket:3607
2021-02-15 11:13:34 -05:00
Jason R. Coombs
30f5c71a49 Encode expected message. Fixes remaining test failures in test_runner. 2021-02-15 09:36:07 -05:00
Jason R. Coombs
f183be9d6a Decode config file on read and expect bytes in the stdout. Fixes an additional test on Python 3. 2021-02-15 09:33:54 -05:00
Jason R. Coombs
3acad6544e Decode config file on read and expect bytes in the stdout. Fixes an additional test on Python 3. 2021-02-15 09:28:14 -05:00
Jason R. Coombs
dc883c0440 Decode config file on read. Fixes two test failures on Python 3. 2021-02-15 09:24:16 -05:00
Jason R. Coombs
eefb7004c9 Add test_runner to the ported test modules. Selectively decode sys.argv on Python 2 only. Fixes 6 test failures on Python 3. 2021-02-15 09:20:45 -05:00
Jean-Paul Calderone
11e1fabbe4 Change the platform check to one mypy can recognize :/ 2021-02-12 13:10:31 -05:00
Jean-Paul Calderone
8ffb083d38 Merge remote-tracking branch 'origin/master' into 3581.unicode_to_argv.1 2021-02-12 13:08:51 -05:00
Itamar Turner-Trauring
42c4bac845 Fix test failure. 2021-02-12 12:01:43 -05:00
Itamar Turner-Trauring
c5a426b797 More unicode-of-bytes fixes. 2021-02-12 11:47:11 -05:00
Itamar Turner-Trauring
5561f9fa16 Merge remote-tracking branch 'origin/master' into 3607.web-python-3-part-1 2021-02-12 11:22:34 -05:00
Itamar Turner-Trauring
681572b1a5 Merge remote-tracking branch 'origin/3606.test_system-web-python3' into 3611.web-python-3-part-2 2021-02-12 10:30:51 -05:00
Jean-Paul Calderone
585c554081 Clarify _TwoLoggers 2021-02-12 10:22:17 -05:00
Jean-Paul Calderone
9a9b4bb232 Use a monkey patching library for monkey patching 2021-02-12 10:14:23 -05:00
Jean-Paul Calderone
ff25ee3f71 Merge remote-tracking branch 'origin/master' into 3600.eliotutil-vs-skips 2021-02-12 10:07:44 -05:00
Jean-Paul Calderone
9ad4d31d9d
Merge pull request #968 from LeastAuthority/3592.convergence-hasher-tag-tests
convergence hasher tag tests

Fixes: ticket:3592
2021-02-11 16:25:41 -05:00
Jean-Paul Calderone
a8b1c204d2 Mark the expected result literal as the correct type, bytes 2021-02-11 16:06:18 -05:00
Itamar Turner-Trauring
eebeca31f5 Fix some more unicode()-of-bytestring bugs. 2021-02-11 13:11:34 -05:00
Itamar Turner-Trauring
05a85b0ce2 Fix some unicode(bytes_object) bugs. 2021-02-11 12:53:48 -05:00
Itamar Turner-Trauring
3abbe76d6a Merge branch '3607.web-python-3-part-1' into 3611.web-python-3-part-2 2021-02-10 14:33:00 -05:00
Itamar Turner-Trauring
166c1a537e Fix Python 3 failure. 2021-02-10 14:26:23 -05:00
Itamar Turner-Trauring
3fd90640f3 Merge remote-tracking branch 'origin/master' into 3606.test_system-web-python3 2021-02-10 14:23:53 -05:00
Itamar Turner-Trauring
e5806301d3
Merge pull request #976 from tahoe-lafs/3596.test-web-python-3-even-more
Port test_web.py to Python 3

Fixes ticket:3596
2021-02-10 14:21:22 -05:00
Itamar Turner-Trauring
d237dcab15 Restore test coverage. 2021-02-10 14:06:42 -05:00
Jean-Paul Calderone
3beacc9c8f Merge remote-tracking branch 'origin/master' into 3581.unicode_to_argv.1 2021-02-09 21:18:58 -05:00
Jean-Paul Calderone
845e33061e
Merge pull request #964 from LeastAuthority/3588.use-pywin32-more
Use pywin32 more

Fixes: ticket:3588
2021-02-09 21:15:34 -05:00
Jean-Paul Calderone
28acc5ccb4 Duplicate the fix for the other Windows-only module 2021-02-09 14:50:29 -05:00
Jean-Paul Calderone
27fcfe94dd The code is 3-clause BSD licensed now. 2021-02-09 10:24:46 -05:00
Jean-Paul Calderone
ab57746a85
Merge pull request #969 from LeastAuthority/3593.get_encryption_key-test
Add FileHandle.get_encryption_key test

Fixes: ticket:3593
2021-02-07 07:41:44 -05:00
Itamar Turner-Trauring
8fdbb6db6e Nail down types. 2021-02-04 11:22:48 -05:00
Itamar Turner-Trauring
6b38c8d1c9 More of test_system now passes on Python 3. 2021-02-03 11:24:47 -05:00
Itamar Turner-Trauring
2595e25258 Improve coverage, specifically of values that are bytes. 2021-02-03 10:16:34 -05:00
Itamar Turner-Trauring
a1add9a512 Clarify. 2021-02-03 10:13:19 -05:00
Itamar Turner-Trauring
0b57fb9df1 Merge remote-tracking branch 'origin/master' into 3596.test-web-python-3-even-more 2021-02-02 15:28:49 -05:00
Itamar Turner-Trauring
51bd4b719c Fix lint. 2021-02-02 15:28:12 -05:00
Itamar Turner-Trauring
fa3bef5b25 Port to Python 3. 2021-02-02 15:27:15 -05:00
Itamar Turner-Trauring
489b9f87b3 All tests pass on Python 3. 2021-02-02 15:14:44 -05:00
Itamar Turner-Trauring
26560a4212 More passing tests on Python 3. 2021-02-02 14:25:01 -05:00
Itamar Turner-Trauring
abf6413a89 More passing tests on Python 3. 2021-02-01 11:50:33 -05:00
Itamar Turner-Trauring
73537351a7 More passing tests on Python 3. 2021-02-01 11:05:36 -05:00
Itamar Turner-Trauring
438933ec8d Fix tests on Python 2. 2021-02-01 11:02:00 -05:00
Itamar Turner-Trauring
20c04f4ddb Make sure it's non-UTF-8-encodable bytes, just to make sure it's roundtripping correctly. 2021-02-01 10:46:08 -05:00
Itamar Turner-Trauring
6fd62eb25e Merge remote-tracking branch 'origin/master' into 3579.ftp-python-3 2021-01-28 15:15:57 -05:00
Jean-Paul Calderone
81edda8011 ... this? 2021-01-28 15:11:13 -05:00
Itamar Turner-Trauring
90a47bb859 WIP 2021-01-28 12:00:15 -05:00
Itamar Turner-Trauring
e5a7ea97c7 More tests passing on Python 3. 2021-01-28 11:44:16 -05:00
Itamar Turner-Trauring
2007323baa More passing tests on Python 3. 2021-01-28 11:19:09 -05:00
Itamar Turner-Trauring
6668842356 More passing tests on Python 3. 2021-01-27 15:43:44 -05:00
Itamar Turner-Trauring
ea10c7c937 More passing tests on Python 3. 2021-01-27 15:20:38 -05:00
Itamar Turner-Trauring
175a3ca4bb More passing tests on Python 3. 2021-01-27 12:45:36 -05:00
Itamar Turner-Trauring
4f56ce436a More passing tests on Python 3. 2021-01-27 12:39:28 -05:00
Itamar Turner-Trauring
c1391159fa More passing tests on Python 3. 2021-01-27 12:06:25 -05:00
Jean-Paul Calderone
64f3e1277e Replace eliot_logged_test with something ... else
The previous implementation relied on TestCase.addCleanup in an unreliable
way.

This implementation pushes the decoration logic in to the test method itself
on the premise that test methods that do weird stuff are better supported than
`run` methods that do weird stuff.

Also add some more tests for this behavior.
2021-01-27 11:33:09 -05:00
Itamar Turner-Trauring
9f5e1381bf Another passing Python 3 test. 2021-01-27 11:29:46 -05:00
Itamar Turner-Trauring
5a2339ced3 Another test passing on Python 3. 2021-01-26 11:09:19 -05:00
Itamar Turner-Trauring
8493d70cab Support byte keys in internal dictionaries. 2021-01-26 11:01:50 -05:00
Itamar Turner-Trauring
e271cd1b64 Another test passing on Python 3. 2021-01-26 10:20:15 -05:00
Jean-Paul Calderone
bb8348f7bb Merge remote-tracking branch 'origin/master' into 3588.use-pywin32-more 2021-01-26 09:54:59 -05:00
Jean-Paul Calderone
15dbbce217 Merge remote-tracking branch 'origin/master' into 3592.convergence-hasher-tag-tests 2021-01-26 09:53:26 -05:00
Itamar Turner-Trauring
dc3871b711
Merge pull request #970 from tahoe-lafs/3590.error-in-integration-test
Fix URI redirect error that was manifesting in the integration tests

Fixes ticket:3590
2021-01-26 09:50:40 -05:00
Jean-Paul Calderone
25b453047c Merge remote-tracking branch 'origin/master' into 3593.get_encryption_key-test 2021-01-25 11:12:59 -05:00
Itamar Turner-Trauring
58745fd373 More passing Python 3 tests. 2021-01-25 10:32:28 -05:00
Itamar Turner-Trauring
59847edf9c More Python 3 fixes. 2021-01-25 10:06:05 -05:00
Itamar Turner-Trauring
b6788c4439 More Python 3 fixes. 2021-01-25 09:55:55 -05:00
Itamar Turner-Trauring
3eb62f1d0f More passing tests on Python 3. 2021-01-25 09:25:20 -05:00
Jean-Paul Calderone
e5f0dcfbb4
Merge pull request #971 from LeastAuthority/3594.read_encrypted-test
Directly test read_encrypted behavior and remove a `fireEventually` from its implementation

Fixes: ticket:3594
Fixes: ticket:3595
2021-01-25 09:14:35 -05:00
Itamar Turner-Trauring
4c5ea34af6 More passing tests on Python 3. 2021-01-22 15:07:03 -05:00
Itamar Turner-Trauring
4e15b37062 Bit more progress on Python 3. 2021-01-22 11:59:26 -05:00
Itamar Turner-Trauring
27a5211385 More passing tests on Python 3. 2021-01-22 11:37:37 -05:00
Itamar Turner-Trauring
011b027c39 More passing tests on Python 3. 2021-01-22 10:14:28 -05:00
Itamar Turner-Trauring
755de5edaf Start of passing tests on Python 3. 2021-01-22 09:58:51 -05:00
Itamar Turner-Trauring
23e52b1237 Simplify the unit test. 2021-01-21 09:58:58 -05:00
Jean-Paul Calderone
12087738d6 Switch from fireEventually to until 2021-01-20 13:54:37 -05:00
Jean-Paul Calderone
932481ad47 A helper for doing something repeatedly for a while 2021-01-20 12:58:03 -05:00
Jean-Paul Calderone
8be3678cb4 Directly test read_encrypted behavior 2021-01-20 11:22:22 -05:00
Itamar Turner-Trauring
e91d37e64b Fix unit test so it's actually testing the real bug. 2021-01-19 17:13:52 -05:00
Jean-Paul Calderone
11e4bcf476 Add a direct unit test for FileHandle.get_encryption_key 2021-01-19 14:41:58 -05:00
Jean-Paul Calderone
61d5f920bb Add tests for the tag construction code and make it a bit safer
Check for sane inputs, reject insane ones
2021-01-19 14:28:16 -05:00
Itamar Turner-Trauring
3166545509 Unit test reproducing the bug in the integration test. 2021-01-19 13:52:12 -05:00
Itamar Turner-Trauring
2de76cd82d
Merge branch 'master' into 3589.more-web-tests-python-3 2021-01-19 11:44:27 -05:00
Jason R. Coombs
7d468cde19 Merge branch 'master' into 3399.mypy 2021-01-15 11:17:47 -05:00
Itamar Turner-Trauring
c5669e16e0 Fix flake. 2021-01-13 09:56:08 -05:00
Jean-Paul Calderone
216efb2aed unused import 2021-01-12 16:52:43 -05:00
Jean-Paul Calderone
43dc85501f is this api less troublesome? 2021-01-12 16:03:28 -05:00
Jean-Paul Calderone
6984f2be3f Try to get the Python 2 / Windows case working 2021-01-12 15:58:07 -05:00
Jean-Paul Calderone
6c430bd4e6 re-add a direct unicode_to_argv test
harder to express the conditional in skips so the two tests become one
2021-01-12 15:16:18 -05:00
Jean-Paul Calderone
9c63703efc no effort being made to support these locales 2021-01-12 15:15:42 -05:00
Jean-Paul Calderone
44d76cb159 fix formatting mistake 2021-01-12 15:00:02 -05:00
Jean-Paul Calderone
5a145e74ef a mild warning/suggestion here 2021-01-12 14:59:16 -05:00
Itamar Turner-Trauring
5d77282784 Ported to Python 3. 2021-01-12 14:40:33 -05:00
Itamar Turner-Trauring
7a3e9ab43e Tests pass on Python 3. 2021-01-12 14:39:20 -05:00
Itamar Turner-Trauring
03fb936716 Port to Python 3. 2021-01-12 14:25:16 -05:00
Itamar Turner-Trauring
4940da47da Tests pass on Python 3. 2021-01-12 14:24:17 -05:00
Itamar Turner-Trauring
8c41f60fdb Port to Python 3. 2021-01-12 14:17:38 -05:00
Itamar Turner-Trauring
bd364feec5 Tests pass on Python 3. 2021-01-12 14:14:52 -05:00
Jean-Paul Calderone
aa4f113027 Get the monkey patching right 2021-01-12 14:11:43 -05:00
Itamar Turner-Trauring
c2d69c5309 Merge all log tests into one test module. 2021-01-12 11:41:19 -05:00
Itamar Turner-Trauring
116c59142d Port to Python 3. 2021-01-12 11:26:43 -05:00
Jean-Paul Calderone
8f498437cf whitespace 2021-01-12 10:11:23 -05:00
Jean-Paul Calderone
ae1a0c591b Prefer to fix unicode_to_argv/argv_to_unicode instead of callers 2021-01-12 09:58:34 -05:00
Jean-Paul Calderone
70d2fd6672 Don't have a Latin-1 io_encoding
It's bad
2021-01-11 19:31:22 -05:00
Jean-Paul Calderone
60a44b99e6 improve fixtures 2021-01-11 19:30:15 -05:00
Jean-Paul Calderone
23c34004a7 Get rid of tests for bad io_encoding values
We don't like bad io_encoding values
2021-01-11 19:29:49 -05:00
Jean-Paul Calderone
3d02545006 Remove tests based on locale behavior
We don't like locale behavior
2021-01-11 19:29:15 -05:00
Jean-Paul Calderone
de9bcc7ea8 encode Popen argv as UTF-8 on POSIX so we ignore locale 2021-01-11 19:21:20 -05:00
Jean-Paul Calderone
b8abec6073 Get rid of the Latin-1 case
Here's a supposition: UTF-8 or bust
2021-01-11 16:00:48 -05:00
Jean-Paul Calderone
2306819db1 Get rid of unicode_to_argv and argv_to_unicode 2021-01-11 15:45:39 -05:00
Jean-Paul Calderone
5df86b4608 restore test_with_python_options now that I see what it's testing 2021-01-11 15:26:12 -05:00
Jean-Paul Calderone
834abfe6bf _win_subprocess didn't actually export this 2021-01-11 15:09:25 -05:00
Jean-Paul Calderone
c6d108ddb2 Make test_runner and test_windows both use the good Popen 2021-01-11 15:07:37 -05:00
Jean-Paul Calderone
73110f48da Banish getProcessOutputAndValue from test_runner
It cannot do the right thing on Windows for non-ASCII because Twisted uses
pywin32 and on Python 2 pywin32 binds CreateProcessA.
2021-01-11 14:56:46 -05:00
Jean-Paul Calderone
41d7548527 typo 2021-01-11 14:16:02 -05:00
Jean-Paul Calderone
a4c520ec2a try to go faster without losing coverage 2021-01-11 14:11:28 -05:00
Itamar Turner-Trauring
1b1d87f9f9 Merge branch '3584.integration-tests-sftp' into 3579.ftp-python-3 2021-01-11 14:05:07 -05:00
Jean-Paul Calderone
a29b061f91 explain the nested import 2021-01-11 14:04:20 -05:00
Itamar Turner-Trauring
4a7da34a6a
Merge pull request #958 from tahoe-lafs/3583.rip-out-ftp
Rip out FTP support

Fixes ticket:3583
2021-01-11 13:54:00 -05:00
Jean-Paul Calderone
f61103aa80 spell the module name right 2021-01-11 13:22:14 -05:00
Jean-Paul Calderone
f5bcd272b8 skip the other test suite too 2021-01-11 12:58:27 -05:00
Jean-Paul Calderone
6de392fd23 blacklist a couple more 2021-01-11 12:43:30 -05:00
Jean-Paul Calderone
fd223136db Avoid breaking non-Windows with test_windows 2021-01-11 12:42:52 -05:00
Jean-Paul Calderone
1751d682a2 is this cool? 2021-01-11 11:46:40 -05:00
Jean-Paul Calderone
112bfaf625 we would like this to be utf-8 corresponding to the inputs 2021-01-11 11:42:27 -05:00
Jean-Paul Calderone
3adfb2a108 let it be slow 2021-01-11 11:17:57 -05:00
Jean-Paul Calderone
23d1d76242 get the name 2021-01-11 11:16:23 -05:00
Jean-Paul Calderone
8fa1b6bb1e make stdout/stderr available 2021-01-11 11:15:47 -05:00
Jean-Paul Calderone
504b2f5b1f get the syntax right 2021-01-11 11:15:20 -05:00
Jean-Paul Calderone
221f1640a5 make the container 2021-01-11 11:14:32 -05:00
Jean-Paul Calderone
08d56c87b4 that was silly 2021-01-11 11:13:45 -05:00
Jean-Paul Calderone
a0aa3fe296 try testing UnicodeOutput 2021-01-11 11:12:12 -05:00
Jean-Paul Calderone
6d499dea53 exclude nul from the tested argv values 2021-01-11 10:31:37 -05:00
Jean-Paul Calderone
c2e8d94a73 don't fail this test because it is slow 2021-01-11 10:24:25 -05:00
Jean-Paul Calderone
389d70a682 see if GetCommandLine() value is interesting 2021-01-11 10:17:02 -05:00
Jean-Paul Calderone
e2f3964451 okay this is indeed the expected 2021-01-11 10:09:54 -05:00