Commit Graph

774 Commits

Author SHA1 Message Date
Itamar Turner-Trauring
b1b70cc61c Tests pass on Python 3. 2021-03-23 10:02:01 -04:00
Itamar Turner-Trauring
e091d4d0aa Body should be bytes. 2021-03-18 13:29:56 -04:00
Itamar Turner-Trauring
f9d0116283 Fix typo. 2021-03-18 13:29:50 -04:00
Itamar Turner-Trauring
2f25950944 All tests pass on Python 3. 2021-03-18 11:00:49 -04:00
Itamar Turner-Trauring
b7d6b97f63 Some progress towards passing tests on Python 3. 2021-03-18 10:42:15 -04:00
Itamar Turner-Trauring
34f1f43e95 Revert changes to tahoe_backup/test_backup for now. 2021-03-18 10:33:10 -04:00
Jean-Paul Calderone
0464e9f5ab Merge remote-tracking branch 'origin/master' into 3638.mypy-vs-allmydata-scripts 2021-03-17 21:23:28 -04:00
Itamar Turner-Trauring
56efe7ae48 Merge branch '3603.scripts' into 3634.cli-tests-python-3 2021-03-17 15:33:18 -04:00
Itamar Turner-Trauring
2eba96de61 Address review comments. 2021-03-17 15:29:00 -04:00
Jean-Paul Calderone
b879314194 Make these byte strings explicitly byte strings 2021-03-17 15:21:22 -04:00
Jean-Paul Calderone
84cc7c5b84 Tell mypy about the types of optFlags and optParameters 2021-03-17 15:21:16 -04:00
Jean-Paul Calderone
6955154824 Allow SubCommands to be defined with any Options 2021-03-17 15:17:19 -04:00
Itamar Turner-Trauring
44374487c7 Some progress towards passing tests on Python 3. 2021-03-15 10:37:03 -04:00
Itamar Turner-Trauring
4d80177b18 Merge branch '3603.scripts' into 3634.cli-tests-python-3 2021-03-15 10:36:56 -04:00
Itamar Turner-Trauring
f147669071 Tests pass on Python 3. 2021-03-15 09:44:36 -04:00
Itamar Turner-Trauring
425313457b Make sure we're not doing "%s" % (bytes_). 2021-03-15 09:41:56 -04:00
Jason R. Coombs
0838133006 Merge branch 'master' into 3603.scripts 2021-03-06 10:43:01 -05:00
Itamar Turner-Trauring
70c0607789 Enable BytesWarning across all tests ported to Python 3, fixing problems that caught. 2021-02-24 14:36:15 -05:00
Jason R. Coombs
939988a042 Add workaround for compatibility on Python 2 where test.cli.test_create_alias expects the URL to be a byte string, broken in d02334bfd5. 2021-02-15 15:13:56 -05:00
Jason R. Coombs
d02334bfd5 Rely on futurize to expose the moved modules. 2021-02-15 14:13:59 -05:00
Jason R. Coombs
09f3e3f6b5 Remove comment, superseded by docstring. 2021-02-15 13:26:20 -05:00
Jason R. Coombs
0de90fda3f Merge commit '2fb603e60' into 3603.scripts 2021-02-15 13:10:35 -05:00
Jason R. Coombs
2fb603e603 Rewrite doctest to pass on Python 2+3. 2021-02-15 13:10:21 -05:00
Jason R. Coombs
ebbe645cb6 Use explicit unicode literal for docstring. Now test passes on Python 2 when ALLOW_BYTES is indicated. 2021-02-15 13:06:42 -05:00
Jason R. Coombs
3c93605ead Add docstring to types_. 2021-02-15 12:15:41 -05:00
Itamar Turner-Trauring
06cd015647 Merge remote-tracking branch 'origin/master' into 3606.test_system-web-python3 2021-02-15 11:14:41 -05:00
Jason R. Coombs
df137cca0a Merge branch 'master' into 3603.scripts 2021-02-12 16:08:31 -05:00
Jean-Paul Calderone
3beacc9c8f Merge remote-tracking branch 'origin/master' into 3581.unicode_to_argv.1 2021-02-09 21:18:58 -05:00
Itamar Turner-Trauring
6b38c8d1c9 More of test_system now passes on Python 3. 2021-02-03 11:24:47 -05:00
Jason R. Coombs
621ae58abe Avoid overthinking encoding when handling usage errors. 'test_unicode_arguments_and_output' still passes on Python 2. Ref #3603. 2021-01-31 11:13:59 -05:00
Jason R. Coombs
57cb88638a In scripts.create_node, set the encoding once and write text. 2021-01-30 12:46:44 -05:00
Jason R. Coombs
d6082d853a Declare scripts.create_node as ported. 2021-01-30 12:23:16 -05:00
Jason R. Coombs
36b7fdaecf Apply futurize to create_node. 2021-01-30 12:15:36 -05:00
Jason R. Coombs
5fc9674d3a Update escape_path for Python 3 compatibility. 2021-01-30 11:47:53 -05:00
Jason R. Coombs
210eb5b529 Add test for escape_path. 2021-01-30 11:44:36 -05:00
Jason R. Coombs
5bf2b09b81 In scripts.runner, replace hard failure on Python 3 with 'experimental' warning. Ref #3603. Closes #3035. 2021-01-30 11:12:01 -05:00
Jason R. Coombs
00e856fed5 Declare scripts.types_ as ported (never had Python 2 support). 2021-01-30 11:00:19 -05:00
Jason R. Coombs
7d468cde19 Merge branch 'master' into 3399.mypy 2021-01-15 11:17:47 -05:00
Jean-Paul Calderone
622d67c9b9 done with this, thanks 2021-01-12 14:55:40 -05:00
Jean-Paul Calderone
183ee10035 probably more useful debug info 2021-01-12 14:39:56 -05:00
Jean-Paul Calderone
ec92f0362d this? 2021-01-12 14:36:42 -05:00
Jean-Paul Calderone
7ca3c86a35 debug nonsense 2021-01-12 14:35:03 -05:00
Jean-Paul Calderone
ae1a0c591b Prefer to fix unicode_to_argv/argv_to_unicode instead of callers 2021-01-12 09:58:34 -05:00
Jean-Paul Calderone
ec6c036f87 less cheesy list collision fix 2021-01-11 16:14:34 -05:00
Jean-Paul Calderone
260706d330 Fix the collision with the builtin list 2021-01-11 16:00:42 -05:00
Jean-Paul Calderone
2306819db1 Get rid of unicode_to_argv and argv_to_unicode 2021-01-11 15:45:39 -05:00
Jason R. Coombs
574613a892 Merge branch 'master' into 3399.mypy 2020-12-26 12:45:09 -05:00
Itamar Turner-Trauring
c25dd57768 Make sure we can handle bytes, plus a couple other fixes. 2020-12-21 13:12:01 -05:00
Jason R. Coombs
602a06e5cb Extract Parameters type in scripts.types_. 2020-12-18 11:14:07 -05:00
Jean-Paul Calderone
035cd8b4ac Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 15:35:42 -05:00
Jean-Paul Calderone
7638064818 Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 09:32:33 -05:00
Jean-Paul Calderone
b58b07a9d7 Fold run_common into tahoe_run since there are no other run-like commands anymore 2020-12-12 18:26:22 -05:00
Jean-Paul Calderone
39631a90bf we always use --nodaemon 2020-12-12 18:23:01 -05:00
Jean-Paul Calderone
25c98d7421 don't shadow the global 2020-12-12 18:21:35 -05:00
Jean-Paul Calderone
692285ada3 key-generator was removed 2020-12-12 18:21:16 -05:00
Jean-Paul Calderone
ed2152e2c8 We don't need to check this condition. We're always running. 2020-12-12 18:20:26 -05:00
Jean-Paul Calderone
d8da612055 Move the --nodaemon logic out of tahoe_run
We're always going to --nodaemon from now on
2020-12-12 18:20:09 -05:00
Jean-Paul Calderone
f17a5dfafc key-generator was apparently removed long ago 2020-12-12 17:40:13 -05:00
Jean-Paul Calderone
9a8f72202d Check for these exceptions and report them better 2020-12-11 11:23:10 -05:00
Jean-Paul Calderone
624916e06b
Merge branch 'master' into 3550.remove-start-stop-restart-daemonize 2020-12-10 19:47:47 -05:00
Jean-Paul Calderone
1c7c228f90 Merge remote-tracking branch 'origin/master' into 3549.remove-stats-gatherer 2020-12-10 18:27:54 -05:00
Jean-Paul Calderone
6f80862ec5 Slightly clean up formatting implementation 2020-12-10 07:19:27 -05:00
Jean-Paul Calderone
d0c22a529e json.dumps output should always be ascii 2020-12-10 07:16:00 -05:00
Jean-Paul Calderone
ca92fa4eb5 Don't think about "tahoe start" 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
4d28b0ec27 Get rid of "tahoe start", "tahoe daemonize", "tahoe stop", "tahoe restart" 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
a34fca8e7a Don't think about "tahoe start" 2020-12-09 10:51:10 -05:00
Jean-Paul Calderone
9a27254afa unused import 2020-12-09 10:39:03 -05:00
Jean-Paul Calderone
d7ec5a19be Don't implement the stats gatherer or support configuring or talking to one 2020-12-09 10:34:16 -05:00
Jean-Paul Calderone
1a77ba5698 remove redundant u prefix 2020-12-07 10:37:25 -05:00
Jean-Paul Calderone
d6d64f6b27 fix the json case 2020-12-07 10:37:22 -05:00
Jean-Paul Calderone
87e808b392 one more switch 2020-12-07 10:18:05 -05:00
Jean-Paul Calderone
c7358e6639 Switch over to the helper in the two functions that matter for this PR 2020-12-07 10:16:48 -05:00
Jean-Paul Calderone
a8e3424ef6 remove another unrelated change that's no longer required 2020-12-07 09:55:27 -05:00
Jean-Paul Calderone
d2664121b9 backout no-longer required unrelated change 2020-12-07 09:51:34 -05:00
Jean-Paul Calderone
c12b082fa7 Put run_cli back largely how it was
Also deal with StringIO better in show_output
2020-12-06 20:37:28 -05:00
Jean-Paul Calderone
613777d166 Make sure this one is bytes too 2020-12-06 19:23:13 -05:00
Jean-Paul Calderone
5aee8b422d Oops there's another case 2020-12-06 18:39:09 -05:00
Jean-Paul Calderone
77bebb9916 [wip] remove mock from test_alias, along with a bunch of encoding-related changes :/ 2020-12-06 17:00:34 -05:00
Jean-Paul Calderone
d29210a140 unused import 2020-12-06 11:04:05 -05:00
Jean-Paul Calderone
238590d7fd Remove mock by removing a bunch of unicode shenanigans 2020-12-06 11:03:44 -05:00
Jean-Paul Calderone
ac7491680b fix unicode/bytes stuff in the affected tests 2020-12-05 09:06:45 -05:00
Jean-Paul Calderone
a0d46c6f09 Merge remote-tracking branch 'origin/master' into 3504.private-introducer-furl 2020-12-02 09:22:09 -05:00
Jason R. Coombs
572d7b2e02 Ignore error when untyped Module has no dispatch. 2020-11-29 15:52:04 -05:00
Jason R. Coombs
acbb6b3e93 Convert subcommands to tuples instead of lists, as that's what mypy demands for heterogeneous sequences. 2020-11-29 15:48:26 -05:00
Jason R. Coombs
6b772e7fdc Declare type for BaseOptions.description_unwrapped. 2020-11-29 15:22:58 -05:00
Jason R. Coombs
cb351607d8 Repeat type declaration from parent to avoid over-constraining this type for subclasses. 2020-11-29 15:21:25 -05:00
Jason R. Coombs
af172f6bff Repeat type declaration from parent to avoid over-constraining this type for subclasses. 2020-11-29 14:55:13 -05:00
Jason R. Coombs
1b92da75fa Some subclasses use ints, so just go for Any 2020-11-29 14:44:17 -05:00
Jason R. Coombs
e0eb63929a Declare type for BaseOptions.description. Fixes many type errors. 2020-11-29 14:35:17 -05:00
Jason R. Coombs
1248d65778 Declare types for BasedirOptions. Fixes several errors. 2020-11-29 14:32:34 -05:00
Jean-Paul Calderone
84088e4f41 unused import 2020-11-26 21:18:58 -05:00
Jean-Paul Calderone
805378ef11 Do more path stuff with FilePath 2020-11-26 20:53:57 -05:00
Jean-Paul Calderone
c694e8c7e2 Delete allmydata.version_checks and related functionality
It is not Tahoe-LAFS' job to manage package installation in this way.
Instead, we can declare our dependencies in setup.py and rely on installation
management tools and packagers to create a suitable execution environment.

Making this statement in the past required going much further out on a limb
than it does today.  This code has served its purpose and can now be retired.
2020-11-23 15:10:18 -05:00
Jean-Paul Calderone
2ee0b1d3c6 flake cleanup 2020-11-16 15:05:04 -05:00
Jean-Paul Calderone
5cb1df06c4 delegate introducer furl lookup to the config object 2020-11-16 15:02:51 -05:00
Jean-Paul Calderone
4e84f5e690 write introducers.yaml instead of [client]introducer.furl in client creation 2020-11-16 15:00:20 -05:00
Jean-Paul Calderone
10600ef5ec Move write_introducer somewhere it can be used more widely 2020-11-16 14:59:42 -05:00
Itamar Turner-Trauring
6b61c06882 All tests pass on Python 3. 2020-11-09 15:00:55 -05:00
Itamar Turner-Trauring
f50fd8e474 Switch to new configparser backport. 2020-10-26 12:12:46 -04:00
Ross Patterson
95f2d53f92 chore(refs #3455) Address feedback, BBB comments
https://github.com/tahoe-lafs/tahoe-lafs/pull/845#issuecomment-704469561
2020-10-07 12:28:41 -07:00