Jean-Paul Calderone
05eab3ce19
document these things since I had to figure them out
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
d504ad118f
Avoid the extra lookup inside this loop
...
Get the key and value at the same time during iteration.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
0e1bc2e786
As for the previous commit.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
62cb883ca2
Just iterate over the dictionary.
...
It is not shared with anyone. It is not mutated inside the loop. We can use
the no-copy dict iterator.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
e0c240a559
Use a MessageType so we can have a serializer
...
This allows us to avoid the .keys() call if logging is not actually enabled,
the common case.
2019-03-14 13:11:47 -04:00
Jean-Paul Calderone
c1e6f08813
Merge pull request #558 from tahoe-lafs/1432.watchdog-magic-folder-with-eliot
...
Add support for macOS to Magic-Folders.
Fixes: ticket:1432
2019-03-14 13:02:09 -04:00
Jean-Paul Calderone
fd49f6f52c
news fragment
2019-03-14 11:54:26 -04:00
Jean-Paul Calderone
f4c1038a24
Report coverage information to The Cloud™
2019-03-14 11:54:00 -04:00
Jean-Paul Calderone
31287efa95
Collect coverage information from the test suite
2019-03-14 11:53:52 -04:00
Jean-Paul Calderone
17c32a874b
Fix comment typo
2019-03-14 11:53:45 -04:00
Jean-Paul Calderone
365ff1a02c
explain why we need to touch() twice
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
5141105441
Fix typo
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
2cb710ac1e
Just touch the path once
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
b14583f0e9
Remove this broken ignore_count thing
...
The only purpose it serves to make the tests invalid and useless.
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
dfd0c6e54c
fix "downloader" type in message type
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
3978c45b04
spit out the events as raw as we can
2019-03-14 11:26:06 -04:00
Jean-Paul Calderone
fef79cd4a3
re-use the _add_watch helper
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
fcb08b5a3a
Move these Eliot events somewhere reusable
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
9ed019f8de
Give the tests a little more time. Windows may need it.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
64826aee37
Clean up stdout a bit
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
3176b6f18a
Create the watchdog Observer sooner
...
This lets us watch before start which Windows seems to really want.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
263755fb26
Watch before we start.
...
Linux and macOS are happy to watch after starting. Our Windows support
library can't deal with such a case, though.
Linux is happy with the other order. I'm about to find out if macOS is.
There are likely further Windows issues to deal with.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
2205bf0fdd
unused
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
241b6cedfe
Remove the skipped tests
...
They're skipped because we don't need that functionality. If we need it in
the future, we'll implement it with tests.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
984d27ab62
simplify
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
67ccd21481
python syntax
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
35fc563a6f
Attempt to work-around watchdog bug
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
e0b7919ad8
macOS is picky
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
4cccf5a316
it sure would be useful to be able to inspect these
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
c5c7f954e9
fix it!
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
515475022a
add a test for deleting a file and its containing directory
...
at about the same time
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
0822a71163
If it's some _other_ error then propagate it!
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
c2e19cc098
fix a raft of directory handling issues
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
4b0b269b56
Perform the asserts earlier
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
ed755cf590
it didn't start if the path is invalid
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
f2cfad0cb9
There _is_ no traceback. It's an else.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
db7af2661a
Close a window for a race condition in notification processing
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
81ca822edf
Cut the cost of this logging when logging is disabled
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
3ab7138598
some imports we need
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
7440ff6b93
log collective scanning
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
831836d5f6
don't try to propagate for non-directories
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
edfd9d3f92
rejected
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
cf2105364f
Try to fix another race in this test
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
600f263a3b
marginally improve reporting of uploader count failures
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
17540c78f3
not going to get processed any other way on fsevents
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
da0bbd6bba
Make this log message less confusing.
...
The method name still needs to be fixed.
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
70ec8f2963
log this case
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
de9c681fe2
Let me query for direct children of a directory
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
d4752bde1a
try to get more precise watchdog event info
2019-03-14 11:24:35 -04:00
Jean-Paul Calderone
4fc99b1b4d
oops
2019-03-14 11:24:35 -04:00
