Commit Graph

4728 Commits

Author SHA1 Message Date
David Stainton
ed29b65325 Attempt to fix the inotify test skips 2019-03-14 11:23:16 -04:00
David Stainton
e0ab0db84a Attempt to fix test run on windows 2019-03-14 11:23:16 -04:00
David Stainton
beb84feb2d Fix broken test for inotify 2019-03-14 11:23:16 -04:00
David Stainton
26277c218c Skip inotify tests on windows 2019-03-14 11:23:16 -04:00
David Stainton
6cd2ab7965 Add watchdog inotify and tests 2019-03-14 11:23:16 -04:00
Jean-Paul Calderone
5004cdf7ea Remove the now *duplicate* notification. :/ 2019-03-14 10:16:19 -04:00
Jean-Paul Calderone
c507b78656 Always fire the hook in case someone is waiting. 2019-03-14 09:47:15 -04:00
Jean-Paul Calderone
a3fb74ae9c Time out the others, too. 2019-03-14 09:47:06 -04:00
Jean-Paul Calderone
b9be85bc8c Also time out the delete operation 2019-03-14 09:46:34 -04:00
Jean-Paul Calderone
156257bcd8 YES RECURSIVE PLEASE 2019-03-14 09:20:37 -04:00
Jean-Paul Calderone
101c3cf1c5 Put some Eliot messages in the info processing loop 2019-03-14 09:20:05 -04:00
Jean-Paul Calderone
8fa6c66c2f Convert this message to an action for success/failure reporting 2019-03-14 09:19:50 -04:00
Jean-Paul Calderone
5cf223645d Apply a reasonable timeout to this way.
The notification should be basically instantaneous...
2019-03-14 09:04:26 -04:00
Jean-Paul Calderone
b2facd133c Add a smarter FileOperationsHelper.write condition
Wait for the file we care about, not any random file.
2019-03-14 09:04:01 -04:00
Jean-Paul Calderone
0902277613 another primitive debug helper 2019-03-14 09:02:46 -04:00
Jean-Paul Calderone
17509e25d8 Add missing import. 2019-03-12 20:32:45 -04:00
Jean-Paul Calderone
831452f776 Add missing import 2019-03-12 20:32:15 -04:00
Jean-Paul Calderone
1c6725fcdd is there even the slightest chance you could possibly give me a break 2019-03-12 19:37:28 -04:00
Jean-Paul Calderone
9bac375c38 tell me what you're reading, too 2019-03-12 19:36:42 -04:00
Jean-Paul Calderone
aed5c4604e Log fs events on Windows 2019-03-12 19:36:10 -04:00
Jean-Paul Calderone
0e3c4d40b8 Add some Eliot events related to fs notifications 2019-03-12 19:35:36 -04:00
Jean-Paul Calderone
a9ec9c00bd Attempt to apply previous fix to second test
It worked there.  Therefore, it will work here!
2019-03-12 19:34:24 -04:00
Jean-Paul Calderone
aef9c53be8 Perhaps actually fix this test on Windows 2019-03-12 19:33:25 -04:00
Jean-Paul Calderone
5b49fd5813 Perhaps fix this test on Windows 2019-03-12 19:33:14 -04:00
Jean-Paul Calderone
a73f4d77b5
Merge pull request #568 from tahoe-lafs/2992.some-more-simple-magic-folder-tests
Add a couple simple Magic Folder unit  tests

Fixes: ticket:2992
2019-03-11 08:10:20 -04:00
Jean-Paul Calderone
bbb4671823
Merge pull request #567 from tahoe-lafs/2991.test_eliotutil-improvements
Quality of implementation improvements to test_eliotutil

Fixes: ticket:2991
2019-03-11 08:08:32 -04:00
Jean-Paul Calderone
5f2d74ef1b some simple tests 2019-03-08 14:15:20 -05:00
Jean-Paul Calderone
0831229953 Switch to testtools-style skip
Raising SkipTest just errors out the test.
2019-03-08 13:29:27 -05:00
Jean-Paul Calderone
9c3832a9e7 Skip this on Linux
testtools doesn't have this "todo" feature.  It has "expected failure" feature
but I'm not ready to try to use that.
2019-03-08 12:52:14 -05:00
Jean-Paul Calderone
fc0cfb1a59 testtools does not support the skip attribute 2019-03-08 12:52:08 -05:00
Jean-Paul Calderone
912152d6b2 just rely on the functionality from the base class 2019-03-08 12:17:31 -05:00
Jean-Paul Calderone
30d07d3fb5 explicitly publish these classes 2019-03-08 12:17:16 -05:00
Jean-Paul Calderone
9ad76688cc Clean up a couple logged errors.
I don't really understand them but I can flush them. :/
2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
62531f020b Fix Eliot logging for tearDown 2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
f0f478195d Fix Eliot logging for setUp 2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
9abec67e43 Add Eliot logging for a couple setup helpers 2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
a8d67a09a5 Add Eliot logging for cleanup action 2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
eba642a9a1 Get rid of the duplicate base TestCase 2019-03-08 11:54:42 -05:00
Jean-Paul Calderone
64c5796a21
Merge pull request #565 from tahoe-lafs/2989.tempdir-cleanup
Add some tempfile cleanup to the test suite

Fixes: ticket:2989
2019-03-08 11:48:53 -05:00
Jean-Paul Calderone
859efdc589 there's another feature 2019-03-08 08:23:44 -05:00
Jean-Paul Calderone
c45b91e63c
Merge pull request #564 from tahoe-lafs/2988.mixin-supercalls
Fix some mixin supercalls

Fixes: ticket:2988
2019-03-08 07:47:36 -05:00
Jean-Paul Calderone
e4242704b1
Merge pull request #563 from tahoe-lafs/2987.log_call_deferred
Add Eliot logging helper

Fixes: ticket:2987
2019-03-08 07:46:36 -05:00
Jean-Paul Calderone
77b63e2855 This is unused! 2019-03-07 18:56:44 -05:00
Jean-Paul Calderone
1fdb13579a Oops. Testtools doesn't have these. 2019-03-07 18:56:37 -05:00
Jean-Paul Calderone
b2afe86b84 These tests leak resources. Clean them up. 2019-03-07 18:56:25 -05:00
Jean-Paul Calderone
925a3aed7b Add support for "broken" Twisted-style tests.
Some tests leak resources.  Clean up after them.
2019-03-07 18:55:52 -05:00
Jean-Paul Calderone
4de7077689 minimal docs 2019-03-07 18:54:15 -05:00
Jean-Paul Calderone
a1c8641359 these are always nice 2019-03-07 18:54:11 -05:00
Jean-Paul Calderone
19666c4c91 This class doesn't use poll. 2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
1b6a5b60bf Switch from the decorator to EliotLoggedRunTest 2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
51bee19b23 Add a testtools RunTest for Eliot integration 2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
bbd3b200cb Use our base TestCase classes for these introducer tests
They gain free tempfile cleanup as a result.
2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
565616dc75 Expand functionality of our base TestCase classes 2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
8593bf1b1c Make helper method compatible with other unittests
The msg keyword argument is overly precise.  testtools reasonably calls it
`message` instead.
2019-03-07 18:38:52 -05:00
Jean-Paul Calderone
cb9ad3faa5 supercall tearDown *synchronously*
It doesn't like it if it only happens later, I guess.
2019-03-07 18:34:59 -05:00
Jean-Paul Calderone
afe97fdd8c Fix TestMixin 2019-03-07 18:25:31 -05:00
Jean-Paul Calderone
e26895b149 Fix SignalMixin 2019-03-07 18:25:16 -05:00
Jean-Paul Calderone
3814ccb947 Fix some setUp and tearDown 2019-03-07 14:04:17 -05:00
Jean-Paul Calderone
39694fcfde this include_args is basically useless 2019-03-07 13:30:54 -05:00
Jean-Paul Calderone
5de4f4094e let it not return a Deferred 2019-03-07 13:30:47 -05:00
Jean-Paul Calderone
9802ee4e19 Some basic tests 2019-03-07 13:30:29 -05:00
Jean-Paul Calderone
f4950cff46 Convert some code to show it off 2019-03-07 13:14:52 -05:00
Jean-Paul Calderone
7d6e36d9c7 A basic implementation of the idea. 2019-03-07 13:07:02 -05:00
Jean-Paul Calderone
bcfd2e8ea0 ADD_FILE Eliot action 2019-03-07 12:55:24 -05:00
Jean-Paul Calderone
2931721dfa
Merge pull request #560 from tahoe-lafs/2982.process-queue-logging-fix
Fix serialization errors in the Eliot logging for the queue state.

Fixes: ticket:2982
2019-03-04 12:37:24 -05:00
Jean-Paul Calderone
0be2cbccc9 We don't need quoting in Eliot structured logs.
Also quote_filepath seems to be doing the wrong thing but it's not entirely
clear how.
2019-03-04 11:00:08 -05:00
Jean-Paul Calderone
fa3429f1cc Serialize queue items using their path and type 2019-03-04 10:47:05 -05:00
Jean-Paul Calderone
26a7cc4f21 The log directory may not yet exist. 2019-03-04 10:08:53 -05:00
Jean-Paul Calderone
c6a2aa9fc7 There may not be any destinations. 2019-03-04 10:08:46 -05:00
Jean-Paul Calderone
7885ba6d72 write the logs 2019-03-04 09:44:00 -05:00
Jean-Paul Calderone
64ef320592
Merge pull request #557 from tahoe-lafs/2980.eliot-destination-escaping
Fix escaping in Eliot destinations

Fixes: ticket:2980
2019-02-27 10:16:46 -05:00
Jean-Paul Calderone
3b804d84bf Restore the log event that the integration tests depend on 2019-02-27 09:12:09 -05:00
Jean-Paul Calderone
fe60980ccc and switch away from Windows drive separator... 2019-02-27 06:42:57 -05:00
Jean-Paul Calderone
d203fde9f6 Change away from the Windows directory separator for the escape char 2019-02-26 19:06:35 -05:00
Jean-Paul Calderone
25a62001dd Improve the failure case user experience
And test it
2019-02-26 19:05:39 -05:00
Jean-Paul Calderone
46692b5835 remove the duplicate reporting of this failure
it bubbles out of _process and the caller logs it
2019-02-26 15:10:33 -05:00
Jean-Paul Calderone
f89fe3a5ad get this item status in the right action context 2019-02-26 15:10:24 -05:00
Jean-Paul Calderone
42d8e8dba4 overcome finger muscle memory 2019-02-26 15:09:55 -05:00
Jean-Paul Calderone
9351e47ae6 improve events reporting 2019-02-26 15:09:48 -05:00
Jean-Paul Calderone
ebeeba456f fix conflict logging 2019-02-26 14:38:24 -05:00
Jean-Paul Calderone
3fca501d45 unused 2019-02-26 14:38:00 -05:00
Jean-Paul Calderone
92449563d4 no callers remain 2019-02-26 14:26:45 -05:00
Jean-Paul Calderone
7d8d74425c Convert Downloader._process 2019-02-26 14:26:37 -05:00
Jean-Paul Calderone
248449fefa convert _filter_batch_to_deque 2019-02-26 14:26:00 -05:00
Jean-Paul Calderone
51e8edbad7 Don't just leave this Deferred dangling 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
354dceda79 Get rid of last returnValue use
Supporting it with Eliot is challenging and we don't actually need it.
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
1d97486c29 Flush the UnrecoverableFileError from perform-scan 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
79bfb8acb6 can't log self! bluh 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
437084c300 pull this up and use it more 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
15601a37e9 it's a set apparently 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
436b91b463 oops @log_call is not Deferred friendly 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
92cf9b8232 done with those! 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
9efed05571 partial conversion of complex _process 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
e820698194 Simplified _perform_scan conversion 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
ef69bb83f4 another improvement to scan_listing 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
17597e53c9 improvement to scan_listing 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
7790820efd convert start_downloading 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
3b38a228b0 Relax restriction on mtime 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
91d86363ec Convert the rest of _write_downloaded_file 2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
529389a48c Convert _write_downloaded_file 2019-02-26 13:45:39 -05:00