Jean-Paul Calderone
d203fde9f6
Change away from the Windows directory separator for the escape char
2019-02-26 19:06:35 -05:00
Jean-Paul Calderone
25a62001dd
Improve the failure case user experience
...
And test it
2019-02-26 19:05:39 -05:00
Jean-Paul Calderone
46692b5835
remove the duplicate reporting of this failure
...
it bubbles out of _process and the caller logs it
2019-02-26 15:10:33 -05:00
Jean-Paul Calderone
f89fe3a5ad
get this item status in the right action context
2019-02-26 15:10:24 -05:00
Jean-Paul Calderone
42d8e8dba4
overcome finger muscle memory
2019-02-26 15:09:55 -05:00
Jean-Paul Calderone
9351e47ae6
improve events reporting
2019-02-26 15:09:48 -05:00
Jean-Paul Calderone
ebeeba456f
fix conflict logging
2019-02-26 14:38:24 -05:00
Jean-Paul Calderone
3fca501d45
unused
2019-02-26 14:38:00 -05:00
Jean-Paul Calderone
92449563d4
no callers remain
2019-02-26 14:26:45 -05:00
Jean-Paul Calderone
7d8d74425c
Convert Downloader._process
2019-02-26 14:26:37 -05:00
Jean-Paul Calderone
248449fefa
convert _filter_batch_to_deque
2019-02-26 14:26:00 -05:00
Jean-Paul Calderone
51e8edbad7
Don't just leave this Deferred dangling
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
354dceda79
Get rid of last returnValue use
...
Supporting it with Eliot is challenging and we don't actually need it.
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
1d97486c29
Flush the UnrecoverableFileError from perform-scan
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
79bfb8acb6
can't log self! bluh
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
437084c300
pull this up and use it more
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
15601a37e9
it's a set apparently
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
436b91b463
oops @log_call is not Deferred friendly
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
92cf9b8232
done with those!
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
9efed05571
partial conversion of complex _process
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
e820698194
Simplified _perform_scan conversion
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
ef69bb83f4
another improvement to scan_listing
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
17597e53c9
improvement to scan_listing
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
7790820efd
convert start_downloading
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
3b38a228b0
Relax restriction on mtime
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
91d86363ec
Convert the rest of _write_downloaded_file
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
529389a48c
Convert _write_downloaded_file
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
ad5cfd0e45
convert a couple rename helpers
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
03f480e5be
convert _real_notify
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
c3e50a4536
convert _notify
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
bfb039c6c6
convert _scan
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
5410acd745
use this helper
...
it might even let us refactor someday
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
999b8bdbd7
convert _full_scan
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
d7bb97ae05
Factor out repeated queue processor identification
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
f553469944
convert add_pending
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
2761d38ce2
convert start_uploading
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
28a4a61dab
convert stop(_monitoring)
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
44a8ac8161
convert start_monitoring
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
c88b66fb05
remove unused helper
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
5dd225de07
Add the necessary Eliot logging flush/assertion
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
491e0ecde3
Convert another _process and some helpers
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
83c4056a5d
Convert _process_deque
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
2b9e6784ab
news fragment
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
d52e9ccc6f
unused attribute
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
587f50882e
Convert _begin_processing
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
9207e07407
There need be no "debug log".
2019-02-26 13:45:39 -05:00
Jean-Paul Calderone
ca82d4f83d
Merge remote-tracking branch 'origin/master' into 2972.magic-folder-eliot-logs
2019-02-26 13:33:39 -05:00
Jean-Paul Calderone
7fb695f956
Add user-facing help about destinations
2019-02-25 13:34:02 -05:00
Jean-Paul Calderone
1cf4fd46ed
class docstring
2019-02-25 13:15:09 -05:00
Jean-Paul Calderone
67ca5c4b4c
Give the top-level command --eliot-destination
2019-02-25 13:12:03 -05:00
Jean-Paul Calderone
4f238d0f64
Clarify possible usage here
2019-02-25 13:11:52 -05:00
Jean-Paul Calderone
f20184ce95
Declare our new dependencies
2019-02-25 11:55:47 -05:00
Jean-Paul Calderone
abae1be9c6
Add helpers for configuring and using Eliot logging
2019-02-25 11:52:50 -05:00
Jean-Paul Calderone
f90a137552
Basic housekeeping previously missed
2019-02-25 08:57:38 -05:00
Jean-Paul Calderone
89e59dde05
Revert _perform_scan to inlineCallbacks style
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
0a9a962614
inline_callbacks moved
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
121fdc141b
Slightly improved API documentation
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
7ed9b0a02e
document this TestCase thing
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
4f796312a5
Switch tests over to Eliot-friendly version of inlineCallbacks
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
42c1d3939f
_begin_processing cleanups
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
7d2827b93d
Better docs for QueueMixin.stop
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
049a535048
reduce repetition
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
a2b4455229
try to reduce the size of the diff relative to master
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
7a9f52d2e5
make sure shutdown failures go somewhere good
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
ebd017cf2b
Clean up action relationship where it's easy to do so
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
88eb368db1
Further Eliotification
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
f1a7dcf309
A fair bit more Eliot conversion
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
9966cb26d2
Basic _process logging
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
7e89776349
Convert various logging to use Eliot
...
This unfortunately also involves refactoring some inlineCallbacks-using code
to not use inlineCallbacks.
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
e226956d14
Some testing for Eliot message validity
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
3020fb979d
Hoist some of this to a shared module
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
dd02a23cad
A few more debug prints - for now
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
6ca328ba94
Fix comparison of NummedObj against non-NummedObj
...
Previously this would explode with AttributeError.
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
714a7de84a
Associate an Eliot action with magicfolder database updates
2019-02-25 08:35:57 -05:00
Jean-Paul Calderone
19f06809e2
That was all nonsense. Throw it out.
2019-02-22 09:11:44 -05:00
Jean-Paul Calderone
e55ee7d044
Move generator context state to a generator context manager
2019-02-22 08:40:16 -05:00
Jean-Paul Calderone
d902f7567f
Add a test for nested decorated generators
2019-02-22 08:39:38 -05:00
Jean-Paul Calderone
66d4a9b4a1
Depend on Eliot
2019-02-21 13:19:57 -05:00
Jean-Paul Calderone
cd3207e543
test that close works. it does.
2019-02-21 13:11:44 -05:00
Jean-Paul Calderone
05807ace40
Split the implementation helpers out of the test suite
2019-02-21 12:54:10 -05:00
Jean-Paul Calderone
609af9ce18
unused import
2019-02-21 12:42:57 -05:00
Jean-Paul Calderone
15ae31bf23
A stab at Eliot support for inlineCallbacks
2019-02-21 12:42:52 -05:00
Jean-Paul Calderone
9ad8e21530
An Eliot-adjacent testing helper
2019-02-21 12:42:46 -05:00
Jean-Paul Calderone
c764214d0e
A note about this queue flushing.
2019-01-31 09:07:31 -05:00
Jean-Paul Calderone
f61b51619d
Improve the failure mode for this test.
...
Make it show stderr if there is any and stdout if the expected content is missing.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
89bb68254b
Speed up MagicFolder service shutdown
...
Also work-around a tricky, mysterious failure in the test suite by explicitly
flushing the eventual call queue. I don't understand where the call that is
landing there comes from or why some other part of the code isn't properly
waiting on it.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
2b475777d9
Return the result of the base stopService
...
It is a Deferred that indicates when things have actually stopped. Failing to
return it means callers will think everything stopped synchronously. This is
certainly not the case.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
0f6009b97e
Fix the option setup for the webopen command.
2019-01-30 19:32:56 -05:00
Jean-Paul Calderone
b54a6e811b
Return the Deferred to make the test valid
2019-01-30 19:24:28 -05:00
Jean-Paul Calderone
f0734284e0
whitespace
2019-01-30 19:24:20 -05:00
Jean-Paul Calderone
2531c19efd
Merge pull request #537 from tahoe-lafs/2959.travis-trusty-tor
...
Move integration tests from TravisCI to CircleCI
Fixes: ticket:2959
2019-01-24 20:47:24 -05:00
Jean-Paul Calderone
7e9e447d5b
Disable Twisted's Docker check wrt inotify support
...
It breaks our container-based CI, which is perfectly happy to give us inotify
functionality, as is Docker in general as long as you don't use overlayfs.
2019-01-24 14:00:50 -05:00
Jean-Paul Calderone
dcb4a218b1
This nearby code is also dead.
2019-01-24 09:55:40 -05:00
Jean-Paul Calderone
252f9eb23a
This code has pyflakes warnings *and* is dead.
2019-01-24 09:53:49 -05:00
Jean-Paul Calderone
e36c850da4
== instead of is for string comparison
2019-01-24 09:53:02 -05:00
Jean-Paul Calderone
5ed375b145
Add more complexity to the package sanity checking
...
Support comma-separated lists of extras
2019-01-23 14:58:44 -05:00
Jean-Paul Calderone
4166551afd
Bump dependency to Twisted 16.6 and add conch extra
...
This automatically brings in the bcrypt dependency coming along with a
forthcoming Twisted release.
2019-01-23 14:02:15 -05:00
meejah
768eceacf2
unused var
2018-09-11 11:38:56 -06:00
meejah
1ad2174df9
windows yaml.safe_load returns None on unreadable files..
2018-09-11 11:14:41 -06:00
meejah
7d34f8f1a1
test case when safe_load fails
2018-09-10 21:58:28 -06:00
