Itamar Turner-Trauring
42c4bac845
Fix test failure.
2021-02-12 12:01:43 -05:00
Chad Whitacre
b75b48e68c
Move FakeCanary to common_util
...
Couldn't bring myself to move it back to test_storage.
2020-09-30 23:29:08 -04:00
Chad Whitacre
23140b8b1c
Move ShouldFailMixin back to common_util
...
There were originally two versions of this, one in common and another in
common_util. We moved both into common_py3 but then removed the one from
common, so here we move back to common_util, while allowing imports from
common to avoid a noisy changeset.
2020-09-30 23:01:46 -04:00
Chad Whitacre
2c2b61676c
Move LoggingServiceParent back to common
2020-09-30 22:32:13 -04:00
Itamar Turner-Trauring
7aa7716f3a
Wrap with list(), just in case.
2020-09-28 15:44:29 -04:00
Itamar Turner-Trauring
02cb451a6b
Fix failing tests.
2020-09-17 16:06:26 -04:00
Itamar Turner-Trauring
b4116239b5
Merge remote-tracking branch 'origin/master' into 3415.storage-server-python-3
2020-09-16 11:27:03 -04:00
Itamar Turner-Trauring
a552bb53a7
Merge remote-tracking branch 'origin/master' into 3409.allmydata-storage-immutable-python-3
2020-09-15 09:05:55 -04:00
Itamar Turner-Trauring
65d38055e4
Merge branch '3409.allmydata-storage-immutable-python-3' into 3415.storage-server-python-3
2020-09-14 14:48:24 -04:00
Itamar Turner-Trauring
947cb1c11b
Tiny bit more test coverage for server.py.
2020-09-14 14:40:02 -04:00
Itamar Turner-Trauring
1d508c74e8
Port to Python 3.
2020-09-14 14:13:07 -04:00
Itamar Turner-Trauring
6983c79b26
Tests for allmydata.storage.common.
2020-09-14 14:03:02 -04:00
Itamar Turner-Trauring
e86e0d761f
Better test coverage for allmydata.storage.immutable.
2020-09-11 14:51:08 -04:00
Itamar Turner-Trauring
fad93f4144
Use existing utility.
2020-09-08 14:13:22 -04:00
Itamar Turner-Trauring
6da338a86a
Note it's been ported.
2020-09-08 14:09:35 -04:00
Itamar Turner-Trauring
3fa919834a
Finish port to Python 3.
2020-08-31 13:20:57 -04:00
Itamar Turner-Trauring
1cfe58a52d
All of test_storage passes on Python 3.
2020-08-31 13:17:52 -04:00
Itamar Turner-Trauring
6c52a03030
Fix indent.
2020-08-31 11:59:34 -04:00
Itamar Turner-Trauring
2ba0854e0d
More passing tests.
2020-08-28 13:24:17 -04:00
Itamar Turner-Trauring
50007ac868
More passing tests.
2020-08-28 12:41:19 -04:00
Itamar Turner-Trauring
5ad5b79cdd
More passing tests.
2020-08-28 10:53:52 -04:00
Itamar Turner-Trauring
1a65dfa4ab
Some potential progress.
2020-08-27 15:58:03 -04:00
Itamar Turner-Trauring
9ce43231b4
More passing tests.
2020-08-27 15:49:04 -04:00
Itamar Turner-Trauring
6007c1f67f
Some tests are passing.
2020-08-27 15:36:54 -04:00
Itamar Turner-Trauring
a758f32edf
Try to make test_storage import on Python 3.
2020-08-26 10:53:02 -04:00
Itamar Turner-Trauring
416ab64335
Fix an import.
2020-08-19 10:50:44 -04:00
Itamar Turner-Trauring
80b9a9b3ce
Split the test module in two.
2020-08-18 13:03:36 -04:00
Itamar Turner-Trauring
eb688dfd7e
Fix lint.
2020-07-22 13:22:50 -04:00
Itamar Turner-Trauring
e48aecfa1a
Move parsing tests to better location, and fix them.
2020-07-22 12:55:16 -04:00
Sajith Sasidharan
61aef4caef
Merge pull request #690 from sajith/3247.storage-py-neovw-to-twt
...
Use twisted.web.template in web/storage.py
Fixes: ticket:3247
2020-07-06 16:18:34 -04:00
meejah
d4f29e7d6c
restore old code, run the GC
2020-05-05 13:57:17 -06:00
meejah
b54dc1e5d5
whitespace (1 line per import)
2020-05-05 13:56:59 -06:00
meejah
9bcc465f76
unused import
2020-05-04 21:59:15 -06:00
meejah
4928d62d66
use set instead of WeakKeyDictionary
2020-05-04 21:59:15 -06:00
meejah
a348d3d507
relying on memory/gc bad
2020-05-04 21:59:15 -06:00
Sajith Sasidharan
b3feaae644
Use an inner JSONRequest class with renderJSON
...
Once nevow is removed from web/common.py, we can simplify
renderJSON(), like so:
def renderJSON():
req = Request()
req.args = {"t": ["json"]}
req.fields = {}
return resource.render(req)
But for now we have to live with an inner class that implements the
nevow.inevow.IRequest interface.
2020-04-21 10:29:28 -04:00
Sajith Sasidharan
201c08dbe5
Declare JSON request interface using @implementer
...
"zope.interface.implements(IRequest)" is deprectated in favor of
"@zope.interface.implementer(IRequest)" decorator.
2020-04-20 16:54:51 -04:00
Sajith Sasidharan
82cd5a87fe
Use DummyRequest in storage tests
...
Using twisted.web.server.Request causes test_new_style_classes to
fail like so:
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Traceback (most recent call last):
File ".tox/coverage/lib/python2.7/site-packages/allmydata/test/test_python2_regressions.py", line 69, in test_new_style_classes
"Expected to find no classic classes.",
File ".tox/coverage/lib/python2.7/site-packages/testtools/testcase.py", line 502, in assertThat
raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = set([])
actual = set([<class allmydata.test.test_storage.JSONRequest at 0x7fd938040bb0>])
: Expected to find no classic classes.
Seems that `DummyRequest` is an acceptable new style class.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
b2b7061980
Refactor storage test helpers
...
Rewrite `renderSynchronously()` to use `renderDeferred()`
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
72b8f72080
Add docstrings to storage test helpers
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
8b7ef33b3d
Remove redundant render_json() method
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
8c92187d92
Avoid using nevow FakeRequest in storage test.
...
Use twisted.web.server.Request instead, with a DummyChannel.
There's still one line of inevitable nevow now, because of code in
web/common.py; but that should be easily replaceable once we switch
that over.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
f1fe3a7588
Get rid of WebRenderingMixin in storage test
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
110734daf0
Use a helper to exercise render() in storage test cases
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
554c477cea
Prefix member variable with "_"
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
c061f6830e
Use successResultOf
in renderSynchronously
...
Get rid of [].append trick when dealing with the deferred.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
e2fc1fc07e
Move renderSynchronously
to test suite
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
d3ff578640
Use parentheses in test suite's import statement
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
0993e61046
Drop unused ctx
argument from render_space methods
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
c7a63f957d
Refactor so that test_util pass
2020-04-17 15:25:42 -04:00