Brian Warner
28b74b0b74
test/check_load: hush (newer) pyflakes
...
pyflakes-0.9.2 gets confused about list comprehensions, so rename the
loop variable even though we'd deleted that name already.
2015-07-12 18:25:55 -07:00
Brian Warner
7aedd7c1b2
test_web: avoid IP autodetection, was causing dirty reactor
2015-07-12 18:20:43 -07:00
Daira Hopwood
f18da535c9
Remove packages from not_import_versionable that we now can always version.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-06-02 18:12:23 +01:00
Daira Hopwood
96024d7244
Add OpenSSL version check and tests. refs ticket:2215
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-06-02 18:07:20 +01:00
Brian Warner
45ebbbf44b
wrap long lines, and tolerate various-width wrappings of the --help output
...
test_cli.Help was too sensitive to the way that the --help output was
wrapped, which caused failures on travis when COLUMNS= was set low and
the expected strings were split across separate lines.
2015-05-26 11:40:17 -07:00
Brian Warner
8f41713fe9
cli: improve formatting of all commands
...
Also:
* do some light refactoring of create-client/node
* make it clear that these commands' --basedir options do the same as
the global --node-directory option
* use "global-options" instead of "global-opts"
2015-05-26 11:31:06 -07:00
Brian Warner
01619844de
scripts: improve rendering of synopsis/usage
...
Subcommands "--help" is now rendered as:
```
tahoe [global-options] COMMAND [options] ARGS
(use 'tahoe --help' to view global options)
USAGE (flags/options)
DESCRIPTION
DESCRIPTION_UNWRAPPED
```
The new .description and .description_unwrapped fields allow
commands (subclasses of twisted.python.usage.Usage) better control over
how their explanations are rendered: the old .longdesc field was wrapped
unpleasantly.
2015-05-26 11:29:49 -07:00
Brian Warner
5d5fa05a42
scripts/runner.py: put command group descriptions in parens
2015-05-26 11:27:57 -07:00
Brian Warner
1c34cbd627
refactor scripts/common.py: move _default_nodedir out to its own file
2015-05-26 11:27:57 -07:00
Zooko
a9b152780e
remove dead code: NamedTemporaryDirectory
...
fixes #2433
2015-05-26 17:20:11 +00:00
Daira Hopwood
143af61518
fileutil.py: use ctypes.get_last_error() instead of GetLastError(). refs #1531
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-18 01:42:01 +01:00
Daira Hopwood
4794666df6
On Windows, the user's home directory may be either %USERPROFILE% or %HOMEDRIVE%%HOMEPATH% depending on the Windows version. fixes ticket:2417
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 14:42:31 +01:00
Daira Hopwood
f973657a6a
interfaces.py: fix arguments to create_subdirectory.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 14:21:28 +01:00
Daira Hopwood
5d046c597e
drop-upload.py: fix error messages.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 14:21:17 +01:00
Daira Hopwood
0c4acc763b
Fix a pyflakes warning.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 14:21:17 +01:00
Daira Hopwood
07aa5e76b5
Retire the setup_requires hack in cases where it isn't needed (and can cause build problems). refs #2286
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 12:49:18 +01:00
Daira Hopwood
d106a77567
_auto_deps.py: update comments. refs #2416
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 12:44:21 +01:00
Daira Hopwood
c2874a7073
Allow working with Twisted >= 13 on Windows if pywin32 is manually installed. fixes #2416
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-05-13 12:44:21 +01:00
Brian Warner
be5d07a70a
apply review feedback
2015-05-03 22:14:36 -07:00
Brian Warner
275ddb93cc
cp: trailing slash on source filename is an error, just like on targets
2015-05-03 22:14:35 -07:00
Brian Warner
ca23c4fa23
tahoe cp: ignore trailing slash on source arguments
...
This avoids an error case where an empty child name resulted in a
duplicate mkdir. It adds a precondition check to guard against empty
child names, and some test cases. It also cleans up a funny redundancy
noticed earlier (refs ticket:2329).
2015-05-03 22:13:52 -07:00
Brian Warner
97fd19407d
Improve docs on 'cp -r', noting the recent 2329 changes
...
refs ticket:2329
2015-05-03 21:49:34 -07:00
Brian Warner
341e263e03
control.py: minor improvements
...
refs ticket:1737
2015-04-28 11:03:12 -07:00
Daira Hopwood
53ced4be8b
Change foolscap dependency to >= 0.8.0. refs #2400
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-28 17:21:31 +01:00
Daira Hopwood
e6cede21f2
Fix a test that was dependent on Windows path separators.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-21 21:28:21 +01:00
Daira Hopwood
6bcef565d9
Reduce differences between Windows and non-Windows dependencies.
...
This also fixes some warnings on Windows when using Twisted 12.1.0.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-21 21:16:29 +01:00
Brian Warner
f0e783e20e
fix check-memory test, with new new (safe) control-port methods
2015-04-21 13:05:58 -07:00
Daira Hopwood
eb34e0d625
Ensure the 'base' argument to abspath_expanduser_unicode takes effect on Windows. fixes #2398
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-21 21:04:20 +01:00
Brian Warner
edcdaa2799
finish removing control-port upload/download functions
2015-04-21 11:26:16 -07:00
Brian Warner
2eea4e9a07
remove control-port upload/download file interfaces
...
FURLs are unguessable, but an attacker who somehow learned this FURL
could overwrite files and read sensitive data.
This will break the memory tests. I will add a new interface to support
the memory tests soon.
refs ticket:1737
2015-04-21 11:13:17 -07:00
Daira Hopwood
45c1dc7e63
backupdb.py: cosmetics
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-17 22:31:01 +01:00
Daira Hopwood
6e9a602df6
Make backupdb use dbutil.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-17 22:30:47 +01:00
Daira Hopwood
769de61a90
Add util/dbutil.py: open/create/update sqlite databases given some schema.
...
Author: Brian Warner <warner@lothar.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-17 18:11:10 +01:00
Daira Hopwood
4de4e0e65e
Some useful Deferred utilities, originally from the cloud backend branch.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-04-17 18:10:21 +01:00
Brian Warner
eda00a5c58
typo
2015-03-31 11:07:21 -07:00
Brian Warner
cc68a81326
bump Twisted dep to 11.1.0, thus simplify IntishPermissions
2015-03-31 11:06:14 -07:00
Brian Warner
b36903d02c
test_ftp: fix comparison against integer
2015-03-31 11:06:14 -07:00
Brian Warner
26c8abadec
Fix ftp 'ls' to work with current Twisted-15.0.0
...
refs ticket:2394
It's kind of a hack, but Twisted changed the API and I couldn't find a
cleaner way to detect which form of "permissions" value the Twisted FTP
server wants.
I've manually tested it against 14.0.2 and 15.0.0.
2015-03-31 11:06:14 -07:00
Brian Warner
2d3c805a90
use more servers for test_mutable.Update, to test #2034 properly
2015-03-25 18:49:37 -07:00
Daira Hopwood
b6be693cbe
Add a test, add missing imports. refs #2388
...
This tests ftpd, but not sftpd. Doing this sort of test on sftpd
requires the creation of a valid pubkey/privkey file pair, which is more
work than I want to do right now.
init_ftp/init_sftp were changed to interpret the configured
accounts.file as relative to the node's basedir, with
abspath_expanduser_unicode(accountfile, base=self.basedir).
This would happen naturally in a real node, since it os.chdir()s
to the basedir before doing anything. But tests don't do that.
Author: Brian Warner <warner@lothar.com>
Author: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-03-24 17:10:00 +00:00
Daira Hopwood
3066039f0f
Ensure that path parameters to SFTPServer and FTPServer constructors are unicode. refs #2388
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-03-24 16:46:40 +00:00
Daira Hopwood
21226cbb82
Add from_utf8_or_none and tests.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2015-03-24 16:46:40 +00:00
Brian Warner
681eb4d12e
check_memory.py: announce 32-bit vs 64-bit
2015-03-19 18:59:16 -07:00
Brian Warner
3dd7142c42
test_cli_cp.py: hush pyflakes
2015-03-17 11:16:06 -07:00
Brian Warner
48da2cd99b
tahoe_cp: be consistent with "source.basename() is None" testing
2015-03-17 11:13:57 -07:00
Brian Warner
190743e066
tahoe_cp: minor cleanups, no behavior changes
2015-03-17 11:13:33 -07:00
Brian Warner
1838fe8eaf
tahoe_cp: make populate(recurse=) more explicit
2015-03-17 11:11:11 -07:00
Brian Warner
f508a98622
test_cli_cp: test cleanups
...
* remove redundant test cases
* add more internal asserts
* clean up set usage
2015-03-17 10:41:01 -07:00
Brian Warner
415b7b7bca
test_cli_cp: improve test cases
2015-03-17 09:59:34 -07:00
Brian Warner
f3a9be1c5e
improve error message for slash-terminated non-directories
2015-03-10 09:17:17 -07:00