68 Commits

Author	SHA1	Message	Date
david-sarah	15ddab08ed	SFTP: address some of the comments in zooko's review (#1106).	2010-07-11 19:55:37 -07:00
david-sarah	88169328be	SFTP: don't call .stopProducing on the producer registered with OverwriteableFileConsumer (which breaks with warner's new downloader).	2010-06-28 16:19:26 -07:00
david-sarah	c1412c8a81	SFTP: get 'ctime' attribute from 'tahoe:linkmotime'.	2010-06-16 20:37:44 -07:00
david-sarah	a3acb2b773	SFTP: remove a dubious use of 'pragma: no cover'.	2010-06-13 09:43:56 -07:00
david-sarah	b67f8b66c8	SFTP: further small improvements to test coverage. Also ensure that after a test failure, later tests don't fail spuriously due to the checks for heisenfile leaks.	2010-06-11 20:07:37 -07:00
david-sarah	b4e074d250	SFTP: further improve test coverage (paths containing '.', bad data for posix-rename extension, and error in test of openShell).	2010-06-11 14:31:42 -07:00
david-sarah	52f87904ed	SFTP: improve test coverage for no-write on mutable files, and check for heisenfile table leaks in all relevant tests. Delete test_memory_leak since it is now redundant.	2010-06-11 13:57:52 -07:00
david-sarah	3c44389440	SFTP: fix most significant memory leak described in #1045 (due to a file being added to all_heisenfiles under more than one direntry when renamed).	2010-06-09 01:00:03 -07:00
david-sarah	80a89d3931	stringutils.py, sftpd.py: Portability fixes for Python <= 2.5.	2010-06-08 18:33:02 -07:00
david-sarah	4b5927fdb8	SFTP: suppress NoSuchChildError if heisenfile attributes have been updated in setAttrs, in the case where the parent is available.	2010-06-07 23:37:53 -07:00
david-sarah	195b4afa8f	SFTP: ignore permissions when opening a file (needed for sshfs interoperability).	2010-06-07 22:57:00 -07:00
Zooko O'Whielacronx	08058c1073	fix syntax of assertion handling that isn't portable to older versions of Python	2010-06-04 00:58:05 -07:00
david-sarah	a2cff856ff	Resolve merge conflict for sftpd.py	2010-06-03 11:25:37 -07:00
david-sarah	2dcb62de90	SFTP: possible fix for metadata times being shown as the epoch.	2010-06-02 16:45:14 -07:00
david-sarah	c9984c40e9	SFTP: further improvements to test coverage.	2010-06-02 16:44:22 -07:00
david-sarah	2a791b0d05	SFTP: improve test coverage. Also make creating a directory fail when permissions are read-only (rather than ignoring the permissions).	2010-06-01 21:19:34 -07:00
david-sarah	db394671e9	SFTP: fix a bug that caused the temporary files underlying EncryptedTemporaryFiles not to be closed.	2010-05-31 22:53:10 -07:00
david-sarah	de95140b7b	SFTP: changes for #1063 ('no-write' field) including comment:1 (clearing owner write permission diminishes to a read cap). Includes documentation changes, but not tests for the new behaviour.	2010-05-31 22:11:39 -07:00
david-sarah	9faa02deb5	SFTP: the same bug as in _sync_heisenfiles also occurred in two other places.	2010-05-29 23:01:27 -07:00
david-sarah	cccdd32806	SFTP: another try at fixing the _sync_heisenfiles bug.	2010-05-29 22:52:54 -07:00
david-sarah	51b0d8bde3	SFTP: fix silly bug in _sync_heisenfiles ('f is not ignore' vs 'not (f is ignore)').	2010-05-29 22:38:07 -07:00
david-sarah	b9d3cf12b8	SFTP: log when a sync completes.	2010-05-29 22:18:40 -07:00
david-sarah	c4a8af4d27	SFTP: fix bug in previous logging patch.	2010-05-29 22:00:00 -07:00
david-sarah	3395a7e154	SFTP: more logging to track down OpenOffice hang.	2010-05-29 21:08:09 -07:00
david-sarah	4be24a89df	SFTP: avoid blocking close on a heisenfile that has been abandoned or never changed. Also, improve the logging to help track down a case where OpenOffice hangs on opening a file with FXF_READ|FXF_WRITE.	2010-05-29 19:55:44 -07:00
david-sarah	8ed28a95e7	Move suppression of DeprecationWarning about BaseException.message from sftpd.py to main __init__.py. Also, remove the global suppression of the 'integer argument expected, got float' warning, which turned out to be a bug.	2010-05-28 22:05:37 -07:00
david-sarah	e867985539	SFTP: cater to clients that assume a file is created as soon as they have made an open request; also, fix some race conditions associated with closing a file at about the same time as renaming or removing it.	2010-05-28 21:52:53 -07:00
david-sarah	0b888f8201	SFTP: 'sync' any open files at a direntry before opening any new file at that direntry. This works around the sshfs misbehaviour of returning success to clients immediately on close.	2010-05-25 16:02:57 -07:00
david-sarah	a143b1297b	SFTP: handle removing a file while it is open. Also some simplifications of the logout handling.	2010-05-25 11:42:10 -07:00
david-sarah	e81ce2bbd2	SFTP: a posix-rename response should actually return an FXP_STATUS reply, not an FXP_EXTENDED_REPLY as Twisted Conch assumes. Work around this by raising an SFTPError with code FX_OK.	2010-05-24 20:33:23 -07:00
david-sarah	8f86490d48	SFTP: fix problem with posix-rename code returning a Deferred for the renamed filenode, not for the result of the request (an empty string).	2010-05-24 19:02:09 -07:00
david-sarah	210578da63	SFTP: fix time handling to make sure floats are not passed into twisted.conch, and to print times in the future less ambiguously in directory listings.	2010-05-24 16:04:12 -07:00
david-sarah	549dccd608	SFTP: name of the POSIX rename extension should be 'posix-rename@openssh.com', not 'extposix-rename@openssh.com'.	2010-05-23 19:11:56 -07:00
david-sarah	6e114e44b5	SFTP: avoid race condition where .write could be called on an OverwriteableFileConsumer after it had been closed.	2010-05-23 16:38:30 -07:00
david-sarah	c6b414c815	SFTP: log tracebacks for RAISEd exceptions.	2010-05-23 15:15:35 -07:00
david-sarah	725daee788	SFTP: more logging to investigate behaviour of getAttrs(path).	2010-05-23 13:42:36 -07:00
david-sarah	75357fd2d5	SFTP: fix pyflakes warnings; drop 'noisy' versions of eventually_callback and eventually_errback; robustify conversion of exception messages to UTF-8.	2010-05-23 07:09:05 -07:00
david-sarah	38964fb35a	SFTP: fixes and test cases for renaming of open files.	2010-05-22 20:25:49 -07:00
david-sarah	5974773969	SFTP: Fix error in support for getAttrs on an open file, to index open files by directory entry rather than path. Extend that support to renaming open files. Also, implement the extposix-rename@openssh.org extension, and some other minor refactoring.	2010-05-21 20:58:36 -07:00
david-sarah	ce3872d10e	SFTP: allow getAttrs to succeed on a file that has been opened for creation but not yet uploaded or linked (part of #1050).	2010-05-19 20:56:13 -07:00
david-sarah	7f9e351bce	SFTP: improve logging so that results of requests are (usually) logged.	2010-05-19 17:36:52 -07:00
david-sarah	a62733ed08	SFTP: add tests for more combinations of open flags.	2010-05-18 22:39:33 -07:00
david-sarah	f0945526ce	SFTP: allow FXF_WRITE | FXF_TRUNC (#1050).	2010-05-18 21:32:40 -07:00
david-sarah	bde27cab57	SFTP: remove another case where we were logging data.	2010-05-18 18:27:13 -07:00
david-sarah	d8b096a054	SFTP: avoid logging all data passed to callbacks.	2010-05-18 17:06:51 -07:00
david-sarah	819eaa74c1	SFTP: fixes related to reporting of permissions (needed for sshfs).	2010-05-17 22:45:21 -07:00
david-sarah	8d118e28f1	SFTP: change error code returned for ExistingChildError to FX_FAILURE (fixes gvfs with some picky programs such as gedit).	2010-05-17 17:42:05 -07:00
david-sarah	57699fd1eb	SFTP: fixed bugs that caused hangs during write (#1037).	2010-05-16 21:42:28 -07:00
david-sarah	5f9c10901b	SFTP: work around a probable bug in twisted.conch.ssh.session:loseConnection(). Also some minor error handling cleanups.	2010-05-16 18:26:06 -07:00
david-sarah	6a2b0229f0	SFTP: Support statvfs extensions, avoid logging actual data, and decline shell sessions politely.	2010-05-16 08:43:47 -07:00