Jean-Paul Calderone
05807ace40
Split the implementation helpers out of the test suite
2019-02-21 12:54:10 -05:00
Jean-Paul Calderone
609af9ce18
unused import
2019-02-21 12:42:57 -05:00
Jean-Paul Calderone
15ae31bf23
A stab at Eliot support for inlineCallbacks
2019-02-21 12:42:52 -05:00
Jean-Paul Calderone
9ad8e21530
An Eliot-adjacent testing helper
2019-02-21 12:42:46 -05:00
Jean-Paul Calderone
c764214d0e
A note about this queue flushing.
2019-01-31 09:07:31 -05:00
Jean-Paul Calderone
f61b51619d
Improve the failure mode for this test.
...
Make it show stderr if there is any and stdout if the expected content is missing.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
89bb68254b
Speed up MagicFolder service shutdown
...
Also work-around a tricky, mysterious failure in the test suite by explicitly
flushing the eventual call queue. I don't understand where the call that is
landing there comes from or why some other part of the code isn't properly
waiting on it.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
2b475777d9
Return the result of the base stopService
...
It is a Deferred that indicates when things have actually stopped. Failing to
return it means callers will think everything stopped synchronously. This is
certainly not the case.
2019-01-31 08:16:57 -05:00
Jean-Paul Calderone
0f6009b97e
Fix the option setup for the webopen command.
2019-01-30 19:32:56 -05:00
Jean-Paul Calderone
b54a6e811b
Return the Deferred to make the test valid
2019-01-30 19:24:28 -05:00
Jean-Paul Calderone
f0734284e0
whitespace
2019-01-30 19:24:20 -05:00
Jean-Paul Calderone
dcb4a218b1
This nearby code is also dead.
2019-01-24 09:55:40 -05:00
Jean-Paul Calderone
252f9eb23a
This code has pyflakes warnings *and* is dead.
2019-01-24 09:53:49 -05:00
meejah
768eceacf2
unused var
2018-09-11 11:38:56 -06:00
meejah
1ad2174df9
windows yaml.safe_load returns None on unreadable files..
2018-09-11 11:14:41 -06:00
meejah
7d34f8f1a1
test case when safe_load fails
2018-09-10 21:58:28 -06:00
meejah
419dea7b3a
different import style for multi-imports from allmydata.node
2018-09-10 21:58:28 -06:00
meejah
72f17a3834
better cleanup
2018-09-10 21:58:28 -06:00
meejah
8a6a477ef7
don't depend on .called and .result (use Deferred callbacks properly)
2018-09-10 21:58:28 -06:00
meejah
054ed30757
better docstrings
2018-09-10 21:58:28 -06:00
meejah
87e0ce801a
proper assert
2018-09-10 21:58:28 -06:00
meejah
3cc64649c0
add a pointer to relevant ticket
2018-09-10 21:58:28 -06:00
meejah
d0141b2f95
better docstring from exarkun
2018-09-10 21:58:28 -06:00
meejah
edb581b434
better docstring from exarkun
2018-09-10 21:58:28 -06:00
meejah
507c2db649
better utest docstring, cleanup
2018-09-10 21:58:28 -06:00
meejah
376a1dcbd5
turn XXX into a ticket
2018-09-10 21:58:28 -06:00
meejah
8b5e988755
use docstring to mark method as async
2018-09-10 21:58:28 -06:00
meejah
2e2bdf1ea1
test for EnvironmentError that's not ENOENT
2018-09-10 21:58:28 -06:00
meejah
ab812ca75f
fix utests for Deferred/Failure-returning methods
2018-09-10 21:58:28 -06:00
meejah
676a9efc23
docstring
2018-09-10 21:58:27 -06:00
meejah
714b0887dc
more docstrings
2018-09-10 21:58:27 -06:00
meejah
2d55b61dd2
fixups after rebase
2018-09-10 21:58:27 -06:00
meejah
7632504373
create_client is async
2018-09-10 21:58:27 -06:00
meejah
14a66a54f0
flake8
2018-09-10 21:58:27 -06:00
meejah
0cfbdeb634
dead code
2018-09-10 21:58:27 -06:00
meejah
767f4ddd5d
reorder args to match other method
2018-09-10 21:58:27 -06:00
meejah
045af64c2b
dead code
2018-09-10 21:58:27 -06:00
meejah
06de4c88c4
codecleanup (incorrect merge?)
2018-09-10 21:58:27 -06:00
meejah
edc50f655b
get rid of is_tub_listening
2018-09-10 21:58:27 -06:00
meejah
2517535d2b
test for 'listen on port 0'
2018-09-10 21:58:27 -06:00
meejah
9e34d15b90
simplify _tub_portlocation helper
2018-09-10 21:58:27 -06:00
meejah
e74d2a7d01
get rid of redundant 'introducer_clients' var
2018-09-10 21:58:27 -06:00
meejah
c7b47f44d2
flake8
2018-09-10 21:58:27 -06:00
meejah
17fa32633c
post-rebase fixups; needs review
2018-09-10 21:58:27 -06:00
meejah
23d304814f
not required for tests
2018-09-10 21:58:27 -06:00
meejah
283be23e3a
basedir fixup, more tests
2018-09-10 21:58:27 -06:00
meejah
a628411988
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
c2d1cf4400
correct service-parent in tests
2018-09-10 21:58:27 -06:00
meejah
bb332fecf7
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
548d9cbbcc
basedir fixup
2018-09-10 21:58:27 -06:00
meejah
5d6a76ffee
proper daemonize error-handling
2018-09-10 21:58:27 -06:00
meejah
08e0c3b7e2
get rid of 'add_service' (just an alias to setServiceParent anyway)
2018-09-10 21:58:27 -06:00
meejah
ea99915af6
basedir/config fixup
2018-09-10 21:58:27 -06:00
meejah
26007f363b
pull 'StorageFarmBroker' out of __init__
...
This means also pulling out introducer-clients and some
related utility methods
2018-09-10 21:58:27 -06:00
meejah
465bfb8053
cleanup
2018-09-10 21:58:27 -06:00
meejah
739aaa3ef9
put create() methods in i2p_, tor_provider
...
Also Provider -> _Provider, improve docs and update tests
2018-09-10 21:58:27 -06:00
meejah
f0c3db0e5a
pyflakes
2018-09-10 21:58:27 -06:00
meejah
0ff21ea7d5
all tests pass. wooo
2018-09-10 21:58:27 -06:00
meejah
c7515b5d8b
more working test
2018-09-10 21:58:27 -06:00
meejah
92ca04d629
fix more tests
2018-09-10 21:58:27 -06:00
meejah
0e51bb183e
fix more things
2018-09-10 21:58:27 -06:00
meejah
3c4e065e63
more tests work
2018-09-10 21:58:27 -06:00
meejah
d1307cf05c
fix one more
2018-09-10 21:58:27 -06:00
meejah
43d857a0bd
more refactor + fix some node tests
2018-09-10 21:58:27 -06:00
meejah
71484b4a12
upgrade create_introducer
2018-09-10 21:58:27 -06:00
meejah
d8b432700e
more tests work
2018-09-10 21:58:27 -06:00
meejah
3d5f8becb5
more tests work
2018-09-10 21:58:27 -06:00
meejah
d1a83e9be0
more tests work
2018-09-10 21:58:27 -06:00
meejah
329ef1256a
refactor create_client to be async (works to run, some unit-test fails still)
2018-09-10 21:58:27 -06:00
meejah
0f22b9bad0
fixups after rebase
2018-08-25 02:23:58 -06:00
meejah
65ebde6f9d
fix incorrect rebase resolutions
2018-08-25 02:12:02 -06:00
meejah
dab291c72f
docstring
2018-08-25 02:12:02 -06:00
meejah
74b560c3c2
failUnless -> assert
2018-08-25 02:10:44 -06:00
meejah
7db48e3677
skip using decorator
2018-08-25 02:10:44 -06:00
meejah
89872b832c
docstring, naming improvements
2018-08-25 02:10:44 -06:00
meejah
38dac24b2b
use skipIf decorator, not inline logic
2018-08-25 02:10:44 -06:00
meejah
d478cf3831
add some docstrings, fix comments
2018-08-25 02:10:44 -06:00
meejah
629185d98f
skip some tests on windows (permissions)
2018-08-25 02:10:44 -06:00
meejah
5000787c18
flake8
2018-08-25 02:10:44 -06:00
meejah
27ea11d164
dead code
2018-08-25 02:10:44 -06:00
meejah
abd7b638b8
basic stfpd setup test
2018-08-25 02:10:44 -06:00
meejah
dd2209a96c
tests to cover config changes
2018-08-25 02:10:44 -06:00
meejah
6c388b9d58
test for authtoken API
2018-08-25 02:10:44 -06:00
meejah
ab947704f0
replace PortLocations tests
...
The old tests were hard to read due to all the "if"
statements; these might be slightly more verbose but
also more explicit
2018-08-25 02:10:44 -06:00
meejah
4d7f8ec9dd
keep clientdir for now, improve how we access it
2018-08-25 02:10:44 -06:00
meejah
2937c729e3
change imports; introducer client.read_config
2018-08-25 02:10:44 -06:00
meejah
4c7f60f42a
test fixups from review
2018-08-25 02:10:44 -06:00
meejah
107ddcd1ba
get rid of get_clientdir
2018-08-25 02:10:44 -06:00
meejah
d544284f92
introduce create_node_dir
2018-08-25 02:10:44 -06:00
meejah
c93ee4f867
document a test-method
2018-08-25 02:10:44 -06:00
meejah
86a9ce5793
create _NoNetworkClient using same code as _Client
2018-08-25 02:10:44 -06:00
meejah
35810a5692
pull 'basedir' entirely into _Config
...
Put all config-related methods into _Config; change
code to ask config for paths instead of using basedir;
add some better docstrings
2018-08-25 02:10:44 -06:00
Jean-Paul Calderone
292448a423
Merge pull request #518 from LeastAuthority/test_upload_and_download_random_key
...
Avoid EADDRINUSE from allmydata.test.test_system.SystemTest
Fixes ticket:2933
2018-08-22 09:31:48 -04:00
Jean-Paul Calderone
74420fb764
Try to preserve the working directory
2018-08-17 15:53:59 -06:00
meejah
1af71e6ba3
confirm .stop() called
2018-08-17 15:53:59 -06:00
meejah
03712c9cca
add docstrings
2018-08-17 15:53:59 -06:00
meejah
0607b7331f
fix tests by overriding/patching reactor.stop in tests
2018-08-17 15:53:59 -06:00
meejah
423208f391
add a 'tahoe run' unit-test for config errors
2018-08-17 15:53:59 -06:00
meejah
e9879abc93
add unit-tests
2018-08-17 15:53:59 -06:00
meejah
4aec12a92f
whitespace on long lines
2018-08-17 15:53:59 -06:00
meejah
3723945296
Actually validate configs when loading them
...
An indenting problem meant the validators weren't being
called, which revealed some follow-on errors.
2018-08-17 15:53:59 -06:00
Jean-Paul Calderone
f9d527f418
Avoid the chance of providing a real endpoint parser
...
This endpoint is test-grade.
2018-08-08 12:01:20 -04:00
Jean-Paul Calderone
0ca6b8ed52
An adopted-port-endpoint-based fix for the collision
2018-08-07 15:26:35 -04:00
Jean-Paul Calderone
9ec8ec814a
Some comment improvements
2018-08-07 15:26:19 -04:00
Jean-Paul Calderone
b1520c8d71
Some improved logging while waiting for connections
2018-08-07 15:22:19 -04:00
Jean-Paul Calderone
d8dfcc9de5
There are no such subclasses.
2018-08-07 14:05:16 -04:00
Jean-Paul Calderone
f576575f11
system test setup broken into manageable pieces
...
`set_up_nodes` and `_set_up_nodes_2` now a little easier to understand
2018-08-07 14:04:20 -04:00
Jean-Paul Calderone
814203961d
Merge pull request #504 from exarkun/2929.circleci
...
Configure CircleCI for much of the Linux testing
2018-07-03 12:32:51 -04:00
Jean-Paul Calderone
53adf5083d
Shorten the long path used by the long path test
2018-06-15 08:44:52 -04:00
Jean-Paul Calderone
b31b78e6cf
Merge pull request #501 from exarkun/1595.address-already-in-use-test_introducer-create_tub
...
Fix "Address already in use" errors from test_introducer on POSIX
2018-06-08 16:21:34 -04:00
Jean-Paul Calderone
1911b35499
Get the fcntl import up to the top as well
2018-06-08 13:15:19 -04:00
Jean-Paul Calderone
97e0ad627b
explain the buried reactor import, just in case
2018-06-08 13:13:26 -04:00
Jean-Paul Calderone
2c38b148bf
Move the safe interface import to the top
2018-06-08 13:12:46 -04:00
Jean-Paul Calderone
d25693145c
Factor a little more duplication out of the tests
2018-06-08 11:21:25 -04:00
Jean-Paul Calderone
c491b1a7d4
bring some imports up to the top
2018-06-08 10:36:45 -04:00
Jean-Paul Calderone
28a2e6e557
Merge pull request #502 from exarkun/2926.cli-status-exceptions
...
Fix several cases where `tahoe status` rendering raises an unhandled exception.
Closes ticket:2926
Some possible operation states were not accounted for.
2018-05-28 08:38:42 -04:00
Jean-Paul Calderone
bfedd79633
Merge pull request #487 from tahoe-lafs/1455.x-frame-options.2
...
Set `X-Frame-Options: DENY` for all web status pages.
This prevents attackers from loading web status pages in a frame as a way to trick users into interactions which attackers are restricted from performing unaided.
2018-05-28 08:12:35 -04:00
Jean-Paul Calderone
20084506b3
Handle all the status cases
2018-05-23 13:59:42 -04:00
Jean-Paul Calderone
318eea05e3
docs
2018-05-23 10:59:42 -04:00
Jean-Paul Calderone
8a5e2edb91
Also CLOEXEC the descriptor
...
This avoids leaking it into any child processes that the tests might launch.
2018-05-23 10:56:26 -04:00
Jean-Paul Calderone
be6e458770
Ensure the fd will be valid by the time we listen
2018-05-23 10:50:54 -04:00
Jean-Paul Calderone
62836b6858
Switch another test to the adoption method
2018-05-23 10:47:41 -04:00
Jean-Paul Calderone
711d63960d
Switch another test to the adoption method
2018-05-23 10:47:30 -04:00
Jean-Paul Calderone
277cd16594
Avoid race-prone allocate_tcp_port for some Tubs when possible
...
create_tub on POSIX can pre-allocate a port safely instead.
2018-05-23 10:45:15 -04:00
meejah
c219102afc
Merge pull request #492 from exarkun/2879.magic-folder-create-and-umask.0
...
Create the magic-folder local directory if necessary
2018-05-07 09:49:39 -06:00
meejah
cec3746682
explicit umask and skip part of test on windows
2018-05-01 16:45:50 -06:00
Jean-Paul Calderone
e0c73e0ea1
Merge remote-tracking branch 'origin/master' into 1455.x-frame-options.2
2018-05-01 14:39:48 -04:00
meejah
5414930184
not sure why we assert this
2018-05-01 10:52:12 -06:00
meejah
158498f61a
'positive' version of assert
2018-04-30 14:55:52 -06:00
meejah
04734dcfcb
redundant test code
2018-04-30 14:55:51 -06:00
meejah
6d5355fda3
moar unit-tests
2018-04-30 14:55:51 -06:00
meejah
1f529567ca
fix commented code
2018-04-30 14:55:51 -06:00
meejah
7c71194eea
utest fixup
2018-04-30 14:55:51 -06:00
meejah
5f417c5179
objects_conflicted fixup
2018-04-30 14:55:51 -06:00
meejah
65ceda3a32
fix conflict behavior
2018-04-30 14:55:51 -06:00
meejah
affb80e39e
test fixups
2018-04-30 14:55:51 -06:00
Jean-Paul Calderone
169ccbfbca
directory creation fixes
2018-04-23 18:46:07 -04:00
Jean-Paul Calderone
035dc6dc76
reduce fragility of tests .. maybe?
...
only trivially, at best, of course.
2018-04-23 11:41:36 -04:00
Jean-Paul Calderone
ac6269dd2d
Only read magic-folder config from config reader
...
Also, fix the umask feature which was completely broken previously due
to failure to parse the umask string into an integer.
2018-04-23 10:41:48 -04:00
Jean-Paul Calderone
234db487cd
Add a unit test for X-Frame-Options being set
2018-04-13 12:56:50 -04:00
Jean-Paul Calderone
7bc207cdcb
Shift this out of the way
2018-04-13 12:52:12 -04:00
Jean-Paul Calderone
dc4d30f7c2
Switch to TAHOE_LAFS prefix
2018-04-03 14:07:12 -04:00
Jean-Paul Calderone
6bca749592
this is still needed
2018-04-03 13:59:35 -04:00
Jean-Paul Calderone
f6f617c33c
Teach it about a CI profile
...
This profile does not have time-based warnings.
2018-04-03 13:15:54 -04:00
Jean-Paul Calderone
da2e4a80cd
Get rid of these individual suppressions
2018-04-03 13:15:54 -04:00
Brian Warner
ce473bd5f4
cli.test_alias: move skip-unless utility to common_util.py
...
next to the other skip-unless function
2018-03-28 15:30:24 -07:00
Brian Warner
0616aa7de7
test_absolute_storage_dir: don't use uSNOWMAN on non-unicode platforms
...
Exercising the unicode possibilities are nice, but not critical to this test,
so let's just avoid the non-ascii characters when the filesystem encoding
can't handle them
2018-03-28 15:17:23 -07:00
Brian Warner
0964bc0d05
test_alias: skip unicode tests on non-unicode platform
...
This was flunking the OS-X buildbot, which runs in an environment without
$LANG being set, and thus encodingutil deduces (correctly but unhelpfully)
that we're limited to ASCII. Other tests detect this situation and raise
SkipTest, so let's do that here too.
2018-03-27 15:56:10 -07:00
Jean-Paul Calderone
6ec5005ccd
Merge pull request #474 from exarkun/1587.basic-progress-report
...
Basic progress reporting for `tahoe backup`
Fixes ticket:1587
2018-03-27 07:47:01 -04:00
Jean-Paul Calderone
b78c6cc5ed
Implement the progress reporting
2018-03-26 11:34:31 -04:00
Jean-Paul Calderone
6690aa7337
restore, with tests, checked counters
2018-03-26 10:27:19 -04:00
Jean-Paul Calderone
c55d2823ae
first pass refactoring
...
now collect backup work up-front instead of mixed with processing
2018-03-26 10:02:42 -04:00
Brian Warner
38da8f471c
test_web: appease pyflakes
2018-03-21 00:22:31 -07:00
Brian Warner
e6ddd03338
test_web: remove noisy print statement
2018-03-21 00:13:52 -07:00
meejah
643e2f9107
fix windows, maybe
2018-03-20 11:40:50 -06:00
meejah
fcfcbaa6a2
fix behavior of fake fileops test-helper
2018-03-20 11:40:49 -06:00
meejah
2fd2a9b2c7
nicer assert
2018-03-20 11:40:49 -06:00
meejah
9df84e71fe
use better error-testing idiom and don't tweak internal method
2018-03-20 11:40:49 -06:00
meejah
ee0f548aa7
describe test
2018-03-20 11:40:49 -06:00
meejah
a06fe375ec
describe test
2018-03-20 11:40:49 -06:00
meejah
c7cbb4a6b3
better var names
2018-03-20 11:40:49 -06:00
meejah
9032539860
flake8; naming
2018-03-20 11:40:49 -06:00
meejah
797932244d
log failure properly, add test
2018-03-20 11:40:49 -06:00
meejah
39080852cc
ensure 'in progress' items return status
2018-03-20 11:40:49 -06:00
meejah
1f495ec41f
cover uploads and downloads in tests
2018-03-20 11:40:49 -06:00
meejah
75e97e6c6d
use QueuedItem directly instead of FakeStatusItem
2018-03-20 11:40:49 -06:00
meejah
472d6ba78b
cover some of get_status
2018-03-20 11:40:49 -06:00
meejah
bfabfeba64
add 'size' to tests, print unicode
2018-03-20 11:40:49 -06:00
Jean-Paul Calderone
1f92879788
improve test coverage
2018-03-19 14:21:28 -04:00
Ruben Pollan
136de7d7f7
Add storage_dir config field
...
On the [storage] section of the tahoe.cfg now there is a field
'storage_dir' where the path to the storage folder can be configured.
2018-03-19 11:20:04 -04:00
meejah
a1cb401f06
Merge pull request #452 from meejah/list-aliases-json.1
...
Add --json option to 'tahoe list aliases'
2018-03-13 17:05:20 -06:00
tpltnt
0461cc0148
only one module import per line
2018-03-02 16:45:11 +01:00
meejah
3466088717
add --json option for 'tahoe list-aliases'
...
some new tests to cover previously-uncovered code that changed
2018-01-05 18:07:52 -07:00
tpltnt
c5e8d83b73
removed old test/trial helper module
2018-01-04 22:09:52 +01:00
meejah
5f00842532
use exarkun's suggestion from review
2018-01-03 14:07:38 -07:00
meejah
e5d6272b62
use '5 years ago' instead of absolute timestamp
2017-12-20 13:17:54 -07:00
meejah
6c0c90829f
cheezy test for more coverage
2017-12-05 12:02:16 -07:00
meejah
87ad3cb8e9
fix 2880
...
- remember upload URI so we don't re-download
- account for empty files in "should_download"
- fix 'conflicted' asserts in tests
2017-12-05 12:02:16 -07:00
meejah
672475cb2b
Multiple magic-folders
...
This moves all magic-folder configs to a single YAML
file. We load legacy config fine and don't mess with
legacy config unless you use a magic-folder command that
changes the config.
Increase test coverage
2017-12-05 10:34:48 -07:00
meejah
1b6f477549
Pull "config" handling out of Node and hide node-derivitives
...
This includes:
- refactor to create_client and _Client
- refactor to _IntroducerNode and create_introducer
2017-11-20 12:57:20 -07:00
meejah
50f8397c99
Merge branch 'invalid-pidfile' into delete-invalid-pidfile--lpirl
...
Conflicts:
src/allmydata/scripts/startstop_node.py
src/allmydata/test/cli/test_cli.py
2017-11-08 14:49:29 -07:00
Brian Warner
a1711088ed
test_i2p_provider: exercise escaping of apiEndpoint attribute
2017-11-03 00:24:46 -07:00
Brian Warner
1f1afe65ec
tor_provider.get_listener(): return a real endpoint, instead of a descriptor
...
get_listener() is allowed to return either, and the Tor provider is currently
simple enough to not really need more than a basic descriptor, but have it
return a full Endpoint for use as an example of what I2P can do later.
2017-11-03 00:24:46 -07:00
Brian Warner
d713e0e57d
address review feedback: docstrings, better test class name
2017-11-03 00:24:46 -07:00
Brian Warner
097abb42fa
tahoe.cfg: add tub.port=listen:i2p (and/or listen:tor)
...
This delegates the construction of the server Endpoint object to the i2p/tor
Provider, which can use the i2p/tor section of the config file to add options
which would be awkward to express as text in an endpoint descriptor string.
refs ticket:2889 (but note this merely makes room for a function to be
written that can process I2CP options, it does not actually handle such
options, so it does not close this ticket yet)
2017-11-03 00:24:46 -07:00
Brian Warner
d1fd43aa4f
tor/i2p: rename create_onion/create_dest to create_config
2017-11-03 00:24:46 -07:00
meejah
263a3f43c1
stop chdir
2017-09-19 10:39:19 -06:00
meejah
9375056b61
Split up startstop_node and add 'tahoe daemonize'
...
This sets the stage for further changes to the startup
process so that "async things" are done before we create
the Client instance while still reporting early failures
to the shell where "tahoe start" is running
Also adds a bunch of test-coverage for the things that got
moved around, even though they didn't have coverage before
2017-09-19 10:39:19 -06:00
Lukas Pirl
89bacbb70a
Merge branch 'master' into invalid-pidfile
2017-08-24 18:40:00 +02:00
Lukas Pirl
46305c74e1
added test for (ignoring an) invalid PID file when starting a node
2017-08-24 17:56:57 +02:00
Jean-Paul Calderone
86f79e8111
Add a test for the non-numeric case
2017-08-24 16:46:46 +02:00
Jean-Paul Calderone
354567cb85
Add a test for the non-numeric case
2017-08-24 10:34:58 -04:00
Brian Warner
8dd0a5f772
dictutil: remove unused move, subtract, del_if_present
2017-08-12 21:48:05 -07:00
Brian Warner
61b85dbf78
dictutil: remove unused ValueOrderedDict
2017-08-12 21:34:24 -07:00
Brian Warner
4f493b1a03
remove unused UtilDict
2017-08-12 21:31:47 -07:00
Brian Warner
a76d9e084f
dictutil: remove unused NumDict
2017-08-12 21:21:04 -07:00
Brian Warner
3f2f7dfb05
dictutil: fix bug in str(ValueOrderedDict), and improve test coverage
...
It looks like str() was meant to truncate the dict, but a missing i+=1 meant
that it never actually did. I also changed the format to include a clear
"..." in case we truncate it, to avoid confusion with a non-truncated dict of
the same size.
This also improves test coverage in subtract() and
NumDict.item_with_largest_value().
refs ticket:2891
2017-08-10 10:27:02 -07:00
Brian Warner
95ac5494ff
test_backupdb: tolerate newer sqlite-3.20.0 error messages
2017-08-10 10:21:39 -07:00
meejah
798bf57e28
Add 'tahoe invite' and 'tahoe create-node --join' commands
...
This opens a wormhole and sends appropriate JSON down
it to a tahoe-gui using a wormhole server running on
tahoe-lafs.org
The other end uses the 'tahoe create-node' command (with
new --join option) to read the configuration JSON from
a 'tahoe invite' command
2017-08-08 18:27:06 -06:00
meejah
e2a5751d02
at least use random port
2017-08-08 10:42:11 -06:00
Brian Warner
05317d4d12
test_web: replace all shouldHTTPError with assertHTTPError
...
and update to inlineCallbacks while we're in there
2017-07-27 16:31:44 -07:00
Brian Warner
2687ee90c5
test_web: remove last traces of deprecated client.getPage
2017-07-27 16:31:44 -07:00
Brian Warner
965e974ce8
test_web: fix POST(url,body) calls that should have been POST2()
...
and remove the followRedirect= argument from POST
2017-07-27 16:31:44 -07:00
Brian Warner
0deb903888
test_web: rewrite all POST(followRedirect=True) calls with do_http
...
Since POST() is about to lose followRedirect=True
2017-07-27 16:31:44 -07:00
Brian Warner
3f03367d2f
test_web: remove all other uses of shouldRedirect
2017-07-27 16:31:44 -07:00
Brian Warner
76063b1c12
test_web: replace some instances of shouldRedirect with shouldRedirectTo
2017-07-27 16:31:44 -07:00
Brian Warner
6be91e369c
test_web: replace shouldReplace2 with shouldReplaceTo
...
This removes many uses of self.POST (since shouldReplaceTo does its own
HTTP), which will make it easier to remove client.getPage from POST.
2017-07-27 16:31:44 -07:00
Brian Warner
4745239c2c
test_web: use inlineCallbacks in many functions
...
specifically everywhere we use self.shouldRedirect2
2017-07-27 16:31:44 -07:00
Brian Warner
73d09082d7
test_web.web.Web.POST: split out build_form() helper function
2017-07-27 16:31:44 -07:00
Brian Warner
202a9714c4
test_web test_bad_method: remove a client.getPage
...
Add WebErrorMixin.assertHTTPError, to replace (getPage + shouldHTTPError)
2017-07-27 16:31:44 -07:00
Brian Warner
bee05e883c
test_web: remove HTTPClientGETFactory
...
This also changes the tests to handle the new API: URL can be unicode, and
the returned Headers object is not a dictionary.
2017-07-27 16:31:44 -07:00
Brian Warner
5a895b5fb6
GridTestMixin.GET: use treq instead of HTTPClientGETFactory
2017-07-27 16:31:44 -07:00
Brian Warner
3311f9520d
test.cli.test_status: replace getPage with treq
2017-07-27 16:31:44 -07:00
Brian Warner
bd1e4507ee
remove unused HTTPClientHEADFactory
2017-07-27 16:31:44 -07:00
Jean-Paul Calderone
e32f581d07
Get rid of the reliance on rref
...
It provides information more correctly obtained from
get_connection_status().
2017-07-27 16:31:41 -04:00
Jean-Paul Calderone
1f16a173f0
flatten the result structure
...
flat is better than nested
2017-07-27 15:32:47 -04:00
Jean-Paul Calderone
7027547ecc
fix buggy test; restructure data
...
scared about duplicate nodeids in the data getting lost, switch to a list
2017-07-27 15:26:30 -04:00
Jean-Paul Calderone
f518c2a521
Switch over to stdlib json
2017-07-27 15:26:30 -04:00
Jean-Paul Calderone
e339130e63
Just make an assertion against the full value
2017-07-27 15:26:30 -04:00
Jean-Paul Calderone
e3e49632a5
use preferred spelling for new assertions
2017-07-27 15:26:30 -04:00
David Stainton
cd97f8519b
web test: get_version should use a version string
2017-07-27 15:26:29 -04:00
David Stainton
923363c0d6
web test: test for server key in json welcome
2017-07-27 15:26:29 -04:00
David Stainton
ecb6651926
Add basic unit test for json welcome page
2017-07-27 15:26:29 -04:00
Jean-Paul Calderone
7c8c63a01f
a helper for the ?t=json resources
2017-07-27 13:57:02 -04:00
Brian Warner
ad92b2b9b2
test_web: replace HEAD/PUT/DELETE with treq
2017-07-12 17:10:49 -07:00
Brian Warner
486fca0d5c
web.test_introducer: replace getPage with treq
2017-07-12 17:10:49 -07:00
Brian Warner
8be5072fca
test_system: replace getPage with treq
2017-07-12 17:10:49 -07:00
Brian Warner
2ec3791411
test_deepcheck: replace t.w.client.getPage with treq
2017-07-12 17:10:46 -07:00
Brian Warner
74e7ef4b98
test_happiness: limit string sizes to 30 chars
...
I think these are supposed to represent share ids or server ids, so we don't
need to exercise them being too huge.
2017-07-12 16:37:44 -07:00
Brian Warner
11c39325fb
test_happiness: suppress the hypothesis 'too_slow' check
...
I was seeing buildbot failures where the host machine was too busy, and
hypothesis was spooked into thinking that data generation was too slow.
2017-07-12 16:27:13 -07:00
meejah
0977e52cbf
Add a test for 'tahoe list-aliases --readonly-uri'
2017-06-06 18:03:05 +01:00
meejah
05f48c3601
Various cleanups, fixes and improvements
...
Squashed all commits that were meejah's between
30d68fb499f300a393fa0ced5980229f4bb6efda
and
33c268ed3a8c63a809f4403e307ecc13d848b1ab
On the branch meejah:1382.markberger-rewrite-rebase.6 as
per review
2017-06-05 16:31:41 -06:00
David Stainton
19c5bbb43b
Fix test test_lost_servers
...
Remove old hypothesis tests
Fix allmydata.test.cli.test_cli.Errors.test_get
this was broken due to differing share placements
whereas we need to allow this.
Fix test_5_overdue_immutable
This change makes the test not depend on the value
of PYTHONHASHSEED.
Revert "Fix test_5_overdue_immutable"
This reverts commit 5f3696d9a53e7df8781a2c463c7112282397cd69.
fix test to actually hang the first 5 *servers*
sort keys for stable output
use file-context-managers
remove probably-unneeded assert (that fails sometimes)
another non-deterministic test?
2017-06-05 16:26:46 -06:00
meejah
56f6dbd363
distribute only to read/write peers
...
correctly calculate happiness
guard with except
fix tests, and happiness calculation
remove debug
fix placements to None
happiness calc shouldn't have to filter None
WIP fixing some tests etc
2017-06-05 16:26:46 -06:00
David Stainton
a611673934
Make a correction to a hypothesis test comment
...
Comment out all debug print statements
Add hypothesis tests for the old servers of happiness implementation
Attempt to speed up meejah's servers of happiness
WIP
Fix test_calc_happy
WIP
2017-06-05 16:26:46 -06:00
meejah
b6d9945b95
default answer for every share
...
refactor hypothesis to be 'pytest style' and add another one
get rid of 'shares->set(1 thing)' in generate_mappings return
Add a unittest hypothesis came up with
fix tests since we return peers, not sets-of-1-peer
add more debug
add a unit-test that's like test_problem_layout_ticket_1128
fix bug
add a note
fix utest
unit-test for bigger numbers
re-insert markberger code for testing
results of pairing with david
2017-06-05 16:26:46 -06:00
David Stainton
e68b331bb1
Add servers of happiness hypothesis testing
...
Fix happiness test var names
Remove unused imports
Get rid of trailing whitespace
2017-06-05 16:26:46 -06:00
meejah
ef17ef2c62
fix happiness calculation
...
unit-test for happiness calculation
unused function
put old servers_of_happiness() calculation back for now
test for calculate_happiness
remove some redundant functions
2017-06-05 16:26:46 -06:00
David Stainton
42011e775d
Make correction to docstring for Tahoe2ServerSelector's _handle_existing_response
...
Add comments 10 and 8 from the servers of happiness spec
Fix bug in _filter_g3 for servers of happiness
Remove usage of HappinessUpload class
here we modifying the PeerSelector class.
we make sure to correctly calculate the happiness value
by ignoring keys who's value are None...
Remove HappinessUpload and tests
Replace helper servers_of_happiness
we replace it's previous implementation with a new
wrapper function that uses share_placement
2017-06-05 16:26:46 -06:00
meejah
adb9a98383
WIP: refactoring (squahshed all meejah's commits)
2017-06-05 16:26:46 -06:00
Mark Berger
17cff7a176
Implements 'Servers of Happiness' algorithm for upload
...
This is Mark Berger's original commits, from ticket #1382
2017-06-05 16:26:46 -06:00
meejah
4f1dd95963
Add a 'tahoe status' command
...
This required also fixing the JSON output from
the "recent and active operations" page.
2017-04-04 12:48:41 -06:00
Brian Warner
2ceea6df0d
Merge PR406: use @implementer instead of implements
...
This also updates several classes to be new-style (inheriting from 'object').
2017-03-23 19:25:56 -07:00
Brian Warner
0abcbe3339
update some comments where plain cut+paste was confusing
2017-03-23 19:19:00 -07:00
meejah
49ae2c5eb7
use @implementer instead of implements
...
Also, derive some more things from 'object'
2017-02-27 11:01:30 -07:00
meejah
031a88c25f
simplejson -> json
2017-02-23 15:21:36 -07:00
Brian Warner
6db7686a8f
update tests to match
2017-01-17 20:12:55 -05:00
Brian Warner
ee58637813
fix syntax (tcp=disabled, not =none), add test
2017-01-10 16:30:04 -08:00
Brian Warner
64e344b03a
introducer.yaml: ascii-fy furls before use
...
This fixes the foolscap-rejects-unicode-furls problem which prevented a
correctly-formatted introducers.yaml from working.
closes ticket:2862
2017-01-08 22:59:51 -08:00
Brian Warner
582931b1c2
docs: recommend proper introducers.yaml syntax
...
add a test to exercise that this syntax is parseable, and another to point
out that the previously-recommended syntax was not
refs ticket:2862
2017-01-08 22:59:51 -08:00
Stefan Lew
481a02aee7
made tests work with new attribute rel="noreferrer"
2016-12-23 23:20:52 -05:00
Vladimir Rusinov
0d47e12e40
Add some docstrings.
2016-12-23 22:50:48 -05:00
Vladimir Rusinov
a95f2743ef
Add test for deep-stats api version.
2016-12-23 22:50:48 -05:00
Brian Warner
9303d20ed7
test_magic_folder: improve coverage
2016-12-14 21:20:37 -08:00
meejah
37c7d54bd3
keeps defaults in CreateClientOptions but makes shares-* required?
2016-12-13 19:50:19 -07:00
meejah
5b8be255d7
Set total/needed/happy from command-line
2016-12-13 18:52:45 -07:00
Brian Warner
5cbe580d90
improve ConnectionStatus and welcome-page display
...
* replace "last_details" with "non_connected_statuses" dict
* rename "last_connection_summary" to just "summary"
* for connected servers, show other hints in a tooltip
* for not-yet-connected servers, show all hints in a list
* build the list (in STAN) on the server side, not using IContainer
2016-12-09 18:41:38 -08:00
Brian Warner
8b35fe9efe
tests: exercise connection_status.py
2016-12-09 11:46:26 -08:00
Brian Warner
38935bbca6
remove old unused connection-status APIs
2016-12-08 16:25:00 -08:00
Brian Warner
77fd41b66e
update WUI welcome page with new connection-status info
...
This shows current-connection info, and provides per-hint status details in a
tooltip.
The "Connection" section no longer shows seconds-since-loss when the server
was not connected (previously it showed seconds-since-connect when connected,
and flipped to seconds-since-loss when disconnected). We already have the
"Last RX" column, which is arguably more meaningful (and I can't think of a
good case when these would differ), so we don't really need
seconds-since-loss, and the new ConnectionStatus doesn't track it anyways.
So now the "Connection" timestamp for non-connected servers is just
"N/A" (both the main text and the tooltip). The "Introducers" section was
changed the same way.
This moves the per-server connection timestamp out of the nickname/serverid
box and over into the Connection box. It also right-floats all timestamps,
regardless of which box they're in, which makes them share the box with
connection_status more politely.
Internally, this adds code to create ConnectionStatus objects when necessary.
2016-12-08 16:24:32 -08:00
Brian Warner
8d008967e7
tor_provider: use new Foolscap API to provide better status
2016-12-08 15:41:37 -08:00
Brian Warner
d5f3d47483
test/cli/test_create: remove errant print()
2016-12-08 14:59:11 -08:00
Brian Warner
250c6f6054
test_magic_folder: mark failing test as .todo
...
As discussed in this week's meeting, since we don't yet know why some
flavors of linux have slightly different inotify behavior than others,
and since we believe the actual functionality is not significantly
impacted, and since the red buildbot is reducing our confidence that the
other tests are passing, and since we have a release coming up: we're
marking the one troublesome test as ".todo". We expect that the test
will be fixed soon (perhaps to accept either 3 or 4 events), but not
necessarily before the 1.12 release.
refs ticket:2834
2016-11-02 13:31:22 -07:00
meejah
783449b4f3
When tor or i2p options are present, confirm we have txi2p or txtorcon
...
We mock out some import methods and provide tests for providing
server-side or client-side tor/i2p options
2016-10-26 13:41:10 -06:00
meejah
da4e1589bb
Rename _turn_delay and friends to make things more clear
...
This forces the Uploader and Downloader to implement a _scan_delay
method and makes the naming more consistent with what's actually
happening. Also, fix a few "bugs" in the names of args in the
mocks for some tests.
2016-10-25 12:38:57 -07:00
meejah
ddaa29ce39
refactor/white-space MagicFolder creation
2016-10-25 12:38:57 -07:00
Brian Warner
4d003c026e
test_magic_folder: remove unused debug code
2016-10-24 09:23:26 -07:00
Brian Warner
ae5637dc9c
test_magic_folder: turn off debugging when done
2016-10-24 09:23:16 -07:00
David Stainton
d6cbe44786
Enable debug logging for test_move_tree magic-folder unit test
2016-10-24 09:15:09 -07:00
str4d
6071c2b6f8
Implement i2p_provider and --listen=i2p
...
Closes ticket:2838
2016-10-23 20:30:01 -05:00
Brian Warner
6d3a20e78b
test_tor_provider: accept windows pathname separators
2016-10-09 01:49:32 -04:00
Brian Warner
ea1c1d27de
fix tests to match
2016-10-09 01:22:17 -04:00
Brian Warner
89eb86c5a4
node.py: use tor_provider at startup
...
We use it for two things: to create the foolscap connection handler, and
to possibly start an .onion listener at startup.
This also updates node._common_config_sections to accept the new tor
settings written by create-node/create-introducer.
2016-10-09 01:21:51 -04:00
Brian Warner
6b9218ff22
create_node.py: use tor_provider to handle --listen=tor
...
This adds tor-related CLI arguments to "create-node" and
"create-introducer", to control exactly how we should be using Tor.
* --tor-launch
* --tor-executable=
* --tor-control-port=
I went with "--tor-launch" instead of "--launch-tor" for consistency. I
don't particularly like the grammatical flow of it, and it doesn't
actually put all the tor-related arguments next to each other in the
--help output (the flags are put in one block, then the parameters in
the next). But it seems slightly more consistent to start all the
tor-related argument names with a "--tor*" prefix.
2016-10-09 01:21:51 -04:00
Brian Warner
a1741ce4dc
rewrite tor_provider
...
This uses a unix-domain control port, and includes test coverage.
create_onion() displays pacifier messages, since the allocate-onion step
takes around 35 seconds
2016-10-09 01:21:47 -04:00
Brian Warner
f549000121
test_create: get full coverage on create_node.py
2016-10-09 00:29:29 -04:00
Brian Warner
395f7cd4f0
create_node: prep for slow write_node_config()
...
This puts the right inlineCallbacks in place to allow
write_node_config() to return a Deferred. The upcoming Tor support will
need this (since it must wait for an .onion address to be allocated
before it can write tahoe.cfg's tub.port and tub.location lines).
2016-10-09 00:24:11 -04:00
Daira Hopwood
4d18425ed4
Fix for Magic Folder tests if the I/O encoding is borked on Unicode platforms (OS X, Windows).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-09-27 18:05:09 +01:00
Daira Hopwood
64841e339d
Remove redundant use of NonASCIIPathMixin.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-09-27 16:16:19 +01:00
Daira Hopwood
c9d73a936a
Fix Unicode-related Magic Folder test failures. fixes #2807
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-09-27 16:09:15 +01:00
Brian Warner
5ef04ef59e
add hashutil.permute_server_hash
...
which uses SHA1 to combine the file's storage index (known as "peer
selection index" in this context) and each server's "server permutation
seed". This is the only thing in tahoe that uses SHA1.
With this change, we stop importing sha1 from anywhere else.
2016-09-26 20:42:42 -07:00
Brian Warner
b00c2d21b7
test tub.port with multiple endpoints, add docs
...
I think the preferred way to listen on both IPv4 and IPv6 will be to use
"--port=tcp:PORT,tcp6:PORT". This is now reflected in the docs.
refs ticket:867
2016-09-20 13:04:06 -07:00
Brian Warner
b9b731e3e2
update test to match new output
2016-09-20 10:14:35 -07:00
Brian Warner
a638a97806
implement connections:tcp=disabled
...
This enables an I2P-only node, which disables TCP entirely (instead of
mapping TCP to Tor, which was the only other option that
reveal-IP-address=False would allow).
closes ticket:2824
2016-09-14 16:27:12 -07:00
Brian Warner
02ba2a05c3
implement --listen=none, use it for create-client
...
Improve docs on server configuration to explain --listen options.
2016-09-14 16:12:32 -07:00
Brian Warner
a8f02d6684
enhance tests
2016-09-13 22:05:48 -07:00
David Stainton
9943a268ce
Make the create-node --hide-ip option set [connections]tcp=tor
2016-09-13 10:15:45 +00:00
Brian Warner
d802135db1
test introducerless config
...
refs ticket:68
2016-09-12 17:45:17 -07:00
Brian Warner
4ae574cca0
test_multi_introducers: add more tests
2016-09-12 17:30:06 -07:00
David Stainton
4f717ba808
Add a multi-introducer implementation
...
this is based the previous work of warner, killyourtv and leif
fixes ticket #68
2016-09-13 00:15:52 +00:00
Brian Warner
3b17289569
create_node: simplify validation, clean up tests
2016-09-09 18:53:22 -07:00
Brian Warner
229e306e9d
test_runner: fix to use new conventions
...
create-node needs --hostname=, and we can't expect the node to write
client.port at startup (because tahoe.cfg now has tub.port= set
properly)
2016-09-09 18:53:22 -07:00
Brian Warner
9a1a186197
simplify tests: use parse_cli, assertRaises, assertFailure
...
parse_cli() got added during the async-CLI-dispatch work
assertRaises/assertFailure have been in Twisted for a while, but I only
learned about them recently. Over time I'm looking forward to changing
all tahoe tests to use them (and getting rid of ShouldFailMixin/etc).
2016-09-09 18:52:01 -07:00
Brian Warner
7d3b4149ae
remove leftover debug prints
2016-09-09 18:51:57 -07:00
Brian Warner
09ce7963c6
fixes
2016-09-09 17:29:20 -07:00
David Stainton
e9c1075ac5
Make corrections from Daira's code review
2016-09-09 17:29:16 -07:00
David Stainton
31dfee2dcd
fix cli test create tests
2016-09-09 17:10:22 -07:00
David Stainton
83db7e8b43
Add create node args: listen, port, hostname, location
...
fixes ticket: 2773
2016-09-09 17:10:22 -07:00
Brian Warner
802cfc87fe
CLI: allow dispatch functions to return Deferred
...
In addition, CLI functions are allowed to use sys.exit() instead of
always needing to return the exit code as an integer.
runner.py now knows about the blocking httplib calls in scripts/cli and
scripts/magic_folder, and uses deferToThread() to invoke them. Those
functions cannot return a Deferred: when rewrite them to use twisted.web
or treq, we'll remove this deferToThread call.
Option parsing was split out to a separate function for testing. We now
use twisted.internet.task.react() to start the reactor, which required
changing the way runner.py is tested.
closes ticket:2826
2016-09-09 15:52:42 -07:00
Brian Warner
97c29a3c0b
test_runner: factor out parse_cli() helper
2016-09-09 15:41:00 -07:00