Jean-Paul Calderone
066e98874b
Point at do_cli_unicode here too
2020-12-10 07:17:24 -05:00
Jean-Paul Calderone
d0c22a529e
json.dumps output should always be ascii
2020-12-10 07:16:00 -05:00
Jean-Paul Calderone
2f53225765
better helper name
2020-12-10 07:06:01 -05:00
Jean-Paul Calderone
4bb28cadcb
motivate its existence a bit more
2020-12-10 07:04:28 -05:00
Jean-Paul Calderone
c39f7721af
run_cli_bytes docstring
2020-12-10 07:03:24 -05:00
Jean-Paul Calderone
61ee26fb00
ticket reference
2020-12-07 10:46:20 -05:00
Jean-Paul Calderone
1a77ba5698
remove redundant u prefix
2020-12-07 10:37:25 -05:00
Jean-Paul Calderone
d6d64f6b27
fix the json case
2020-12-07 10:37:22 -05:00
Jean-Paul Calderone
87e808b392
one more switch
2020-12-07 10:18:05 -05:00
Jean-Paul Calderone
c7358e6639
Switch over to the helper in the two functions that matter for this PR
2020-12-07 10:16:48 -05:00
Jean-Paul Calderone
a8e3424ef6
remove another unrelated change that's no longer required
2020-12-07 09:55:27 -05:00
Jean-Paul Calderone
d2664121b9
backout no-longer required unrelated change
2020-12-07 09:51:34 -05:00
Jean-Paul Calderone
72744c9464
more docstrings and properly support (and use) encoding=None throughout
2020-12-07 09:47:48 -05:00
Jean-Paul Calderone
05d271c7c8
a little more exposition
2020-12-07 09:26:58 -05:00
Jean-Paul Calderone
7b3a5aceb8
These tests can't reach any of the codepaths where quote_output matters
...
So simplify
2020-12-07 09:21:56 -05:00
Jean-Paul Calderone
f4432d3f23
Respect the provided encoding
...
UTF-8 is great but if we're claiming the encoding is something else everywhere
else we can't just make it UTF-8 here.
2020-12-07 09:12:38 -05:00
Jean-Paul Calderone
56f141e170
decode instead of encoding in maybe_decode
...
legacy from when the bytes/unicode tower was upsidedown compared to how it is now
2020-12-07 09:12:04 -05:00
Jean-Paul Calderone
72a5b571ca
Only test the cases we can make work everywhere
...
These tests previously (in this branch) tried to exercise more ``show_output``
logic than they can actually reach due to the requirement that argv be
interpretable. Shrink the test suite down to just what we can squeeze through
argv and deal with fully testing ``show_output`` elsewhere.
2020-12-07 09:10:59 -05:00
Jean-Paul Calderone
93b30d0dde
The implementation can't reliably see the encoding we're faking without this
2020-12-07 09:06:21 -05:00
Jean-Paul Calderone
8ca98bb8ca
using run_cli_unicode, better expect unicode result
2020-12-07 09:06:00 -05:00
Jean-Paul Calderone
c12b082fa7
Put run_cli back largely how it was
...
Also deal with StringIO better in show_output
2020-12-06 20:37:28 -05:00
Jean-Paul Calderone
613777d166
Make sure this one is bytes too
2020-12-06 19:23:13 -05:00
Jean-Paul Calderone
5aee8b422d
Oops there's another case
2020-12-06 18:39:09 -05:00
Jean-Paul Calderone
2955d22f72
note a problem with test_system
2020-12-06 18:38:51 -05:00
Jean-Paul Calderone
b464fa6483
docstring
2020-12-06 18:28:11 -05:00
Jean-Paul Calderone
77bebb9916
[wip] remove mock from test_alias, along with a bunch of encoding-related changes :/
2020-12-06 17:00:34 -05:00
Jean-Paul Calderone
c4b58fe00b
unused import
2020-12-06 11:04:19 -05:00
Jean-Paul Calderone
d29210a140
unused import
2020-12-06 11:04:05 -05:00
Jean-Paul Calderone
238590d7fd
Remove mock by removing a bunch of unicode shenanigans
2020-12-06 11:03:44 -05:00
Jean-Paul Calderone
24709fa758
Merge branch 'master' into 3547.furl-py36-regression
2020-12-05 13:29:27 -05:00
Jean-Paul Calderone
d7f005badd
Merge branch 'master' into 3520.test_client-no-mock
2020-12-05 12:55:25 -05:00
Jean-Paul Calderone
ac7491680b
fix unicode/bytes stuff in the affected tests
2020-12-05 09:06:45 -05:00
Jean-Paul Calderone
bdc75c3361
Merge remote-tracking branch 'origin/master' into 3539.nodemaker-weakrefdict
2020-12-05 07:23:54 -05:00
Jean-Paul Calderone
15d0207f89
Merge pull request #897 from tahoe-lafs/3504.private-introducer-furl
...
Deprecate tahoe.cfg [client]introducer.furl
Fixes: ticket:3504
2020-12-04 09:44:19 -05:00
Itamar Turner-Trauring
71d287c1c1
Merge pull request #905 from tahoe-lafs/3514.test-introducer-python-3
...
Port test_introducer.py to Python 3
Fixes ticket:3514
2020-12-02 15:24:17 -05:00
Jean-Paul Calderone
a0d46c6f09
Merge remote-tracking branch 'origin/master' into 3504.private-introducer-furl
2020-12-02 09:22:09 -05:00
Itamar Turner-Trauring
587222033d
Fix bad merge.
2020-12-01 11:58:56 -05:00
Itamar Turner-Trauring
27102c0d89
Merge remote-tracking branch 'origin/master' into 3514.test-introducer-python-3
2020-11-30 16:47:21 -05:00
Itamar Turner-Trauring
8615c1ade8
Try to fix sorting on Python 3.
2020-11-30 16:45:14 -05:00
Itamar Turner-Trauring
eaca639b6f
Undo changes that should probably be in a different branch.
2020-11-30 16:28:26 -05:00
Itamar Turner-Trauring
413cf75d54
Uses clearer issuperset().
2020-11-30 16:25:24 -05:00
Itamar Turner-Trauring
9f7ae56a82
Make the explanation less nonsensical.
2020-11-30 16:24:27 -05:00
Jean-Paul Calderone
17ed8afd2f
Make the new test data files installable
...
There's an existing rule that matches *.txt
2020-11-30 13:37:21 -05:00
Jean-Paul Calderone
ef2f7e6136
unused import
2020-11-30 13:27:46 -05:00
Jean-Paul Calderone
2ac4af7fb4
Add some direct tests for NodeMaker.create_from_uri
2020-11-30 13:26:32 -05:00
Jean-Paul Calderone
4ca45aaa93
Catch basedir type errors earlier
2020-11-30 13:23:18 -05:00
Jean-Paul Calderone
01ab8d3ee9
Don't look before you leap
2020-11-30 08:56:45 -05:00
Jean-Paul Calderone
84088e4f41
unused import
2020-11-26 21:18:58 -05:00
Jean-Paul Calderone
805378ef11
Do more path stuff with FilePath
2020-11-26 20:53:57 -05:00
Jean-Paul Calderone
a978fcf433
Replace asserts with explicit checks and TypeError
2020-11-26 19:35:39 -05:00
