From fda3d38c8591c4517cb2c968348f4ed6ec22ffac Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone Date: Mon, 11 Mar 2019 12:31:44 -0400 Subject: [PATCH] Avoid the extra dict lookup in the loop Get the info at iteration time --- src/allmydata/frontends/magic_folder.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/allmydata/frontends/magic_folder.py b/src/allmydata/frontends/magic_folder.py index fa4b549e1..5251e65dd 100644 --- a/src/allmydata/frontends/magic_folder.py +++ b/src/allmydata/frontends/magic_folder.py @@ -1913,8 +1913,8 @@ class Downloader(QueueMixin, WriteFileMixin): def _filter_batch_to_deque(ign): ITEM_QUEUE.log(items=self._deque) SCAN_BATCH.log(batch=scan_batch) - for relpath_u in scan_batch: - file_node, metadata = max(scan_batch[relpath_u], key=lambda x: x[1]['version']) + for relpath_u, versions in scan_batch.iteritems(): + file_node, metadata = max(versions, key=lambda x: x[1]['version']) if self._should_download(relpath_u, metadata['version'], file_node.get_readonly_uri()): to_dl = DownloadItem(