From e52a7fbdd77464f21f68a9dd279ce5d4159f8fdc Mon Sep 17 00:00:00 2001
From: meejah <meejah@meejah.ca>
Date: Wed, 4 Dec 2024 23:50:44 -0700
Subject: [PATCH] reviewer doesn't like -latest

cherry-picked from #1395
---
 .github/workflows/ci.yml | 22 +++++++++++-----------
 newsfragments/4141.minor |  1 +
 2 files changed, 12 insertions(+), 11 deletions(-)
 create mode 100644 newsfragments/4141.minor

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1f549f574..ce9ec61ee 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -45,14 +45,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: macos-12
+          - os: macos-14
             python-version: "3.12"
           # We only support PyPy on Linux at the moment.
-          - os: ubuntu-latest
+          - os: ubuntu-22.04
             python-version: "pypy-3.9"
-          - os: ubuntu-latest
+          - os: ubuntu-22.04
             python-version: "3.12"
-          - os: windows-latest
+          - os: windows-2022
             python-version: "3.12"
 
     steps:
@@ -140,7 +140,7 @@ jobs:
   finish-coverage-report:
     needs:
       - "coverage"
-    runs-on: "ubuntu-latest"
+    runs-on: "ubuntu-22.04"
     container: "python:3-slim"
     steps:
       - name: "Indicate completion to coveralls.io"
@@ -160,8 +160,8 @@ jobs:
           # 22.04 has some issue with Tor at the moment:
           # https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3943
           - ubuntu-20.04
-          - macos-12
-          - windows-latest
+          - macos-14
+          - windows-2022
         python-version:
           - "3.11"
         force-foolscap:
@@ -185,7 +185,7 @@ jobs:
           brew install tor
 
       - name: Install Tor [Windows]
-        if: matrix.os == 'windows-latest'
+        if: matrix.os == 'windows-2022'
         uses: crazy-max/ghaction-chocolatey@v2
         with:
           args: install tor
@@ -242,9 +242,9 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-12
-          - windows-latest
-          - ubuntu-latest
+          - macos-14
+          - windows-2022
+          - ubuntu-22.04
         python-version:
           - 3.9
 
diff --git a/newsfragments/4141.minor b/newsfragments/4141.minor
new file mode 100644
index 000000000..226ce238f
--- /dev/null
+++ b/newsfragments/4141.minor
@@ -0,0 +1 @@
+pinning base images of builders to improve reproducibility on checks for PRs
\ No newline at end of file