ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2024-12-19 21:17:54 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Technically this doesn't matter, because it's client-side, but it's good habit.

Browse Source
This commit is contained in:
Itamar Turner-Trauring 2022-03-25 10:45:54 -04:00
parent be0ff08275
commit e50d88f46d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/allmydata/storage/http_client.py
View File

@ -35,6 +35,7 @@ from .http_common import (
get_spki_hash,
)
from .common import si_b2a
from ..util.hashutil import timing_safe_compare
def _encode_si(si): # type: (bytes) -> str
@ -103,9 +104,8 @@ class _TLSContextFactory(CertificateOptions):
19, # X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN
)
# TODO can we do this once instead of multiple times?
if (
errno in things_are_ok
and get_spki_hash(cert.to_cryptography()) == expected_spki_hash
if errno in things_are_ok and timing_safe_compare(
get_spki_hash(cert.to_cryptography()), expected_spki_hash
):
return 1
# TODO: log the details of the error, because otherwise they get