ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-06-18 15:28:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Just skip usage of reconfigure() on Windows.

Browse Source
This commit is contained in:
Itamar Turner-Trauring
2023-02-20 11:54:50 -05:00
parent 3686fe7fa3
commit e3ad50a084
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
integration/test_get_put.py
View File

@ -4,6 +4,7 @@ and stdout.
""" """
from subprocess import Popen, PIPE, check_output from subprocess import Popen, PIPE, check_output
import sys
import pytest import pytest
from pytest_twisted import ensureDeferred from pytest_twisted import ensureDeferred
@ -66,6 +67,10 @@ def test_get_to_stdout(alice, get_put_alias, tmpdir):
assert p.wait() == 0 assert p.wait() == 0
@pytest.mark.skipif(
sys.platform.startswith("win"),
reason="reconfigure() has issues on Windows"
)
@ensureDeferred @ensureDeferred
async def test_upload_download_immutable_different_default_max_segment_size(alice, get_put_alias, tmpdir, request): async def test_upload_download_immutable_different_default_max_segment_size(alice, get_put_alias, tmpdir, request):
""" """

5
integration/util.py
View File

@ -738,6 +738,8 @@ async def reconfigure(reactor, request, node: TahoeProcess,
Reconfigure a Tahoe-LAFS node with different ZFEC parameters and Reconfigure a Tahoe-LAFS node with different ZFEC parameters and
convergence secret. convergence secret.
TODO This appears to have issues on Windows.
If the current configuration is different from the specified If the current configuration is different from the specified
configuration, the node will be restarted so it takes effect. configuration, the node will be restarted so it takes effect.
@ -753,6 +755,9 @@ async def reconfigure(reactor, request, node: TahoeProcess,
:return: ``None`` after the node configuration has been rewritten, the :return: ``None`` after the node configuration has been rewritten, the
node has been restarted, and the node is ready to provide service. node has been restarted, and the node is ready to provide service.
""" """
# TODO reconfigure() seems to have issues on Windows. If you need to use it
# there, delete this assert and try to figure out what's going on...
assert not sys.platform.startswith("win")
happy, needed, total = params happy, needed, total = params
config = node.get_config() config = node.get_config()