From ddfe20c8ab90543202b65e9eab6a9ceae0873852 Mon Sep 17 00:00:00 2001
From: Sajith Sasidharan <sajith@hcoop.net>
Date: Wed, 15 Jul 2020 13:24:20 -0400
Subject: [PATCH] Use SlotsSequenceElement correctly

---
 src/allmydata/web/check_results.py         | 8 ++++----
 src/allmydata/web/deep-check-results.xhtml | 8 ++++++--
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/allmydata/web/check_results.py b/src/allmydata/web/check_results.py
index c8165a67b..f459b1f50 100644
--- a/src/allmydata/web/check_results.py
+++ b/src/allmydata/web/check_results.py
@@ -502,9 +502,9 @@ class DeepCheckResultsRendererElement(Element, ResultsBase, ReloadMixin):
                     summary_text = ": " + summary
                 summary_text += " [SI: %s]" % cr.get_storage_index_string()
                 problems.append({
-                    # TODO: result of _join_pathstring() seems to be
-                    # weird.  Might as well use "path" as the key here?
-                    self._join_pathstring(path): self._html(summary_text)
+                    # Not sure self._join_pathstring(path) is the
+                    # right thing to use here.
+                    "problem": self._html(path) + self._html(summary_text),
                 })
 
         return SlotsSequenceElement(tag, problems)
@@ -529,7 +529,7 @@ class DeepCheckResultsRendererElement(Element, ResultsBase, ReloadMixin):
             nickname = server.get_nickname()
             if nickname:
                 name.append(" (%s)" % self._html(nickname))
-            problems.append(name)
+            problems.append({"problem": name})
 
         return SlotsSequenceElement(tag, problems)
 
diff --git a/src/allmydata/web/deep-check-results.xhtml b/src/allmydata/web/deep-check-results.xhtml
index abe9bfd63..f3b2e7d75 100644
--- a/src/allmydata/web/deep-check-results.xhtml
+++ b/src/allmydata/web/deep-check-results.xhtml
@@ -25,7 +25,9 @@
 <h2>Files/Directories That Had Problems:</h2>
 
 <ul t:render="problems">
-  <li t:render="item" />
+  <li t:render="item">
+    <t:slot name="problem" />
+  </li>
   <li t:render="empty">None</li>
 </ul>
 </div>
@@ -34,7 +36,9 @@
 <div t:render="servers_with_corrupt_shares_p">
 <h2>Servers on which corrupt shares were found</h2>
 <ul t:render="servers_with_corrupt_shares">
-  <li t:render="item"/>
+  <li t:render="item">
+    <t:slot name="problem" />
+  </li>
   <li t:render="empty">None</li>
 </ul>
 </div>