ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2024-12-23 14:52:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure we update remaining length, and update test to catch the edge case

Browse Source 
this fixes.
This commit is contained in:
Itamar Turner-Trauring 2022-07-06 09:40:46 -04:00
parent 5c5556d915
commit dac0080ea2
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/allmydata/storage/http_client.py
View File

@ -125,7 +125,8 @@ class _LengthLimitedCollector:
f: BytesIO = field(factory=BytesIO)
def __call__(self, data: bytes):
if len(data) > self.remaining_length:
self.remaining_length -= len(data)
if self.remaining_length < 0:
raise ValueError("Response length was too long")
self.f.write(data)

2
src/allmydata/test/test_storage_http.py
View File

@ -337,7 +337,7 @@ class CustomHTTPServerTests(SyncTestCase):
``http_client.limited_content()`` returns the body if it is less than
the max length.
"""
for at_least_length in (length, length + 1, length + 1000):
for at_least_length in (length, length + 1, length + 1000, length + 100_000):
response = result_of(
self.client.request(
"GET",