ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2024-12-20 05:28:04 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

introduction/storage-broker: add assertions of serverids being the right type and of internal consistency between the number of storage servers known and the number of storage servers

Browse Source
This commit is contained in:
Zooko O'Whielacronx 2009-07-17 06:52:21 -07:00
parent 1192b61dfe
commit d2d3bb2f80
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/allmydata/storage_client.py
View File

@ -33,6 +33,7 @@ from zope.interface import implements, Interface
from foolscap.api import eventually
from allmydata.interfaces import IStorageBroker
from allmydata.util import idlib, log
from allmydata.util.assertutil import _assert, precondition
from allmydata.util.rrefutil import add_version_to_remote_reference
# who is responsible for de-duplication?
@ -68,7 +69,7 @@ class StorageFarmBroker:
# descriptor manages its own Reconnector, and will give us a
# RemoteReference when we ask them for it.
self.descriptors = {}
# self.servers are statically configured from unit tests
# self.test_servers are statically configured from unit tests
self.test_servers = {} # serverid -> rref
self.introducer_client = None
@ -83,6 +84,8 @@ class StorageFarmBroker:
ic.subscribe_to("storage", self._got_announcement)
def _got_announcement(self, serverid, ann_d):
precondition(isinstance(serverid, str), serverid)
precondition(len(serverid) == 20, serverid)
assert ann_d["service-name"] == "storage"
old = self.descriptors.get(serverid)
if old:
@ -127,7 +130,9 @@ class StorageFarmBroker:
rref = dsc.get_rref()
if rref:
servers[serverid] = rref
return frozenset(servers.items())
result = frozenset(servers.items())
_assert(len(result) <= len(self.get_all_serverids()), result, self.get_all_serverids())
return result
def get_all_serverids(self):
serverids = set()