From cda97e4fa63deac934e3085e8bc0edb0a30b85da Mon Sep 17 00:00:00 2001 From: Itamar Turner-Trauring Date: Mon, 17 Apr 2023 10:06:50 -0400 Subject: [PATCH] Remove pylint, replacing with faster alternative. --- tox.ini | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tox.ini b/tox.ini index 447745784..982157bf1 100644 --- a/tox.ini +++ b/tox.ini @@ -100,9 +100,7 @@ commands = [testenv:codechecks] basepython = python3 deps = - # Make sure we get a version of PyLint that respects config, and isn't too - # old. - pylint < 2.18, >2.14 + ruff # On macOS, git inside of towncrier needs $HOME. passenv = HOME setenv = @@ -114,9 +112,10 @@ commands = python misc/coding_tools/check-umids.py {posargs:{env:DEFAULT_FILES}} python misc/coding_tools/check-debugging.py {posargs:{env:DEFAULT_FILES}} python misc/coding_tools/find-trailing-spaces.py -r {posargs:{env:DEFAULT_FILES}} - # PyLint has other useful checks, might want to enable them: - # http://pylint.pycqa.org/en/latest/technical_reference/features.html - pylint --disable=all --enable=cell-var-from-loop {posargs:{env:DEFAULT_FILES}} + # B023: Find loop variables that aren't bound in a loop, equivalent of pylint + # cell-var-from-loop. + # ruff could probably replace flake8 and perhaps above tools as well... + ruff check --select=B023 {posargs:{env:DEFAULT_FILES}} # If towncrier.check fails, you forgot to add a towncrier news # fragment explaining the change in this branch. Create one at