ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-04-08 03:14:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

include the filename on URI-link urls for files

Browse Source 
this is likely to induce browsers to do more useful things with the result
than they would when given neither content-type nor filename.  (i.e. they
can guess that a .jpg file is an image, even with a bogus content type)
This commit is contained in:
robk-org 2007-07-11 15:26:47 -07:00
parent 8b2c5dcd15
commit cacc9ac7b1
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/allmydata/webish.py
View File

@ -83,13 +83,8 @@ class Directory(rend.Page):
delete = "-"
ctx.fillSlots("delete", delete)
# build the base of the uri_link link url
uri_link = urllib.quote(target.get_uri().replace("/", "!"))
childdata = [T.a(href="%s?t=json" % name)["JSON"], ", ",
T.a(href="%s?t=uri" % name)["URI"], ", ",
T.a(href="%s?t=readonly-uri" % name)["readonly-URI"], ", ",
T.a(href="/uri/%s" % uri_link)["URI-link"],
]
ctx.fillSlots("data", childdata)
if IFileNode.providedBy(target):
# file
@ -112,6 +107,9 @@ class Directory(rend.Page):
size = "?"
ctx.fillSlots("size", size)
# if we're a file, add the filename to the uri_link url
uri_link += '?%s' % (urllib.urlencode({'filename': name}),)
elif IDirectoryNode.providedBy(target):
# directory
subdir_url = urllib.quote(name)
@ -125,6 +123,14 @@ class Directory(rend.Page):
ctx.fillSlots("size", "-")
else:
raise RuntimeError("unknown thing %s" % (target,))
childdata = [T.a(href="%s?t=json" % name)["JSON"], ", ",
T.a(href="%s?t=uri" % name)["URI"], ", ",
T.a(href="%s?t=readonly-uri" % name)["readonly-URI"], ", ",
T.a(href="/uri/%s" % uri_link)["URI-link"],
]
ctx.fillSlots("data", childdata)
return ctx.tag
def render_forms(self, ctx, data):