From ae2abd1b2e3b7b9d11dcac1961549782637b4d4c Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone Date: Wed, 18 Dec 2019 15:23:07 -0500 Subject: [PATCH 1/2] try making it frozen instead of fiddling with cmp --- src/allmydata/test/storage_plugin.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/allmydata/test/storage_plugin.py b/src/allmydata/test/storage_plugin.py index e35e97f43..43186122c 100644 --- a/src/allmydata/test/storage_plugin.py +++ b/src/allmydata/test/storage_plugin.py @@ -104,10 +104,9 @@ class GetCounter(Resource, object): @implementer(RIDummy) -@attr.s(cmp=True, hash=True) +@attr.s(frozen=True) class DummyStorageServer(object): - # TODO Requirement of some interface that instances be hashable - get_anonymous_storage_server = attr.ib(cmp=False) + get_anonymous_storage_server = attr.ib() def remote_just_some_method(self): pass From 010a14abe7c600116ef07c1f9c918ab1543a424f Mon Sep 17 00:00:00 2001 From: Jean-Paul Calderone Date: Wed, 18 Dec 2019 15:24:21 -0500 Subject: [PATCH 2/2] news fragment --- newsfragments/3268.minor | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 newsfragments/3268.minor diff --git a/newsfragments/3268.minor b/newsfragments/3268.minor new file mode 100644 index 000000000..e69de29bb