make-version.py: use 'subprocess' module instead of 'commands', to improve windows compatibility

This commit is contained in:
Brian Warner 2007-05-16 11:57:20 -07:00
parent 9b70d17d4b
commit b90d4a243e

View File

@ -33,8 +33,9 @@ get 'darcs changes --from-tag=' to accept real regexps).
"""
import os, sys, commands, re
import os, sys, re
import xml.dom.minidom
from subprocess import Popen, PIPE
def get_text(nodelist):
rc = ""
@ -68,8 +69,10 @@ def update():
return 0
print "no _darcs/ but no version.py either: how did you get this tree?"
return 0
cmd = "darcs changes --from-tag=^allmydata-tahoe --xml-output"
(rc, output) = commands.getstatusoutput(cmd)
cmd = ["darcs", "changes", "--from-tag=^allmydata-tahoe", "--xml-output"]
p = Popen(cmd, stdout=PIPE)
output = p.communicate()[0]
rc = p.returncode
if rc != 0:
print "unable to run 'darcs changes':"
print output