ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-02-01 08:48:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

make the nodeurl start with '127.0.0.1' instead of with 'localhost'

Browse Source 
This is because there exist in the wild computers that are misconfigured so that 'localhost' doesn't resolve to 127.0.0.1.  On those computers, using 'localhost' for the nodeurl is a security problem, because the user commonly sends valuable caps to the nodeurl.
This commit is contained in:
Zooko O'Whielacronx 2008-03-11 06:18:03 -07:00
parent ec3f140824
commit a8a85da326
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/allmydata/webish.py
View File

@ -1579,9 +1579,9 @@ class WebishServer(service.MultiService):
# what is our webport? # what is our webport?
s = self.listener s = self.listener
if isinstance(s, internet.TCPServer): if isinstance(s, internet.TCPServer):
base_url = "http://localhost:%d" % s._port.getHost().port base_url = "http://127.0.0.1:%d" % s._port.getHost().port
elif isinstance(s, internet.SSLServer): elif isinstance(s, internet.SSLServer):
base_url = "https://localhost:%d" % s._port.getHost().port base_url = "https://127.0.0.1:%d" % s._port.getHost().port
else: else:
base_url = None base_url = None
if base_url: if base_url: