From e04cbb1867df504a1c97734cf5da435c4a0ab5b6 Mon Sep 17 00:00:00 2001 From: Florian Sesser Date: Mon, 2 Dec 2024 17:06:29 +0000 Subject: [PATCH 1/4] More unique names for test logs - maybe works like this? --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 855a201d6..9062f4852 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,13 +95,13 @@ jobs: - name: Upload eliot.log uses: actions/upload-artifact@v4 with: - name: eliot-${{ matrix.runs-on }}.log + name: eliot-${{ matrix.os }}-${{ matrix.python-version }}.log path: eliot.log - name: Upload trial log uses: actions/upload-artifact@v4 with: - name: test-${{ matrix.runs-on }}.log + name: test-${{ matrix.os }}-${{ matrix.python-version }}.log path: _trial_temp/test.log # Upload this job's coverage data to Coveralls. While there is a GitHub @@ -233,7 +233,7 @@ jobs: uses: actions/upload-artifact@v4 if: failure() with: - name: integration.eliot-${{ matrix.run-on }}.json + name: integration.eliot-${{ matrix.os }}-${{ matrix.python-version }}.json path: integration.eliot.json packaging: From 0053cf49510e4d8caa23483e16933c70114cc50b Mon Sep 17 00:00:00 2001 From: Florian Sesser Date: Mon, 2 Dec 2024 17:07:11 +0000 Subject: [PATCH 2/4] (No) news. --- newsfragments/4132.minor | 1 + 1 file changed, 1 insertion(+) diff --git a/newsfragments/4132.minor b/newsfragments/4132.minor index e69de29bb..8d1c8b69c 100644 --- a/newsfragments/4132.minor +++ b/newsfragments/4132.minor @@ -0,0 +1 @@ + From 6df845c0f69d4e81e8d497b55c2a6e1ec2a1ec12 Mon Sep 17 00:00:00 2001 From: Florian Sesser Date: Mon, 2 Dec 2024 17:23:18 +0000 Subject: [PATCH 3/4] Be more in line with other test result file names --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9062f4852..196e83130 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,13 +95,13 @@ jobs: - name: Upload eliot.log uses: actions/upload-artifact@v4 with: - name: eliot-${{ matrix.os }}-${{ matrix.python-version }}.log + name: "eliot-${{ matrix.os }}-Python-${{ matrix.python-version }}.log" path: eliot.log - name: Upload trial log uses: actions/upload-artifact@v4 with: - name: test-${{ matrix.os }}-${{ matrix.python-version }}.log + name: "test-${{ matrix.os }}-Python-${{ matrix.python-version }}.log" path: _trial_temp/test.log # Upload this job's coverage data to Coveralls. While there is a GitHub @@ -233,7 +233,7 @@ jobs: uses: actions/upload-artifact@v4 if: failure() with: - name: integration.eliot-${{ matrix.os }}-${{ matrix.python-version }}.json + name: "integration.eliot-${{ matrix.os }}-Python--${{ matrix.python-version }}.json" path: integration.eliot.json packaging: From 9109cebdb6b15904f224a0aa1bab323a8d5588f1 Mon Sep 17 00:00:00 2001 From: Florian Sesser Date: Mon, 2 Dec 2024 17:29:39 +0000 Subject: [PATCH 4/4] Typo --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 196e83130..1f549f574 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -233,7 +233,7 @@ jobs: uses: actions/upload-artifact@v4 if: failure() with: - name: "integration.eliot-${{ matrix.os }}-Python--${{ matrix.python-version }}.json" + name: "integration.eliot-${{ matrix.os }}-Python-${{ matrix.python-version }}.json" path: integration.eliot.json packaging: